You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2020/01/12 11:26:13 UTC

svn commit: r1872650 - /pdfbox/branches/issue4569/tools/src/main/java/org/apache/pdfbox/tools/ExtractImages.java

Author: tilman
Date: Sun Jan 12 11:26:13 2020
New Revision: 1872650

URL: http://svn.apache.org/viewvc?rev=1872650&view=rev
Log:
PDFBOX-4071: change confusing field names

Modified:
    pdfbox/branches/issue4569/tools/src/main/java/org/apache/pdfbox/tools/ExtractImages.java

Modified: pdfbox/branches/issue4569/tools/src/main/java/org/apache/pdfbox/tools/ExtractImages.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/issue4569/tools/src/main/java/org/apache/pdfbox/tools/ExtractImages.java?rev=1872650&r1=1872649&r2=1872650&view=diff
==============================================================================
--- pdfbox/branches/issue4569/tools/src/main/java/org/apache/pdfbox/tools/ExtractImages.java (original)
+++ pdfbox/branches/issue4569/tools/src/main/java/org/apache/pdfbox/tools/ExtractImages.java Sun Jan 12 11:26:13 2020
@@ -67,8 +67,8 @@ public final class ExtractImages
             COSName.DCT_DECODE.getName(),
             COSName.DCT_DECODE_ABBREVIATION.getName());
 
-    private boolean directJPEG;
-    private String prefix;
+    private boolean useDirectJPEG;
+    private String filePrefix;
 
     private final Set<COSStream> seen = new HashSet<>();
     private int imageCounter = 1;
@@ -121,10 +121,10 @@ public final class ExtractImages
                         {
                             usage();
                         }
-                        prefix = args[i];
+                        filePrefix = args[i];
                         break;
                     case DIRECTJPEG:
-                        directJPEG = true;
+                        useDirectJPEG = true;
                         break;
                     default:
                         if (pdfFile == null)
@@ -140,9 +140,9 @@ public final class ExtractImages
             }
             else
             {
-                if (prefix == null && pdfFile.length() >4)
+                if (filePrefix == null && pdfFile.length() > 4)
                 {
-                    prefix = pdfFile.substring(0, pdfFile.length() -4);
+                    filePrefix = pdfFile.substring(0, pdfFile.length() - 4);
                 }
 
                 extract(pdfFile, password);
@@ -233,11 +233,11 @@ public final class ExtractImages
             }
 
             // save image
-            String name = prefix + "-" + imageCounter;
+            String name = filePrefix + "-" + imageCounter;
             imageCounter++;
 
             System.out.println("Writing image: " + name);
-            write2file(pdImage, name, directJPEG);
+            write2file(pdImage, name, useDirectJPEG);
         }
 
         @Override