[GitHub] [incubator-pinot] siddharthteotia commented on issue #4368: 3891: Check for validity of segment start/end time during segment generation

[GitBox <gi...@apache.org>]

siddharthteotia commented on issue #4368: 3891: Check for validity of segment start/end time during segment generation
URL: https://github.com/apache/incubator-pinot/pull/4368#issuecomment-509859008
 
 
   @jackjlli . @mayankshriv , @mcvsubbu 
   
   Got a clean build. Please review the changes when you get a chance. It took some iterations to make the time check code robust since it has to work with multiple TimeSpecs and both EPOCH and SIMPLE_DATE_FORMAT time column types.
   
   Coming to tests where validity check is explicitly disabled -- as I mentioned earlier, I will create a PR (once this is merged) to clean up the avro data sets used by these tests. 
   
   Some unit tests have been changed to generate valid data (for e.g PinotSegmentUtil) and a new unit test has been added to SegmentGenerationTimecolumnTest to test the newly added exception code in SegmentColumnarIndexCreator
   
   I am seeing if a couple of more unit tests can be added. Meanwhile, it would be great to get feedback on the changes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org