You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by chengqiangboy <gi...@git.apache.org> on 2016/05/22 14:48:15 UTC
[GitHub] spark pull request: fix SPARK-15429
GitHub user chengqiangboy opened a pull request:
https://github.com/apache/spark/pull/13255
fix SPARK-15429
Make PIDRateEstimator more suitable to the situation of `spark.streaming.concurrentJobs > 1`
## What changes were proposed in this pull request?
First, add a new parameter `concurrentJobs` to PIDRateEstimator.
Second, We can change the `error = latestRate - processingRate` to `error = latestRate - processingRate * concurrentJobs.toDouble`. And change the `historicalError = schedulingDelay.toDouble * processingRate / batchIntervalMillis` to `historicalError = schedulingDelay.toDouble * processingRate * concurrentJobs.toDouble / batchIntervalMillis`.
## How was this patch tested?
Use `PIDRateEstimatorSuite` to test.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chengqiangboy/spark SPARK-15429
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/13255.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13255
----
commit 661e8ddad43f356a73fa47f00b589b99c8ca9349
Author: cq365423762 <cq...@qq.com>
Date: 2016-05-22T14:35:48Z
Make PIDRateEstimator more suitable to the situation of
`spark.streaming.concurrentJobs > 1`
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13255: [SPARK-15429] [Streaming] Make PIDRateEstimator more sui...
Posted by tdas <gi...@git.apache.org>.
Github user tdas commented on the issue:
https://github.com/apache/spark/pull/13255
Hello @chengqiangboy I am sorry that we didnt take a look at this PR earlier. But the problem is that `concurrentJobs` is not officially supported because there are fault-tolerance guarantee issues with it. So making the rate estimator more complicated is not the best option. Thanks nonetheless for trying this. But mind closing this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: fix SPARK-15429
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13255#issuecomment-220836515
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #13255: [SPARK-15429] [Streaming] Make PIDRateEstimator m...
Posted by chengqiangboy <gi...@git.apache.org>.
Github user chengqiangboy closed the pull request at:
https://github.com/apache/spark/pull/13255
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13255: [SPARK-15429] [Streaming] Make PIDRateEstimator more sui...
Posted by chengqiangboy <gi...@git.apache.org>.
Github user chengqiangboy commented on the issue:
https://github.com/apache/spark/pull/13255
@tdas Thank you for your reply.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: fix SPARK-15429
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/13255#issuecomment-220837482
@chengqiangboy fix the title please?
https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org