[GitHub] [arrow] amol- edited a comment on pull request #10713: ARROW-12837: [C++] Do not crash when printing invalid arrays

[GitBox <gi...@apache.org>]

amol- edited a comment on pull request #10713:
URL: https://github.com/apache/arrow/pull/10713#issuecomment-885548327


   > As I said, why not. But any work trying to enhance the validity check here will end up reproducing what's already done by `Validate` and `ValidateFull`.
   
   Thanks for pointing out `Validate`. I tried to replace the usage of my custom method with a call to `Validate` and it passes my test, so it's already verifying for the condition I was trying to catch. Locally I had 9 failures when running all tests but were unrelated ( most of them about `PARQUET_TEST_DATA` not being set), so I hope that we can just reuse validate without any side effect.
   
   PS: If the CI confirms that I haven't broke anything else, I plan to also try extending the `<invalid array>` message with something that reports the `Status::Invalid`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org