You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nifi.apache.org by bbende <gi...@git.apache.org> on 2016/03/08 16:30:48 UTC
[GitHub] nifi pull request: NIFI-1599 Changing DatagramChannelDispatcher, s...
GitHub user bbende opened a pull request:
https://github.com/apache/nifi/pull/262
NIFI-1599 Changing DatagramChannelDispatcher, socket handlers, and RE…
…LP handler to use offer() when queueing instead of put(), and log an error if the offer failed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bbende/nifi NIFI-1599
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/262.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #262
----
commit 537c19c1b351ecaccc1a583f1a6be764ec0dd945
Author: Bryan Bende <bb...@apache.org>
Date: 2016-03-07T22:21:11Z
NIFI-1599 Changing DatagramChannelDispatcher, socket handlers, and RELP handler to use offer() when queueing instead of put(), and log an error if the offer failed
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1599 Changing DatagramChannelDispatcher, s...
Posted by bbende <gi...@git.apache.org>.
Github user bbende commented on the pull request:
https://github.com/apache/nifi/pull/262#issuecomment-193929305
@olegz I didn't want to get into a complete refactoring of the different handlers/dispatchers, as there are some complicated subtleties there, but I took another shot and tried to at least ensure that the queuing logic is shared across them with a class that wraps the blocking queue.
I supposed it could have been a static utility method, but I'm not usually a fan of static methods that need to take a lot of parameters.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1599 Changing DatagramChannelDispatcher, s...
Posted by bbende <gi...@git.apache.org>.
Github user bbende closed the pull request at:
https://github.com/apache/nifi/pull/262
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---