You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/09/30 11:51:29 UTC
[GitHub] [bookkeeper] Shawyeok opened a new pull request, #3512: Reduce unnecessary loop in removeIf if map is empty
Shawyeok opened a new pull request, #3512:
URL: https://github.com/apache/bookkeeper/pull/3512
### Motivation
After unload all bundles of a heavy pulsar broker, cpu usage is still above 50%, here is a cpu profile and a heapdump
<img width="1665" alt="image" src="https://user-images.githubusercontent.com/5058708/193253189-1cfd66d4-11ab-4850-9768-eeb113ba0ce1.png">
<img width="1680" alt="image" src="https://user-images.githubusercontent.com/5058708/193262269-d68f5268-f256-4fc7-9f0d-a2c6321ee2c6.png">
- [28726.html.zip](https://github.com/apache/bookkeeper/files/9683416/28726.html.zip)
It looks like there's a schedule task executing `BookieClientImpl#monitorPendingOperations`.
Most of `completionObjects` in `PerChannelBookieClient` are empty.
IMO, it's worth to check whether a section is empty or not in loop predication.
### Changes
Add `size > 0` into `Section#removeIf` loop predication.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3512: Reduce unnecessary loop in removeIf if map is empty
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3512:
URL: https://github.com/apache/bookkeeper/pull/3512#issuecomment-1264839740
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT merged pull request #3512: Reduce unnecessary loop in removeIf if map is empty
Posted by GitBox <gi...@apache.org>.
StevenLuMT merged PR #3512:
URL: https://github.com/apache/bookkeeper/pull/3512
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3512: Reduce unnecessary loop in removeIf if map is empty
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3512:
URL: https://github.com/apache/bookkeeper/pull/3512#issuecomment-1264831575
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org