You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/11/30 03:49:09 UTC

[GitHub] [inlong] wangpeix opened a new pull request, #6684: [INLONG-6675][Sort] Sort does not report metrics because Flink Sql missing the metrics.audit.proxy.hosts parameter

wangpeix opened a new pull request, #6684:
URL: https://github.com/apache/inlong/pull/6684

   ### Prepare a Pull Request
   
   - Title: [INLONG-6675][Sort] Sort does not report metrics because Flink Sql missing the metrics.audit.proxy.hosts parameter
   
   - Fixes #6675 
   
   ### Motivation
   
   Fix `metrics.audit.proxy.hosts` parameter missing problem.
   
   ### Modifications
   
   Pass the `metrics.audit.proxy.hosts` parameter to `org.apache.inlong.sort.Entrance`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] healchow commented on pull request #6684: [INLONG-6675][Sort] Sort does not report metrics because Flink Sql missing the metrics.audit.proxy.hosts parameter

Posted by GitBox <gi...@apache.org>.
healchow commented on PR #6684:
URL: https://github.com/apache/inlong/pull/6684#issuecomment-1332290577

   We recommend not creating a new PR, because all of the comments of this PR will not appear in your newly PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] wangpeix closed pull request #6684: [INLONG-6675][Sort] Sort does not report metrics because Flink Sql missing the metrics.audit.proxy.hosts parameter

Posted by GitBox <gi...@apache.org>.
wangpeix closed pull request #6684: [INLONG-6675][Sort] Sort does not report metrics because Flink Sql missing the metrics.audit.proxy.hosts parameter
URL: https://github.com/apache/inlong/pull/6684


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] wangpeix commented on pull request #6684: [INLONG-6675][Sort] Sort does not report metrics because Flink Sql missing the metrics.audit.proxy.hosts parameter

Posted by GitBox <gi...@apache.org>.
wangpeix commented on PR #6684:
URL: https://github.com/apache/inlong/pull/6684#issuecomment-1332399305

   Thanks for reminding, thanks @healchow 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] wangpeix commented on a diff in pull request #6684: [INLONG-6675][Sort] Sort does not report metrics because Flink Sql missing the metrics.audit.proxy.hosts parameter

Posted by GitBox <gi...@apache.org>.
wangpeix commented on code in PR #6684:
URL: https://github.com/apache/inlong/pull/6684#discussion_r1035841169


##########
inlong-sort/sort-core/src/main/java/org/apache/inlong/sort/Entrance.java:
##########
@@ -58,7 +58,8 @@ public static void main(String[] args) throws Exception {
         Parser parser;
         if (StringUtils.isEmpty(sqlFile)) {
             final GroupInfo groupInfo = getGroupInfoFromFile(config.getString(Constants.GROUP_INFO_FILE));
-            parser = FlinkSqlParser.getInstance(tableEnv, groupInfo);
+            String auditProxyHosts = config.getString(Constants.METRICS_AUDIT_PROXY_HOSTS);
+            parser = FlinkSqlParser.getInstance(tableEnv, groupInfo, auditProxyHosts);

Review Comment:
   ok, thanks. I will resubmit a pr and optimize it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] gong commented on a diff in pull request #6684: [INLONG-6675][Sort] Sort does not report metrics because Flink Sql missing the metrics.audit.proxy.hosts parameter

Posted by GitBox <gi...@apache.org>.
gong commented on code in PR #6684:
URL: https://github.com/apache/inlong/pull/6684#discussion_r1035505229


##########
inlong-sort/sort-core/src/main/java/org/apache/inlong/sort/Entrance.java:
##########
@@ -58,7 +58,8 @@ public static void main(String[] args) throws Exception {
         Parser parser;
         if (StringUtils.isEmpty(sqlFile)) {
             final GroupInfo groupInfo = getGroupInfoFromFile(config.getString(Constants.GROUP_INFO_FILE));
-            parser = FlinkSqlParser.getInstance(tableEnv, groupInfo);
+            String auditProxyHosts = config.getString(Constants.METRICS_AUDIT_PROXY_HOSTS);
+            parser = FlinkSqlParser.getInstance(tableEnv, groupInfo, auditProxyHosts);

Review Comment:
   I suggest just set `auditProxyHosts` to properties of gruopInfo. not to change FlinkSqlParser.getInstance.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org