@JsfPhaseListener - Alternative name?

[Thomas Andraschko <an...@gmail.com>]

Hi,

as we introduced @DeltaSpike now and replaced the redundant @Web with it,
maybe we can discuss @JsfPhaseListener, too.

We could also use @DeltaSpike in this case but @JsfPhaseListener also
contains an ordinal attribute.

Gerhard mentioned that the idea was to combine it in one annotation as it's
easier for the user.

JEE7 introduced @Ordinal - we could follow this by introducing something
like @DeltaSpikeOrdinal.

It's the same as with @DeltaSpike -> we could manage co-existence with
other features in the future too because we can't reuse JEE7' @Ordinal.

Regards,
Thomas

Re: @JsfPhaseListener - Alternative name?

[Gerhard Petracek <ge...@gmail.com>]

-1, because you would get e.g.:

@DeltaSpike
@DeltaSpikeOrdinal(1)
public class MyPhaseListener implements PhaseListener
{
    //...
}

for sure it's a matter of taste, but imo it looks strange...
(+ as mentioned earlier, it isn't consistent with other parts.)

regards,
gerhard



2014-03-06 20:11 GMT+01:00 Thomas Andraschko <an...@gmail.com>:

> Hi,
>
> as we introduced @DeltaSpike now and replaced the redundant @Web with it,
> maybe we can discuss @JsfPhaseListener, too.
>
> We could also use @DeltaSpike in this case but @JsfPhaseListener also
> contains an ordinal attribute.
>
> Gerhard mentioned that the idea was to combine it in one annotation as it's
> easier for the user.
>
> JEE7 introduced @Ordinal - we could follow this by introducing something
> like @DeltaSpikeOrdinal.
>
> It's the same as with @DeltaSpike -> we could manage co-existence with
> other features in the future too because we can't reuse JEE7' @Ordinal.
>
> Regards,
> Thomas
>