[GitHub] [incubator-doris] HappenLee commented on a diff in pull request #10060: [Bug] Fix bug push value predicate of unique table when have sequence column

[GitBox <gi...@apache.org>]

HappenLee commented on code in PR #10060:
URL: https://github.com/apache/incubator-doris/pull/10060#discussion_r895090672


##########
be/src/olap/rowset/beta_rowset_reader.cpp:
##########
@@ -237,4 +235,12 @@ Status BetaRowsetReader::next_block(vectorized::Block* block) {
     return Status::OK();
 }
 
+bool BetaRowsetReader::_should_push_down_value_predicates() const {

Review Comment:
   not need. `not_overlapping()` means the rowset is compactioned, after compactioned the sequence column have same key only keep one row



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org