[GitHub] [druid] gianm commented on pull request #12011: Enhancements to IndexTaskClient.

[GitBox <gi...@apache.org>]

gianm commented on pull request #12011:
URL: https://github.com/apache/druid/pull/12011#issuecomment-983943224


   The patch was getting nailed on test coverage for IndexTaskClient. I added a bunch of tests, and while doing so, noticed that the FullResponseHolder needlessly stored `status` separately from `response`. All call sites populated status with `response.getStatus()` anyway, whose main implementation is DefaultHttpResponse, which stores `status` in a field itself. So I changed the holder to use `response.getStatus()` itself and removed the `status` field.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org