You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/12/03 05:49:24 UTC

[GitHub] [cloudstack] rhtyd commented on a change in pull request #5745: conditional broadcastUri

rhtyd commented on a change in pull request #5745:
URL: https://github.com/apache/cloudstack/pull/5745#discussion_r761662941



##########
File path: ui/src/config/section/network.js
##########
@@ -29,7 +29,13 @@ export default {
       icon: 'apartment',
       permission: ['listNetworks'],
       resourceType: 'Network',
-      columns: ['name', 'state', 'type', 'vpcname', 'cidr', 'ip6cidr', 'broadcasturi', 'domain', 'account', 'zonename'],
+      columns: () => {
+        var fields = ['name', 'state', 'type', 'vpcname', 'cidr', 'ip6cidr', 'domain', 'account', 'zonename']
+        if (['Admin'].includes(store.getters.userInfo.roletype)) {
+          fields.push('broadcasturi')
+        }
+        return fields
+      },

Review comment:
       Should we keep the same order, by pushing other fields after the if block? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org