You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by Andrew Purtell <ap...@apache.org> on 2014/01/21 01:36:42 UTC
Are we no longer giving credit in SVN commit messages?
I see some committers are continuing the informal practice we've had of
attribution in parenthesis after the issue description if the work is not
your own, e.g.
HBASE-XXXX. JIRA title goes here (Contributor Name)
I've noticed that some committers are definitely not doing this.
I think it is bad practice not to provide attribution to the contributor in
the commit message. When one is reviewing commit history, neither links to
JIRA nor inlining of JIRA content is possible -- unless there is some tool
that does this of which I'm not aware (please let me know!).
--
Best regards,
- Andy
Problems worthy of attack prove their worth by hitting back. - Piet Hein
(via Tom White)
Re: Are we no longer giving credit in SVN commit messages?
Posted by Ted Yu <yu...@gmail.com>.
+1 to giving attribution at time of commit.
Cheers
On Mon, Jan 20, 2014 at 4:39 PM, Jesse Yates <je...@gmail.com>wrote:
> +1 To continue giving attribution (unless you wrote the code, in which
> case, whats the point, eh?)
>
> -------------------
> Jesse Yates
> @jesse_yates
> jyates.github.com
>
>
> On Mon, Jan 20, 2014 at 4:36 PM, Andrew Purtell <ap...@apache.org>
> wrote:
>
> > I see some committers are continuing the informal practice we've had of
> > attribution in parenthesis after the issue description if the work is not
> > your own, e.g.
> >
> > HBASE-XXXX. JIRA title goes here (Contributor Name)
> >
> > I've noticed that some committers are definitely not doing this.
> >
> > I think it is bad practice not to provide attribution to the contributor
> in
> > the commit message. When one is reviewing commit history, neither links
> to
> > JIRA nor inlining of JIRA content is possible -- unless there is some
> tool
> > that does this of which I'm not aware (please let me know!).
> >
> > --
> > Best regards,
> >
> > - Andy
> >
> > Problems worthy of attack prove their worth by hitting back. - Piet Hein
> > (via Tom White)
> >
>
Re: Are we no longer giving credit in SVN commit messages?
Posted by Andrew Purtell <ap...@apache.org>.
Thanks for that. I agree there's no point to attribute your own code to
yourself :-) but that committing someone else's work without attribution in
the commit log is in my view taking credit for their work. Just my opinion.
On Mon, Jan 20, 2014 at 4:39 PM, Jesse Yates <je...@gmail.com>wrote:
> +1 To continue giving attribution (unless you wrote the code, in which
> case, whats the point, eh?)
>
> -------------------
> Jesse Yates
> @jesse_yates
> jyates.github.com
>
>
> On Mon, Jan 20, 2014 at 4:36 PM, Andrew Purtell <ap...@apache.org>
> wrote:
>
> > I see some committers are continuing the informal practice we've had of
> > attribution in parenthesis after the issue description if the work is not
> > your own, e.g.
> >
> > HBASE-XXXX. JIRA title goes here (Contributor Name)
> >
> > I've noticed that some committers are definitely not doing this.
> >
> > I think it is bad practice not to provide attribution to the contributor
> in
> > the commit message. When one is reviewing commit history, neither links
> to
> > JIRA nor inlining of JIRA content is possible -- unless there is some
> tool
> > that does this of which I'm not aware (please let me know!).
> >
> > --
> > Best regards,
> >
> > - Andy
> >
> > Problems worthy of attack prove their worth by hitting back. - Piet Hein
> > (via Tom White)
> >
>
--
Best regards,
- Andy
Problems worthy of attack prove their worth by hitting back. - Piet Hein
(via Tom White)
Re: Are we no longer giving credit in SVN commit messages?
Posted by Jesse Yates <je...@gmail.com>.
+1 To continue giving attribution (unless you wrote the code, in which
case, whats the point, eh?)
-------------------
Jesse Yates
@jesse_yates
jyates.github.com
On Mon, Jan 20, 2014 at 4:36 PM, Andrew Purtell <ap...@apache.org> wrote:
> I see some committers are continuing the informal practice we've had of
> attribution in parenthesis after the issue description if the work is not
> your own, e.g.
>
> HBASE-XXXX. JIRA title goes here (Contributor Name)
>
> I've noticed that some committers are definitely not doing this.
>
> I think it is bad practice not to provide attribution to the contributor in
> the commit message. When one is reviewing commit history, neither links to
> JIRA nor inlining of JIRA content is possible -- unless there is some tool
> that does this of which I'm not aware (please let me know!).
>
> --
> Best regards,
>
> - Andy
>
> Problems worthy of attack prove their worth by hitting back. - Piet Hein
> (via Tom White)
>
Re: Are we no longer giving credit in SVN commit messages?
Posted by lars hofhansl <la...@apache.org>.
I always do that, unless I contributed the change myself, in which case I assume it is implied that the change is mine.
Did somebody not do that? That would be bad (IMHO)
-- Lars
----- Original Message -----
From: Andrew Purtell <ap...@apache.org>
To: "dev@hbase.apache.org" <de...@hbase.apache.org>
Cc:
Sent: Monday, January 20, 2014 4:36 PM
Subject: Are we no longer giving credit in SVN commit messages?
I see some committers are continuing the informal practice we've had of
attribution in parenthesis after the issue description if the work is not
your own, e.g.
HBASE-XXXX. JIRA title goes here (Contributor Name)
I've noticed that some committers are definitely not doing this.
I think it is bad practice not to provide attribution to the contributor in
the commit message. When one is reviewing commit history, neither links to
JIRA nor inlining of JIRA content is possible -- unless there is some tool
that does this of which I'm not aware (please let me know!).
--
Best regards,
- Andy
Problems worthy of attack prove their worth by hitting back. - Piet Hein
(via Tom White)
Re: Are we no longer giving credit in SVN commit messages?
Posted by Stack <st...@duboce.net>.
On Tue, Jan 21, 2014 at 12:00 PM, Aditya <ad...@gmail.com> wrote:
> This might be easier if and when we move to Git as the system of record in
> which case git am will take care of credit provided the patch is submitted
> in git format.
>
>
True.
No progress on git front that I know off. Let me kick that thread.
St.Ack
Re: Are we no longer giving credit in SVN commit messages?
Posted by Aditya <ad...@gmail.com>.
This might be easier if and when we move to Git as the system of record in
which case git am will take care of credit provided the patch is submitted
in git format.
On Mon, Jan 20, 2014 at 8:43 PM, Stack <st...@duboce.net> wrote:
> I have never added the contributor. Let me do it from here on out. Let me
> write up the above agreement into the refguide.
> St.Ack
>
>
> On Mon, Jan 20, 2014 at 7:51 PM, ramkrishna vasudevan <
> ramkrishna.s.vasudevan@gmail.com> wrote:
>
> > +1.
> > I used to follow the above said practice. But I add my own name also if
> > its my own patch. so any case same format. Good to follow that.
> >
> >
> > On Tue, Jan 21, 2014 at 7:28 AM, Andrew Purtell <ap...@apache.org>
> > wrote:
> >
> > > On Mon, Jan 20, 2014 at 5:38 PM, lars hofhansl <la...@apache.org>
> wrote:
> > >
> > > > What do people do about their own contributions?
> > >
> > >
> > > No additional attribution needed was the discussion.
> > >
> > >
> > >
> > > --
> > > Best regards,
> > >
> > > - Andy
> > >
> > > Problems worthy of attack prove their worth by hitting back. - Piet
> Hein
> > > (via Tom White)
> > >
> >
>
Re: Are we no longer giving credit in SVN commit messages?
Posted by Stack <st...@duboce.net>.
I have never added the contributor. Let me do it from here on out. Let me
write up the above agreement into the refguide.
St.Ack
On Mon, Jan 20, 2014 at 7:51 PM, ramkrishna vasudevan <
ramkrishna.s.vasudevan@gmail.com> wrote:
> +1.
> I used to follow the above said practice. But I add my own name also if
> its my own patch. so any case same format. Good to follow that.
>
>
> On Tue, Jan 21, 2014 at 7:28 AM, Andrew Purtell <ap...@apache.org>
> wrote:
>
> > On Mon, Jan 20, 2014 at 5:38 PM, lars hofhansl <la...@apache.org> wrote:
> >
> > > What do people do about their own contributions?
> >
> >
> > No additional attribution needed was the discussion.
> >
> >
> >
> > --
> > Best regards,
> >
> > - Andy
> >
> > Problems worthy of attack prove their worth by hitting back. - Piet Hein
> > (via Tom White)
> >
>
Re: Are we no longer giving credit in SVN commit messages?
Posted by ramkrishna vasudevan <ra...@gmail.com>.
+1.
I used to follow the above said practice. But I add my own name also if
its my own patch. so any case same format. Good to follow that.
On Tue, Jan 21, 2014 at 7:28 AM, Andrew Purtell <ap...@apache.org> wrote:
> On Mon, Jan 20, 2014 at 5:38 PM, lars hofhansl <la...@apache.org> wrote:
>
> > What do people do about their own contributions?
>
>
> No additional attribution needed was the discussion.
>
>
>
> --
> Best regards,
>
> - Andy
>
> Problems worthy of attack prove their worth by hitting back. - Piet Hein
> (via Tom White)
>
Re: Are we no longer giving credit in SVN commit messages?
Posted by Andrew Purtell <ap...@apache.org>.
On Mon, Jan 20, 2014 at 5:38 PM, lars hofhansl <la...@apache.org> wrote:
> What do people do about their own contributions?
No additional attribution needed was the discussion.
--
Best regards,
- Andy
Problems worthy of attack prove their worth by hitting back. - Piet Hein
(via Tom White)
Re: Are we no longer giving credit in SVN commit messages?
Posted by lars hofhansl <la...@apache.org>.
So just to confirm we're agreeing to follow the following format.
HBASE-xxxxx <title>. (<contributor>)
What do people do about their own contributions? I have not bothered with tagged my own patches with "(LarsH)".
-- Lars
----- Original Message -----
From: Jonathan Hsieh <jo...@cloudera.com>
To: "dev@hbase.apache.org" <de...@hbase.apache.org>
Cc:
Sent: Monday, January 20, 2014 4:46 PM
Subject: Re: Are we no longer giving credit in SVN commit messages?
+1 to andrews format
HBASE-xxxxx JIRA Title (contributor name)
One nit is most of our jiras are committed without the '.' after the jira
name. Not the end of the world if a '.' or ':' sneaks in.
Jon
On Mon, Jan 20, 2014 at 4:36 PM, Andrew Purtell <ap...@apache.org> wrote:
> I see some committers are continuing the informal practice we've had of
> attribution in parenthesis after the issue description if the work is not
> your own, e.g.
>
> HBASE-XXXX. JIRA title goes here (Contributor Name)
>
> I've noticed that some committers are definitely not doing this.
>
> I think it is bad practice not to provide attribution to the contributor in
> the commit message. When one is reviewing commit history, neither links to
> JIRA nor inlining of JIRA content is possible -- unless there is some tool
> that does this of which I'm not aware (please let me know!).
>
> --
> Best regards,
>
> - Andy
>
> Problems worthy of attack prove their worth by hitting back. - Piet Hein
> (via Tom White)
>
--
// Jonathan Hsieh (shay)
// Software Engineer, Cloudera
// jon@cloudera.com
Re: Are we no longer giving credit in SVN commit messages?
Posted by Andrew Purtell <ap...@apache.org>.
On Mon, Jan 20, 2014 at 5:05 PM, Jonathan Hsieh <jo...@cloudera.com> wrote:
> Of the last 1000 commits, only 71 had '.' and 41 had ':'. The other 888
> were "naked". Honestly, not a big deal (I usually sed these extra things
> out when I run scripts on the gitlog).
>
Sure, I'll remember that.
--
Best regards,
- Andy
Problems worthy of attack prove their worth by hitting back. - Piet Hein
(via Tom White)
Re: Are we no longer giving credit in SVN commit messages?
Posted by Jonathan Hsieh <jo...@cloudera.com>.
Of the last 1000 commits, only 71 had '.' and 41 had ':'. The other 888
were "naked". Honestly, not a big deal (I usually sed these extra things
out when I run scripts on the gitlog).
jon@swoop:~/proj/hbase$ git log --oneline apache/trunk | awk '{print $2}' |
grep HBASE | head -1000 | grep \\. | wc
71 71 938
jon@swoop:~/proj/hbase$ git log --oneline apache/trunk | awk '{print $2}' |
grep HBASE | head -1000 | grep \\: | wc
41 41 499
jon@swoop:~/proj/hbase$ git log --oneline apache/trunk | awk '{print $2}' |
grep HBASE | head -1000 | grep -v \\: | grep -v \\. | wc
888 888 10011
On Mon, Jan 20, 2014 at 4:47 PM, Andrew Purtell <ap...@apache.org> wrote:
> Oh, we don't want the "."? It's pretty universal in Hadoop land (just
> checked common, hdfs, mapreduce, yarn, and zookeeper).
>
>
> On Mon, Jan 20, 2014 at 4:46 PM, Jonathan Hsieh <jo...@cloudera.com> wrote:
>
> > +1 to andrews format
> >
> > HBASE-xxxxx JIRA Title (contributor name)
> >
> > One nit is most of our jiras are committed without the '.' after the jira
> > name. Not the end of the world if a '.' or ':' sneaks in.
> >
> > Jon
> >
> >
> > On Mon, Jan 20, 2014 at 4:36 PM, Andrew Purtell <ap...@apache.org>
> > wrote:
> >
> > > I see some committers are continuing the informal practice we've had of
> > > attribution in parenthesis after the issue description if the work is
> not
> > > your own, e.g.
> > >
> > > HBASE-XXXX. JIRA title goes here (Contributor Name)
> > >
> > > I've noticed that some committers are definitely not doing this.
> > >
> > > I think it is bad practice not to provide attribution to the
> contributor
> > in
> > > the commit message. When one is reviewing commit history, neither links
> > to
> > > JIRA nor inlining of JIRA content is possible -- unless there is some
> > tool
> > > that does this of which I'm not aware (please let me know!).
> > >
> > > --
> > > Best regards,
> > >
> > > - Andy
> > >
> > > Problems worthy of attack prove their worth by hitting back. - Piet
> Hein
> > > (via Tom White)
> > >
> >
> >
> >
> > --
> > // Jonathan Hsieh (shay)
> > // Software Engineer, Cloudera
> > // jon@cloudera.com
> >
>
>
>
> --
> Best regards,
>
> - Andy
>
> Problems worthy of attack prove their worth by hitting back. - Piet Hein
> (via Tom White)
>
--
// Jonathan Hsieh (shay)
// Software Engineer, Cloudera
// jon@cloudera.com
Re: Are we no longer giving credit in SVN commit messages?
Posted by Andrew Purtell <ap...@apache.org>.
Oh, we don't want the "."? It's pretty universal in Hadoop land (just
checked common, hdfs, mapreduce, yarn, and zookeeper).
On Mon, Jan 20, 2014 at 4:46 PM, Jonathan Hsieh <jo...@cloudera.com> wrote:
> +1 to andrews format
>
> HBASE-xxxxx JIRA Title (contributor name)
>
> One nit is most of our jiras are committed without the '.' after the jira
> name. Not the end of the world if a '.' or ':' sneaks in.
>
> Jon
>
>
> On Mon, Jan 20, 2014 at 4:36 PM, Andrew Purtell <ap...@apache.org>
> wrote:
>
> > I see some committers are continuing the informal practice we've had of
> > attribution in parenthesis after the issue description if the work is not
> > your own, e.g.
> >
> > HBASE-XXXX. JIRA title goes here (Contributor Name)
> >
> > I've noticed that some committers are definitely not doing this.
> >
> > I think it is bad practice not to provide attribution to the contributor
> in
> > the commit message. When one is reviewing commit history, neither links
> to
> > JIRA nor inlining of JIRA content is possible -- unless there is some
> tool
> > that does this of which I'm not aware (please let me know!).
> >
> > --
> > Best regards,
> >
> > - Andy
> >
> > Problems worthy of attack prove their worth by hitting back. - Piet Hein
> > (via Tom White)
> >
>
>
>
> --
> // Jonathan Hsieh (shay)
> // Software Engineer, Cloudera
> // jon@cloudera.com
>
--
Best regards,
- Andy
Problems worthy of attack prove their worth by hitting back. - Piet Hein
(via Tom White)
Re: Are we no longer giving credit in SVN commit messages?
Posted by Jonathan Hsieh <jo...@cloudera.com>.
+1 to andrews format
HBASE-xxxxx JIRA Title (contributor name)
One nit is most of our jiras are committed without the '.' after the jira
name. Not the end of the world if a '.' or ':' sneaks in.
Jon
On Mon, Jan 20, 2014 at 4:36 PM, Andrew Purtell <ap...@apache.org> wrote:
> I see some committers are continuing the informal practice we've had of
> attribution in parenthesis after the issue description if the work is not
> your own, e.g.
>
> HBASE-XXXX. JIRA title goes here (Contributor Name)
>
> I've noticed that some committers are definitely not doing this.
>
> I think it is bad practice not to provide attribution to the contributor in
> the commit message. When one is reviewing commit history, neither links to
> JIRA nor inlining of JIRA content is possible -- unless there is some tool
> that does this of which I'm not aware (please let me know!).
>
> --
> Best regards,
>
> - Andy
>
> Problems worthy of attack prove their worth by hitting back. - Piet Hein
> (via Tom White)
>
--
// Jonathan Hsieh (shay)
// Software Engineer, Cloudera
// jon@cloudera.com