You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Na Li via Review Board <no...@reviews.apache.org> on 2019/05/23 21:11:31 UTC
Review Request 70708: ATLAS-3185: Create process execution for Impala
integration
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70708/
-----------------------------------------------------------
Review request for atlas, Aadarsh Jajodia, Madhan Neethiraj, and Sarath Subramanian.
Repository: atlas
Description
-------
ATLAS-3133 adds a new feature to track metadata for different executions of the same process in Atlas. Need to add this in Impala integration
Diffs
-----
addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/AtlasImpalaHookContext.java 88faace
addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/ImpalaLineageHook.java 232a569
addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/BaseImpalaEvent.java 63c5f87
addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/CreateImpalaProcess.java 0dc520c
addons/impala-bridge/src/test/java/org/apache/atlas/impala/ImpalaLineageITBase.java 0138d88
addons/impala-bridge/src/test/java/org/apache/atlas/impala/ImpalaLineageToolIT.java 033a518
addons/impala-bridge/src/test/java/org/apache/atlas/impala/hook/ImpalaLineageHookIT.java 86801e3
Diff: https://reviews.apache.org/r/70708/diff/1/
Testing
-------
Integration tests
Thanks,
Na Li
Re: Review Request 70708: ATLAS-3185: Create process execution for
Impala integration
Posted by Na Li via Review Board <no...@reviews.apache.org>.
> On May 24, 2019, 8:14 p.m., Aadarsh Jajodia wrote:
> > addons/impala-bridge/src/test/java/org/apache/atlas/impala/ImpalaLineageToolIT.java
> > Lines 201-205 (patched)
> > <https://reviews.apache.org/r/70708/diff/1/?file=2146556#file2146556line201>
> >
> > Can we also add a unit test which produces more than one execution?
added new test with multiple process executions
- Na
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70708/#review215511
-----------------------------------------------------------
On May 28, 2019, 9:19 p.m., Na Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70708/
> -----------------------------------------------------------
>
> (Updated May 28, 2019, 9:19 p.m.)
>
>
> Review request for atlas, Aadarsh Jajodia, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-3133 adds a new feature to track metadata for different executions of the same process in Atlas. Need to add this in Impala integration
>
>
> Diffs
> -----
>
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/ImpalaLineageTool.java 7c9abc8
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/AtlasImpalaHookContext.java 88faace
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/ImpalaIdentifierParser.java b9d6cbb
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/ImpalaLineageHook.java 232a569
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/BaseImpalaEvent.java c7604ba
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/CreateImpalaProcess.java 3071576
> addons/impala-bridge/src/test/java/org/apache/atlas/impala/ImpalaLineageITBase.java 0138d88
> addons/impala-bridge/src/test/java/org/apache/atlas/impala/ImpalaLineageToolIT.java 033a518
> addons/impala-bridge/src/test/java/org/apache/atlas/impala/hook/ImpalaLineageHookIT.java 86801e3
> addons/impala-bridge/src/test/resources/impalaMultipleInsertIntoAsSelect1.json PRE-CREATION
> addons/impala-bridge/src/test/resources/impalaMultipleInsertIntoAsSelect2.json PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/70708/diff/2/
>
>
> Testing
> -------
>
> Integration tests
>
>
> Thanks,
>
> Na Li
>
>
Re: Review Request 70708: ATLAS-3185: Create process execution for
Impala integration
Posted by Na Li via Review Board <no...@reviews.apache.org>.
> On May 24, 2019, 8:14 p.m., Aadarsh Jajodia wrote:
> > addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/BaseImpalaEvent.java
> > Lines 561-562 (patched)
> > <https://reviews.apache.org/r/70708/diff/1/?file=2146553#file2146553line561>
> >
> > Maybe use long for both?
fixed
> On May 24, 2019, 8:14 p.m., Aadarsh Jajodia wrote:
> > addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/CreateImpalaProcess.java
> > Lines 120 (patched)
> > <https://reviews.apache.org/r/70708/diff/1/?file=2146554#file2146554line120>
> >
> > Change to processExecution != null
good catch!
- Na
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70708/#review215511
-----------------------------------------------------------
On May 23, 2019, 9:11 p.m., Na Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70708/
> -----------------------------------------------------------
>
> (Updated May 23, 2019, 9:11 p.m.)
>
>
> Review request for atlas, Aadarsh Jajodia, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-3133 adds a new feature to track metadata for different executions of the same process in Atlas. Need to add this in Impala integration
>
>
> Diffs
> -----
>
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/AtlasImpalaHookContext.java 88faace
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/ImpalaLineageHook.java 232a569
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/BaseImpalaEvent.java 63c5f87
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/CreateImpalaProcess.java 0dc520c
> addons/impala-bridge/src/test/java/org/apache/atlas/impala/ImpalaLineageITBase.java 0138d88
> addons/impala-bridge/src/test/java/org/apache/atlas/impala/ImpalaLineageToolIT.java 033a518
> addons/impala-bridge/src/test/java/org/apache/atlas/impala/hook/ImpalaLineageHookIT.java 86801e3
>
>
> Diff: https://reviews.apache.org/r/70708/diff/1/
>
>
> Testing
> -------
>
> Integration tests
>
>
> Thanks,
>
> Na Li
>
>
Re: Review Request 70708: ATLAS-3185: Create process execution for
Impala integration
Posted by Aadarsh Jajodia <aa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70708/#review215511
-----------------------------------------------------------
Fix it, then Ship it!
Overall looks good to me. Some minor comments.
addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/BaseImpalaEvent.java
Lines 561-562 (patched)
<https://reviews.apache.org/r/70708/#comment302243>
Maybe use long for both?
addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/CreateImpalaProcess.java
Lines 120 (patched)
<https://reviews.apache.org/r/70708/#comment302242>
Change to processExecution != null
addons/impala-bridge/src/test/java/org/apache/atlas/impala/ImpalaLineageToolIT.java
Lines 201-205 (patched)
<https://reviews.apache.org/r/70708/#comment302244>
Can we also add a unit test which produces more than one execution?
- Aadarsh Jajodia
On May 23, 2019, 9:11 p.m., Na Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70708/
> -----------------------------------------------------------
>
> (Updated May 23, 2019, 9:11 p.m.)
>
>
> Review request for atlas, Aadarsh Jajodia, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-3133 adds a new feature to track metadata for different executions of the same process in Atlas. Need to add this in Impala integration
>
>
> Diffs
> -----
>
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/AtlasImpalaHookContext.java 88faace
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/ImpalaLineageHook.java 232a569
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/BaseImpalaEvent.java 63c5f87
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/CreateImpalaProcess.java 0dc520c
> addons/impala-bridge/src/test/java/org/apache/atlas/impala/ImpalaLineageITBase.java 0138d88
> addons/impala-bridge/src/test/java/org/apache/atlas/impala/ImpalaLineageToolIT.java 033a518
> addons/impala-bridge/src/test/java/org/apache/atlas/impala/hook/ImpalaLineageHookIT.java 86801e3
>
>
> Diff: https://reviews.apache.org/r/70708/diff/1/
>
>
> Testing
> -------
>
> Integration tests
>
>
> Thanks,
>
> Na Li
>
>
Re: Review Request 70708: ATLAS-3185: Create process execution for
Impala integration
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70708/#review215585
-----------------------------------------------------------
Ship it!
Ship It!
- Sarath Subramanian
On May 29, 2019, 8:29 a.m., Na Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70708/
> -----------------------------------------------------------
>
> (Updated May 29, 2019, 8:29 a.m.)
>
>
> Review request for atlas, Aadarsh Jajodia, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-3133 adds a new feature to track metadata for different executions of the same process in Atlas. Need to add this in Impala integration
>
>
> Diffs
> -----
>
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/ImpalaLineageTool.java 7c9abc8
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/AtlasImpalaHookContext.java 88faace
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/ImpalaIdentifierParser.java b9d6cbb
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/ImpalaLineageHook.java 232a569
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/BaseImpalaEvent.java c7604ba
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/CreateImpalaProcess.java 3071576
> addons/impala-bridge/src/test/java/org/apache/atlas/impala/ImpalaLineageITBase.java 0138d88
> addons/impala-bridge/src/test/java/org/apache/atlas/impala/ImpalaLineageToolIT.java 033a518
> addons/impala-bridge/src/test/java/org/apache/atlas/impala/hook/ImpalaLineageHookIT.java 86801e3
> addons/impala-bridge/src/test/resources/impalaMultipleInsertIntoAsSelect1.json PRE-CREATION
> addons/impala-bridge/src/test/resources/impalaMultipleInsertIntoAsSelect2.json PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/70708/diff/3/
>
>
> Testing
> -------
>
> Integration tests
>
>
> Thanks,
>
> Na Li
>
>
Re: Review Request 70708: ATLAS-3185: Create process execution for
Impala integration
Posted by Na Li via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70708/
-----------------------------------------------------------
(Updated May 29, 2019, 3:29 p.m.)
Review request for atlas, Aadarsh Jajodia, Madhan Neethiraj, and Sarath Subramanian.
Repository: atlas
Description
-------
ATLAS-3133 adds a new feature to track metadata for different executions of the same process in Atlas. Need to add this in Impala integration
Diffs (updated)
-----
addons/impala-bridge/src/main/java/org/apache/atlas/impala/ImpalaLineageTool.java 7c9abc8
addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/AtlasImpalaHookContext.java 88faace
addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/ImpalaIdentifierParser.java b9d6cbb
addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/ImpalaLineageHook.java 232a569
addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/BaseImpalaEvent.java c7604ba
addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/CreateImpalaProcess.java 3071576
addons/impala-bridge/src/test/java/org/apache/atlas/impala/ImpalaLineageITBase.java 0138d88
addons/impala-bridge/src/test/java/org/apache/atlas/impala/ImpalaLineageToolIT.java 033a518
addons/impala-bridge/src/test/java/org/apache/atlas/impala/hook/ImpalaLineageHookIT.java 86801e3
addons/impala-bridge/src/test/resources/impalaMultipleInsertIntoAsSelect1.json PRE-CREATION
addons/impala-bridge/src/test/resources/impalaMultipleInsertIntoAsSelect2.json PRE-CREATION
Diff: https://reviews.apache.org/r/70708/diff/3/
Changes: https://reviews.apache.org/r/70708/diff/2-3/
Testing
-------
Integration tests
Thanks,
Na Li
Re: Review Request 70708: ATLAS-3185: Create process execution for
Impala integration
Posted by Na Li via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70708/
-----------------------------------------------------------
(Updated May 28, 2019, 9:19 p.m.)
Review request for atlas, Aadarsh Jajodia, Madhan Neethiraj, and Sarath Subramanian.
Repository: atlas
Description
-------
ATLAS-3133 adds a new feature to track metadata for different executions of the same process in Atlas. Need to add this in Impala integration
Diffs (updated)
-----
addons/impala-bridge/src/main/java/org/apache/atlas/impala/ImpalaLineageTool.java 7c9abc8
addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/AtlasImpalaHookContext.java 88faace
addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/ImpalaIdentifierParser.java b9d6cbb
addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/ImpalaLineageHook.java 232a569
addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/BaseImpalaEvent.java c7604ba
addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/CreateImpalaProcess.java 3071576
addons/impala-bridge/src/test/java/org/apache/atlas/impala/ImpalaLineageITBase.java 0138d88
addons/impala-bridge/src/test/java/org/apache/atlas/impala/ImpalaLineageToolIT.java 033a518
addons/impala-bridge/src/test/java/org/apache/atlas/impala/hook/ImpalaLineageHookIT.java 86801e3
addons/impala-bridge/src/test/resources/impalaMultipleInsertIntoAsSelect1.json PRE-CREATION
addons/impala-bridge/src/test/resources/impalaMultipleInsertIntoAsSelect2.json PRE-CREATION
Diff: https://reviews.apache.org/r/70708/diff/2/
Changes: https://reviews.apache.org/r/70708/diff/1-2/
Testing
-------
Integration tests
Thanks,
Na Li
Re: Review Request 70708: ATLAS-3185: Create process execution for
Impala integration
Posted by Na Li via Review Board <no...@reviews.apache.org>.
> On May 28, 2019, 5:58 p.m., Sarath Subramanian wrote:
> > addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/BaseImpalaEvent.java
> > Lines 23 (patched)
> > <https://reviews.apache.org/r/70708/diff/1/?file=2146553#file2146553line23>
> >
> > nit: unused imports, consider removing them.
done
> On May 28, 2019, 5:58 p.m., Sarath Subramanian wrote:
> > addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/BaseImpalaEvent.java
> > Lines 565 (patched)
> > <https://reviews.apache.org/r/70708/diff/1/?file=2146553#file2146553line565>
> >
> > cast startTime as string value; same for line #568
directly casting it to long does not work. I change the type to "Long", and call its.toString() instead
> On May 28, 2019, 5:58 p.m., Sarath Subramanian wrote:
> > addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/CreateImpalaProcess.java
> > Line 114 (original), 114 (patched)
> > <https://reviews.apache.org/r/70708/diff/1/?file=2146554#file2146554line114>
> >
> > surround with LOG.isDebugEnabled(); same for line #121
see comment at https://stackoverflow.com/questions/105852/conditional-logging-with-minimal-cyclomatic-complexity/105908#105908 and `https://stackoverflow.com/questions/963492/in-log4j-does-checking-isdebugenabled-before-logging-improve-performance`
`Better yet is to use a more up-to-date logging framework where the log statements take a format specification and a list of arguments to be substituted by the logger—but "lazily," only if the logger is enabled.`
that is what I did. The overhead only happens if debug logging is enabled. So I don't need to check `LOG.isDebugEnabled()`
- Na
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70708/#review215546
-----------------------------------------------------------
On May 23, 2019, 9:11 p.m., Na Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70708/
> -----------------------------------------------------------
>
> (Updated May 23, 2019, 9:11 p.m.)
>
>
> Review request for atlas, Aadarsh Jajodia, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-3133 adds a new feature to track metadata for different executions of the same process in Atlas. Need to add this in Impala integration
>
>
> Diffs
> -----
>
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/AtlasImpalaHookContext.java 88faace
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/ImpalaLineageHook.java 232a569
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/BaseImpalaEvent.java 63c5f87
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/CreateImpalaProcess.java 0dc520c
> addons/impala-bridge/src/test/java/org/apache/atlas/impala/ImpalaLineageITBase.java 0138d88
> addons/impala-bridge/src/test/java/org/apache/atlas/impala/ImpalaLineageToolIT.java 033a518
> addons/impala-bridge/src/test/java/org/apache/atlas/impala/hook/ImpalaLineageHookIT.java 86801e3
>
>
> Diff: https://reviews.apache.org/r/70708/diff/1/
>
>
> Testing
> -------
>
> Integration tests
>
>
> Thanks,
>
> Na Li
>
>
Re: Review Request 70708: ATLAS-3185: Create process execution for
Impala integration
Posted by Sarath Subramanian <sa...@apache.org>.
> On May 28, 2019, 10:58 a.m., Sarath Subramanian wrote:
> > addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/CreateImpalaProcess.java
> > Line 114 (original), 114 (patched)
> > <https://reviews.apache.org/r/70708/diff/1/?file=2146554#file2146554line114>
> >
> > surround with LOG.isDebugEnabled(); same for line #121
>
> Na Li wrote:
> see comment at https://stackoverflow.com/questions/105852/conditional-logging-with-minimal-cyclomatic-complexity/105908#105908 and `https://stackoverflow.com/questions/963492/in-log4j-does-checking-isdebugenabled-before-logging-improve-performance`
>
> `Better yet is to use a more up-to-date logging framework where the log statements take a format specification and a list of arguments to be substituted by the logger—but "lazily," only if the logger is enabled.`
> that is what I did. The overhead only happens if debug logging is enabled. So I don't need to check `LOG.isDebugEnabled()`
this is to keep it consistent with other Log.debug statements.
- Sarath
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70708/#review215546
-----------------------------------------------------------
On May 28, 2019, 2:19 p.m., Na Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70708/
> -----------------------------------------------------------
>
> (Updated May 28, 2019, 2:19 p.m.)
>
>
> Review request for atlas, Aadarsh Jajodia, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-3133 adds a new feature to track metadata for different executions of the same process in Atlas. Need to add this in Impala integration
>
>
> Diffs
> -----
>
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/ImpalaLineageTool.java 7c9abc8
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/AtlasImpalaHookContext.java 88faace
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/ImpalaIdentifierParser.java b9d6cbb
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/ImpalaLineageHook.java 232a569
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/BaseImpalaEvent.java c7604ba
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/CreateImpalaProcess.java 3071576
> addons/impala-bridge/src/test/java/org/apache/atlas/impala/ImpalaLineageITBase.java 0138d88
> addons/impala-bridge/src/test/java/org/apache/atlas/impala/ImpalaLineageToolIT.java 033a518
> addons/impala-bridge/src/test/java/org/apache/atlas/impala/hook/ImpalaLineageHookIT.java 86801e3
> addons/impala-bridge/src/test/resources/impalaMultipleInsertIntoAsSelect1.json PRE-CREATION
> addons/impala-bridge/src/test/resources/impalaMultipleInsertIntoAsSelect2.json PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/70708/diff/2/
>
>
> Testing
> -------
>
> Integration tests
>
>
> Thanks,
>
> Na Li
>
>
Re: Review Request 70708: ATLAS-3185: Create process execution for
Impala integration
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70708/#review215546
-----------------------------------------------------------
Fix it, then Ship it!
addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/BaseImpalaEvent.java
Lines 23 (patched)
<https://reviews.apache.org/r/70708/#comment302274>
nit: unused imports, consider removing them.
addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/BaseImpalaEvent.java
Lines 565 (patched)
<https://reviews.apache.org/r/70708/#comment302276>
cast startTime as string value; same for line #568
addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/CreateImpalaProcess.java
Line 114 (original), 114 (patched)
<https://reviews.apache.org/r/70708/#comment302278>
surround with LOG.isDebugEnabled(); same for line #121
- Sarath Subramanian
On May 23, 2019, 2:11 p.m., Na Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70708/
> -----------------------------------------------------------
>
> (Updated May 23, 2019, 2:11 p.m.)
>
>
> Review request for atlas, Aadarsh Jajodia, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-3133 adds a new feature to track metadata for different executions of the same process in Atlas. Need to add this in Impala integration
>
>
> Diffs
> -----
>
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/AtlasImpalaHookContext.java 88faace
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/ImpalaLineageHook.java 232a569
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/BaseImpalaEvent.java 63c5f87
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/CreateImpalaProcess.java 0dc520c
> addons/impala-bridge/src/test/java/org/apache/atlas/impala/ImpalaLineageITBase.java 0138d88
> addons/impala-bridge/src/test/java/org/apache/atlas/impala/ImpalaLineageToolIT.java 033a518
> addons/impala-bridge/src/test/java/org/apache/atlas/impala/hook/ImpalaLineageHookIT.java 86801e3
>
>
> Diff: https://reviews.apache.org/r/70708/diff/1/
>
>
> Testing
> -------
>
> Integration tests
>
>
> Thanks,
>
> Na Li
>
>