You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "vaibhawvipul (via GitHub)" <gi...@apache.org> on 2026/03/27 14:06:51 UTC
[PR] fix: native_datafusion: case-insensitive mode doesn't detect duplicate/ambiguous Parquet fields [datafusion-comet]
vaibhawvipul opened a new pull request, #3808:
URL: https://github.com/apache/datafusion-comet/pull/3808
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #3760 .
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
When running Spark SQL tests with native_datafusion scan, tests expecting errors for duplicate/ambiguous fields in case-insensitive mode fail because DataFusion's Parquet reader doesn't enforce Spark's case-sensitivity validation. Instead of detecting duplicates and raising the proper Spark error, the native reader silently returns wrong results or falls back to Spark.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
Native duplicate field detection (Rust):
- Added per-column duplicate detection in schema_adapter.rs via check_column_duplicate() - checks each Column expression in the physical plan for ambiguous case-insensitive matches against the original physical schema
Removed plan-time fallback (Scala):
- Removed the fallback block in CometScanRule.scala that detected duplicate field names at plan time and fell back to Spark - duplicates are now detected at read time in the native reader
Spark SQL test diffs (3.4.3, 3.5.8, 4.0.1):
- Removed IgnoreCometNativeDataFusion annotations for issue-3760 from FileBasedDataSourceSuite and ParquetFilterSuite
- Adapted error interception in tests to handle both Spark's SparkException(FAILED_READ_FILE) wrapper and Comet's direct SparkRuntimeException
## How are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
- Rust and Scala tests
- Spark SQL tests verified:
- Spark native readers should respect spark.sql.caseSensitive - parquet
- SPARK-25207: exception when duplicate fields in case-insensitive mode
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: native_datafusion: case-insensitive mode doesn't detect duplicate/ambiguous Parquet fields [datafusion-comet]
Posted by "vaibhawvipul (via GitHub)" <gi...@apache.org>.
vaibhawvipul commented on PR #3808:
URL: https://github.com/apache/datafusion-comet/pull/3808#issuecomment-4143861281
A lot of the CI failures are the following -
```
/usr/bin/docker pull amd64/rust
Using default tag: latest
Error response from daemon: Head "https://registry-1.docker.io/v2/amd64/rust/manifests/latest": toomanyrequests: too many failed login attempts for username or IP address
Warning: Docker pull failed with exit code 1, back off 1.615 seconds before retry.
/usr/bin/docker pull amd64/rust
Using default tag: latest
Error response from daemon: Head "https://registry-1.docker.io/v2/amd64/rust/manifests/latest": toomanyrequests: too many failed login attempts for username or IP address
Warning: Docker pull failed with exit code 1, back off 8.993 seconds before retry.
/usr/bin/docker pull amd64/rust
Using default tag: latest
Error response from daemon: Head "https://registry-1.docker.io/v2/amd64/rust/manifests/latest": toomanyrequests: too many failed login attempts for username or IP address
Error: Docker pull failed with exit code 1
```
any ideas how to fix them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: native_datafusion: case-insensitive mode doesn't detect duplicate/ambiguous Parquet fields [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on PR #3808:
URL: https://github.com/apache/datafusion-comet/pull/3808#issuecomment-4156001411
Sorry @vaibhawvipul, could you fix the conflict
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: native_datafusion: case-insensitive mode doesn't detect duplicate/ambiguous Parquet fields [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove merged PR #3808:
URL: https://github.com/apache/datafusion-comet/pull/3808
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: native_datafusion: case-insensitive mode doesn't detect duplicate/ambiguous Parquet fields [datafusion-comet]
Posted by "vaibhawvipul (via GitHub)" <gi...@apache.org>.
vaibhawvipul commented on PR #3808:
URL: https://github.com/apache/datafusion-comet/pull/3808#issuecomment-4146329089
only clippy issue in CI, fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: native_datafusion: case-insensitive mode doesn't detect duplicate/ambiguous Parquet fields [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on PR #3808:
URL: https://github.com/apache/datafusion-comet/pull/3808#issuecomment-4156126217
LGTM. Will review again once conflict is fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: native_datafusion: case-insensitive mode doesn't detect duplicate/ambiguous Parquet fields [datafusion-comet]
Posted by "vaibhawvipul (via GitHub)" <gi...@apache.org>.
vaibhawvipul commented on PR #3808:
URL: https://github.com/apache/datafusion-comet/pull/3808#issuecomment-4157235170
@andygrove thank you. I have fixed the merge conflict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org