You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Ashish Thusoo (JIRA)" <ji...@apache.org> on 2008/09/05 20:12:44 UTC
[jira] Created: (HADOOP-4090) The configuration file lists two
paths to hadoop directories (bin and conf). Startup should check that
these are valid directories and give appropriate messages.
The configuration file lists two paths to hadoop directories (bin and conf). Startup should check that these are valid directories and give appropriate messages.
------------------------------------------------------------------------------------------------------------------------------------------------------------------
Key: HADOOP-4090
URL: https://issues.apache.org/jira/browse/HADOOP-4090
Project: Hadoop Core
Issue Type: Improvement
Components: contrib/hive
Reporter: Ashish Thusoo
Priority: Minor
The configuration file lists two paths to hadoop directories (bin and conf). Startup should check that these are valid directories and give appropriate messages.
Reported by Chad.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4090) The configuration file lists two
paths to hadoop directories (bin and conf). Startup should check that
these are valid directories and give appropriate messages.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628842#action_12628842 ]
Hadoop QA commented on HADOOP-4090:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12389606/hadoop-4090.patch
against trunk revision 692597.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3194/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3194/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3194/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3194/console
This message is automatically generated.
> The configuration file lists two paths to hadoop directories (bin and conf). Startup should check that these are valid directories and give appropriate messages.
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4090
> URL: https://issues.apache.org/jira/browse/HADOOP-4090
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/hive
> Affects Versions: 0.19.0
> Reporter: Ashish Thusoo
> Priority: Minor
> Attachments: hadoop-4090.patch
>
>
> The configuration file lists two paths to hadoop directories (bin and conf). Startup should check that these are valid directories and give appropriate messages.
> Reported by Chad.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4090) The configuration file lists two
paths to hadoop directories (bin and conf). Startup should check that
these are valid directories and give appropriate messages.
Posted by "Raghotham Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628702#action_12628702 ]
Raghotham Murthy commented on HADOOP-4090:
------------------------------------------
Right now, the CLI (shell script) looks for
1. hadoop in path
2. env variable HADOOP
Then, the clidriver looks at two hadoop paths in the xml
All of this can be replaced by just HADOOP_HOME env variable which is already used by hadoop.
Another approach is what PIG does. It requires specification of HADOOPSITEPATH (directory containing hadoop-site.xml). hadoop bin is picked up from $HADOOPSITEPATH/../bin/hadoop. This will allow users to have multiple hadoop sites with the same bin directory.
> The configuration file lists two paths to hadoop directories (bin and conf). Startup should check that these are valid directories and give appropriate messages.
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4090
> URL: https://issues.apache.org/jira/browse/HADOOP-4090
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/hive
> Reporter: Ashish Thusoo
> Priority: Minor
>
> The configuration file lists two paths to hadoop directories (bin and conf). Startup should check that these are valid directories and give appropriate messages.
> Reported by Chad.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4090) The configuration file lists two
paths to hadoop directories (bin and conf). Startup should check that
these are valid directories and give appropriate messages.
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-4090:
-------------------------------------
Resolution: Fixed
Fix Version/s: 0.19.0
Status: Resolved (was: Patch Available)
I just committed this. Thanks Raghu!
> The configuration file lists two paths to hadoop directories (bin and conf). Startup should check that these are valid directories and give appropriate messages.
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4090
> URL: https://issues.apache.org/jira/browse/HADOOP-4090
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/hive
> Affects Versions: 0.19.0
> Reporter: Ashish Thusoo
> Assignee: Raghotham Murthy
> Priority: Minor
> Fix For: 0.19.0
>
> Attachments: hadoop-4090.2.patch, hadoop-4090.3.patch, hadoop-4090.patch
>
>
> The configuration file lists two paths to hadoop directories (bin and conf). Startup should check that these are valid directories and give appropriate messages.
> Reported by Chad.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-4090) The configuration file lists two
paths to hadoop directories (bin and conf). Startup should check that
these are valid directories and give appropriate messages.
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur reassigned HADOOP-4090:
----------------------------------------
Assignee: Raghotham Murthy
> The configuration file lists two paths to hadoop directories (bin and conf). Startup should check that these are valid directories and give appropriate messages.
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4090
> URL: https://issues.apache.org/jira/browse/HADOOP-4090
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/hive
> Affects Versions: 0.19.0
> Reporter: Ashish Thusoo
> Assignee: Raghotham Murthy
> Priority: Minor
> Attachments: hadoop-4090.2.patch, hadoop-4090.patch
>
>
> The configuration file lists two paths to hadoop directories (bin and conf). Startup should check that these are valid directories and give appropriate messages.
> Reported by Chad.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4090) The configuration file lists two
paths to hadoop directories (bin and conf). Startup should check that
these are valid directories and give appropriate messages.
Posted by "Raghotham Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raghotham Murthy updated HADOOP-4090:
-------------------------------------
Attachment: hadoop-4090.patch
> The configuration file lists two paths to hadoop directories (bin and conf). Startup should check that these are valid directories and give appropriate messages.
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4090
> URL: https://issues.apache.org/jira/browse/HADOOP-4090
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/hive
> Affects Versions: 0.19.0
> Reporter: Ashish Thusoo
> Priority: Minor
> Attachments: hadoop-4090.patch
>
>
> The configuration file lists two paths to hadoop directories (bin and conf). Startup should check that these are valid directories and give appropriate messages.
> Reported by Chad.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4090) The configuration file lists two
paths to hadoop directories (bin and conf). Startup should check that
these are valid directories and give appropriate messages.
Posted by "Pete Wyckoff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629092#action_12629092 ]
Pete Wyckoff commented on HADOOP-4090:
--------------------------------------
we can also calculate the location of the hadoop shell script from the location of the hive script itself. that is generally what hadoop itself does by finding things relative to itself.
And definitely agree with Joy. Currently hadoop does work with being on a user's path. but doug does have a point of what to do in case both are set - although to date not using hadoop_home
> The configuration file lists two paths to hadoop directories (bin and conf). Startup should check that these are valid directories and give appropriate messages.
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4090
> URL: https://issues.apache.org/jira/browse/HADOOP-4090
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/hive
> Affects Versions: 0.19.0
> Reporter: Ashish Thusoo
> Priority: Minor
> Attachments: hadoop-4090.patch
>
>
> The configuration file lists two paths to hadoop directories (bin and conf). Startup should check that these are valid directories and give appropriate messages.
> Reported by Chad.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4090) The configuration file lists two
paths to hadoop directories (bin and conf). Startup should check that
these are valid directories and give appropriate messages.
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629544#action_12629544 ]
dhruba borthakur commented on HADOOP-4090:
------------------------------------------
Hi Steve, does the latest patch address your concerns?
> The configuration file lists two paths to hadoop directories (bin and conf). Startup should check that these are valid directories and give appropriate messages.
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4090
> URL: https://issues.apache.org/jira/browse/HADOOP-4090
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/hive
> Affects Versions: 0.19.0
> Reporter: Ashish Thusoo
> Assignee: Raghotham Murthy
> Priority: Minor
> Attachments: hadoop-4090.2.patch, hadoop-4090.patch
>
>
> The configuration file lists two paths to hadoop directories (bin and conf). Startup should check that these are valid directories and give appropriate messages.
> Reported by Chad.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4090) The configuration file lists two
paths to hadoop directories (bin and conf). Startup should check that
these are valid directories and give appropriate messages.
Posted by "Pete Wyckoff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628841#action_12628841 ]
Pete Wyckoff commented on HADOOP-4090:
--------------------------------------
bq. All of this can be replaced by just HADOOP_HOME env variable which is already used by hadoop.
+1
-1 to using HADOOPSITEPATH. Hadoop itself uses HADOOP_CONF_DIR.
> The configuration file lists two paths to hadoop directories (bin and conf). Startup should check that these are valid directories and give appropriate messages.
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4090
> URL: https://issues.apache.org/jira/browse/HADOOP-4090
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/hive
> Affects Versions: 0.19.0
> Reporter: Ashish Thusoo
> Priority: Minor
> Attachments: hadoop-4090.patch
>
>
> The configuration file lists two paths to hadoop directories (bin and conf). Startup should check that these are valid directories and give appropriate messages.
> Reported by Chad.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4090) The configuration file lists two
paths to hadoop directories (bin and conf). Startup should check that
these are valid directories and give appropriate messages.
Posted by "Raghotham Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raghotham Murthy updated HADOOP-4090:
-------------------------------------
Affects Version/s: 0.19.0
Status: Patch Available (was: Open)
> The configuration file lists two paths to hadoop directories (bin and conf). Startup should check that these are valid directories and give appropriate messages.
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4090
> URL: https://issues.apache.org/jira/browse/HADOOP-4090
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/hive
> Affects Versions: 0.19.0
> Reporter: Ashish Thusoo
> Priority: Minor
>
> The configuration file lists two paths to hadoop directories (bin and conf). Startup should check that these are valid directories and give appropriate messages.
> Reported by Chad.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4090) The configuration file lists two
paths to hadoop directories (bin and conf). Startup should check that
these are valid directories and give appropriate messages.
Posted by "Joydeep Sen Sarma (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629313#action_12629313 ]
Joydeep Sen Sarma commented on HADOOP-4090:
-------------------------------------------
the latest patch uses HADOOP_HOME and then path (so similar to Ant). looks like the question is whether the normal relative path of bin/hadoop is used as a final default (with some validation as suggested). that makes sense to me - especially for people who are checking out the hadoop tree.
> The configuration file lists two paths to hadoop directories (bin and conf). Startup should check that these are valid directories and give appropriate messages.
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4090
> URL: https://issues.apache.org/jira/browse/HADOOP-4090
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/hive
> Affects Versions: 0.19.0
> Reporter: Ashish Thusoo
> Priority: Minor
> Attachments: hadoop-4090.2.patch, hadoop-4090.patch
>
>
> The configuration file lists two paths to hadoop directories (bin and conf). Startup should check that these are valid directories and give appropriate messages.
> Reported by Chad.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4090) The configuration file lists two
paths to hadoop directories (bin and conf). Startup should check that
these are valid directories and give appropriate messages.
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-4090:
-------------------------------------
Status: Open (was: Patch Available)
> The configuration file lists two paths to hadoop directories (bin and conf). Startup should check that these are valid directories and give appropriate messages.
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4090
> URL: https://issues.apache.org/jira/browse/HADOOP-4090
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/hive
> Affects Versions: 0.19.0
> Reporter: Ashish Thusoo
> Assignee: Raghotham Murthy
> Priority: Minor
> Attachments: hadoop-4090.2.patch, hadoop-4090.patch
>
>
> The configuration file lists two paths to hadoop directories (bin and conf). Startup should check that these are valid directories and give appropriate messages.
> Reported by Chad.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4090) The configuration file lists two
paths to hadoop directories (bin and conf). Startup should check that
these are valid directories and give appropriate messages.
Posted by "Raghotham Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raghotham Murthy updated HADOOP-4090:
-------------------------------------
Attachment: hadoop-4090.3.patch
fixed patch path
> The configuration file lists two paths to hadoop directories (bin and conf). Startup should check that these are valid directories and give appropriate messages.
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4090
> URL: https://issues.apache.org/jira/browse/HADOOP-4090
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/hive
> Affects Versions: 0.19.0
> Reporter: Ashish Thusoo
> Assignee: Raghotham Murthy
> Priority: Minor
> Attachments: hadoop-4090.2.patch, hadoop-4090.3.patch, hadoop-4090.patch
>
>
> The configuration file lists two paths to hadoop directories (bin and conf). Startup should check that these are valid directories and give appropriate messages.
> Reported by Chad.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4090) The configuration file lists two
paths to hadoop directories (bin and conf). Startup should check that
these are valid directories and give appropriate messages.
Posted by "Joydeep Sen Sarma (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629227#action_12629227 ]
Joydeep Sen Sarma commented on HADOOP-4090:
-------------------------------------------
+1 Code reviewed.
> The configuration file lists two paths to hadoop directories (bin and conf). Startup should check that these are valid directories and give appropriate messages.
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4090
> URL: https://issues.apache.org/jira/browse/HADOOP-4090
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/hive
> Affects Versions: 0.19.0
> Reporter: Ashish Thusoo
> Priority: Minor
> Attachments: hadoop-4090.2.patch, hadoop-4090.patch
>
>
> The configuration file lists two paths to hadoop directories (bin and conf). Startup should check that these are valid directories and give appropriate messages.
> Reported by Chad.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4090) The configuration file lists two
paths to hadoop directories (bin and conf). Startup should check that
these are valid directories and give appropriate messages.
Posted by "Raghotham Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632884#action_12632884 ]
Raghotham Murthy commented on HADOOP-4090:
------------------------------------------
Here are the results from HadoopQA:
[exec] -1 overall.
[exec] +1 @author. The patch does not contain any @author tags.
[exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
[exec] Please justify why no tests are needed for this patch.
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
> The configuration file lists two paths to hadoop directories (bin and conf). Startup should check that these are valid directories and give appropriate messages.
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4090
> URL: https://issues.apache.org/jira/browse/HADOOP-4090
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/hive
> Affects Versions: 0.19.0
> Reporter: Ashish Thusoo
> Assignee: Raghotham Murthy
> Priority: Minor
> Attachments: hadoop-4090.2.patch, hadoop-4090.3.patch, hadoop-4090.patch
>
>
> The configuration file lists two paths to hadoop directories (bin and conf). Startup should check that these are valid directories and give appropriate messages.
> Reported by Chad.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (HADOOP-4090) The configuration file
lists two paths to hadoop directories (bin and conf). Startup should check
that these are valid directories and give appropriate messages.
Posted by "Joydeep Sen Sarma (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629075#action_12629075 ]
jsensarma edited comment on HADOOP-4090 at 9/7/08 10:59 PM:
--------------------------------------------------------------------
here's the background: lot of regular hadoop users have a 'hadoop' in their path. they have already setup their environment for hadoop. hive is a utility on top of hadoop. as such using the 'hadoop' found in the user's path is meant to help the user. otherwise they have to setup another env variable. that's a negative for user experience.
secondly - HADOOP_HOME is not user defined today. From hadoop-config.sh:
# the root of the Hadoop installation
export HADOOP_HOME=`dirname "$this"`/..
so user's are not setting this today (just in case there is a misconception)
I would agree with renaming 'HADOOP' in hive shell scripts with 'HADOOP_HOME' - that would certainly seem more consistent. i feel that we should default to hadoop found in path - since that is the common case. we should not force users to set more things than are necessary to make hadoop run. would also agree to have HADOOP_HOME override hadoop in path (for advanced users).
was (Author: jsensarma):
hmmm - i don't quite agree with the thesis here.
here's the background: lot of regular hadoop users have a 'hadoop' in their path. they have already setup their environment for hadoop. hive is a utility on top of hadoop. as such using the 'hadoop' found in the user's path is meant to help the user. otherwise they have to setup another env variable. that's a negative for user experience. so how's this a bug?
secondly - HADOOP_HOME is not user defined today. From hadoop-config.sh:
# the root of the Hadoop installation
export HADOOP_HOME=`dirname "$this"`/..
so user's are not setting this today (just in case there is a misconception)
I would agree with renaming 'HADOOP' in hive shell scripts with 'HADOOP_HOME' - that would certainly seem more consistent. would not agree with giving it precedence over path setting since no one sets this env variable today and everyone sets hadoop into their path.
> The configuration file lists two paths to hadoop directories (bin and conf). Startup should check that these are valid directories and give appropriate messages.
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4090
> URL: https://issues.apache.org/jira/browse/HADOOP-4090
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/hive
> Affects Versions: 0.19.0
> Reporter: Ashish Thusoo
> Priority: Minor
> Attachments: hadoop-4090.patch
>
>
> The configuration file lists two paths to hadoop directories (bin and conf). Startup should check that these are valid directories and give appropriate messages.
> Reported by Chad.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4090) The configuration file lists two
paths to hadoop directories (bin and conf). Startup should check that
these are valid directories and give appropriate messages.
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628726#action_12628726 ]
Doug Cutting commented on HADOOP-4090:
--------------------------------------
> All of this can be replaced by just HADOOP_HOME env variable which is already used by hadoop.
+1 We should converge on a single mechanism, using the same environment variable. HADOOP_HOME should trump what's on PATH, just as JAVA_HOME trumps any java executables on PATH.
> The configuration file lists two paths to hadoop directories (bin and conf). Startup should check that these are valid directories and give appropriate messages.
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4090
> URL: https://issues.apache.org/jira/browse/HADOOP-4090
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/hive
> Reporter: Ashish Thusoo
> Priority: Minor
>
> The configuration file lists two paths to hadoop directories (bin and conf). Startup should check that these are valid directories and give appropriate messages.
> Reported by Chad.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4090) The configuration file lists two
paths to hadoop directories (bin and conf). Startup should check that
these are valid directories and give appropriate messages.
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629232#action_12629232 ]
Doug Cutting commented on HADOOP-4090:
--------------------------------------
We can look to Ant and Tomcat and their use of JAVA_HOME as examples. Tomcat requires JAVA_HOME to be set, while Ant gives JAVA_HOME priority, but, when it is unset uses a relative path from 'java' on $PATH.
If we choose to default HADOOP_HOME to the parent directory of the location of the 'hadoop' executable, we might do some validation. For example, we might, before automatically setting HADOOP_HOME this way, require that conf/hadoop-default.xml exists. If it does not, we should complain that HADOOP_HOME needs setting. Steve, would such validation address your concerns?
> The configuration file lists two paths to hadoop directories (bin and conf). Startup should check that these are valid directories and give appropriate messages.
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4090
> URL: https://issues.apache.org/jira/browse/HADOOP-4090
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/hive
> Affects Versions: 0.19.0
> Reporter: Ashish Thusoo
> Priority: Minor
> Attachments: hadoop-4090.2.patch, hadoop-4090.patch
>
>
> The configuration file lists two paths to hadoop directories (bin and conf). Startup should check that these are valid directories and give appropriate messages.
> Reported by Chad.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4090) The configuration file lists two
paths to hadoop directories (bin and conf). Startup should check that
these are valid directories and give appropriate messages.
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-4090:
-------------------------------------
Status: Patch Available (was: Open)
Run HadoopQA tests.
> The configuration file lists two paths to hadoop directories (bin and conf). Startup should check that these are valid directories and give appropriate messages.
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4090
> URL: https://issues.apache.org/jira/browse/HADOOP-4090
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/hive
> Affects Versions: 0.19.0
> Reporter: Ashish Thusoo
> Assignee: Raghotham Murthy
> Priority: Minor
> Attachments: hadoop-4090.2.patch, hadoop-4090.patch
>
>
> The configuration file lists two paths to hadoop directories (bin and conf). Startup should check that these are valid directories and give appropriate messages.
> Reported by Chad.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4090) The configuration file lists two
paths to hadoop directories (bin and conf). Startup should check that
these are valid directories and give appropriate messages.
Posted by "Raghotham Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raghotham Murthy updated HADOOP-4090:
-------------------------------------
Attachment: hadoop-4090.2.patch
The new patch picks up hadoop from the path. If HADOOP_HOME is specified then, it overrides hadoop in the path.
> The configuration file lists two paths to hadoop directories (bin and conf). Startup should check that these are valid directories and give appropriate messages.
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4090
> URL: https://issues.apache.org/jira/browse/HADOOP-4090
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/hive
> Affects Versions: 0.19.0
> Reporter: Ashish Thusoo
> Priority: Minor
> Attachments: hadoop-4090.2.patch, hadoop-4090.patch
>
>
> The configuration file lists two paths to hadoop directories (bin and conf). Startup should check that these are valid directories and give appropriate messages.
> Reported by Chad.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4090) The configuration file lists two
paths to hadoop directories (bin and conf). Startup should check that
these are valid directories and give appropriate messages.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12633298#action_12633298 ]
Hudson commented on HADOOP-4090:
--------------------------------
Integrated in Hadoop-trunk #611 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/611/])
> The configuration file lists two paths to hadoop directories (bin and conf). Startup should check that these are valid directories and give appropriate messages.
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4090
> URL: https://issues.apache.org/jira/browse/HADOOP-4090
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/hive
> Affects Versions: 0.19.0
> Reporter: Ashish Thusoo
> Assignee: Raghotham Murthy
> Priority: Minor
> Fix For: 0.19.0
>
> Attachments: hadoop-4090.2.patch, hadoop-4090.3.patch, hadoop-4090.patch
>
>
> The configuration file lists two paths to hadoop directories (bin and conf). Startup should check that these are valid directories and give appropriate messages.
> Reported by Chad.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4090) The configuration file lists two
paths to hadoop directories (bin and conf). Startup should check that
these are valid directories and give appropriate messages.
Posted by "Joydeep Sen Sarma (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629075#action_12629075 ]
Joydeep Sen Sarma commented on HADOOP-4090:
-------------------------------------------
hmmm - i don't quite agree with the thesis here.
here's the background: lot of regular hadoop users have a 'hadoop' in their path. they have already setup their environment for hadoop. hive is a utility on top of hadoop. as such using the 'hadoop' found in the user's path is meant to help the user. otherwise they have to setup another env variable. that's a negative for user experience. so how's this a bug?
secondly - HADOOP_HOME is not user defined today. From hadoop-config.sh:
# the root of the Hadoop installation
export HADOOP_HOME=`dirname "$this"`/..
so user's are not setting this today (just in case there is a misconception)
I would agree with renaming 'HADOOP' in hive shell scripts with 'HADOOP_HOME' - that would certainly seem more consistent. would not agree with giving it precedence over path setting since no one sets this env variable today and everyone sets hadoop into their path.
> The configuration file lists two paths to hadoop directories (bin and conf). Startup should check that these are valid directories and give appropriate messages.
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4090
> URL: https://issues.apache.org/jira/browse/HADOOP-4090
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/hive
> Affects Versions: 0.19.0
> Reporter: Ashish Thusoo
> Priority: Minor
> Attachments: hadoop-4090.patch
>
>
> The configuration file lists two paths to hadoop directories (bin and conf). Startup should check that these are valid directories and give appropriate messages.
> Reported by Chad.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4090) The configuration file lists two
paths to hadoop directories (bin and conf). Startup should check that
these are valid directories and give appropriate messages.
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629135#action_12629135 ]
Steve Loughran commented on HADOOP-4090:
----------------------------------------
> we can also calculate the location of the hadoop shell script from the location of the hive script itself. that is generally what hadoop itself does by finding things relative to itself.
that's risky -it is making a lot of assumptions about how hadoop has been deployed, assumptions that break on RPM or similar OS-integrated packagings. Better to rely on the env variable and be done with it. Certainly its easier to test, which is always good.
> The configuration file lists two paths to hadoop directories (bin and conf). Startup should check that these are valid directories and give appropriate messages.
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4090
> URL: https://issues.apache.org/jira/browse/HADOOP-4090
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/hive
> Affects Versions: 0.19.0
> Reporter: Ashish Thusoo
> Priority: Minor
> Attachments: hadoop-4090.2.patch, hadoop-4090.patch
>
>
> The configuration file lists two paths to hadoop directories (bin and conf). Startup should check that these are valid directories and give appropriate messages.
> Reported by Chad.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.