[jira] [Work logged] (DBCP-547) Add a ConnectionFactory class name setting for BasicDataSource.createConnectionFactory() #33

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/DBCP-547?focusedWorklogId=273331&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-273331 ]

ASF GitHub Bot logged work on DBCP-547:
---------------------------------------

                Author: ASF GitHub Bot
            Created on: 08/Jul/19 15:14
            Start Date: 08/Jul/19 15:14
    Worklog Time Spent: 10m 
      Work Description: asfgit commented on pull request #33: [DBCP-547] Add a ConnectionFactory class name setting for BasicDataSource.createConnectionFactory()
URL: https://github.com/apache/commons-dbcp/pull/33
 
 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 273331)
    Time Spent: 2h 10m  (was: 2h)

> Add a ConnectionFactory class name setting for BasicDataSource.createConnectionFactory() #33
> --------------------------------------------------------------------------------------------
>
>                 Key: DBCP-547
>                 URL: https://issues.apache.org/jira/browse/DBCP-547
>             Project: Commons DBCP
>          Issue Type: Improvement
>    Affects Versions: 2.2.0
>            Reporter: Lee Jun Gyun
>            Priority: Minor
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> It think it would be nice better to implement a ConnectionFactory class name setting in BasicDataSource class or implement a interface in DriverConnectionFactory class.
> In my current project, when getting a connection in my program, I call oracleSetModule.
> so, i think that after creating connection, call oracleSetModule via connectionFactoryImpl seems to be nice.
>   
> [Before]
> protected ConnectionFactory createConnectionFactory() throws SQLException {
> ...
> ...
> ConnectionFactory driverConnectionFactory =
>  new DriverConnectionFactory(driverToUse, url, connectionProperties);
>  return driverConnectionFactory;
>  }
> [After]
> protected ConnectionFactory createConnectionFactory() throws SQLException {
> ...
> ...
> ConnectionFactory driverConnectionFactory =
> getConnectionFactoryImpl().newInstance(...);
> return driverConnectionFactory;
> }
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)