You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/09/02 06:01:50 UTC
[GitHub] [kafka] ableegoldman opened a new pull request, #12585: HOTFIX: fix PriorityQueue iteration to assign warmups in priority order
ableegoldman opened a new pull request, #12585:
URL: https://github.com/apache/kafka/pull/12585
Based on a patch submitted to the `confluentinc` fork & then abandoned. Needed some updates and minor expansion but more or less just re-applied the changes proposed in https://github.com/confluentinc/kafka/pull/697.
Original PR has a _very_ detailed justification for these changes but the tl;dr of it is that apparently the PriorityQueue's iterator [does not actually guarantee](https://docs.oracle.com/javase/8/docs/api/java/util/PriorityQueue.html#iterator--) to return elements in priority order... 😒
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #12585: HOTFIX: fix PriorityQueue iteration to assign warmups in priority order
Posted by GitBox <gi...@apache.org>.
showuon commented on PR #12585:
URL: https://github.com/apache/kafka/pull/12585#issuecomment-1235323826
Backported to 3.3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon merged pull request #12585: HOTFIX: fix PriorityQueue iteration to assign warmups in priority order
Posted by GitBox <gi...@apache.org>.
showuon merged PR #12585:
URL: https://github.com/apache/kafka/pull/12585
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #12585: HOTFIX: fix PriorityQueue iteration to assign warmups in priority order
Posted by GitBox <gi...@apache.org>.
showuon commented on PR #12585:
URL: https://github.com/apache/kafka/pull/12585#issuecomment-1235320263
Failed tests are unrelated:
```
Build / JDK 17 and Scala 2.13 / org.apache.kafka.common.network.SslTransportLayerTest.[1] tlsProtocol=TLSv1.2, useInlinePem=false
Build / JDK 17 and Scala 2.13 / kafka.test.ClusterTestExtensionsTest.[1] Type=ZK, Name=testDefaults, MetadataVersion=3.3-IV3, Security=PLAINTEXT
Build / JDK 11 and Scala 2.13 / kafka.api.TransactionsExpirationTest.testTransactionAfterProducerIdExpires(String).quorum=zk
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #12585: HOTFIX: fix PriorityQueue iteration to assign warmups in priority order
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on PR #12585:
URL: https://github.com/apache/kafka/pull/12585#issuecomment-1235165665
@showuon yeah this one definitely caught me off guard, I honestly would have doubted it had I not seen the apparent results. 🤷♀️ Who knew?
By the way I'm just about to be out for a week so if you want to/wouldn't mind taking over getting this PR merged from here, that would be great! 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #12585: HOTFIX: fix PriorityQueue iteration to assign warmups in priority order
Posted by GitBox <gi...@apache.org>.
showuon commented on PR #12585:
URL: https://github.com/apache/kafka/pull/12585#issuecomment-1235184067
> By the way I'm just about to be out for a week so if you want to/wouldn't mind taking over getting this PR merged from here, that would be great! 🙏
No problem. I'll handle it! Enjoy~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org