You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/03/21 08:55:00 UTC
[GitHub] [pinot] KKcorps opened a new pull request #8375: Remove secrets from job spec
KKcorps opened a new pull request #8375:
URL: https://github.com/apache/pinot/pull/8375
This PR addresses the issue #8363
We may need to make changes at other places as well where auth token is going into logs.
I have also switched the output format to JSON instead of YAML as we already support JSON in ingestion spec and all the other configs are dumped as JSON as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] KKcorps closed pull request #8375: Remove secrets from job spec
Posted by GitBox <gi...@apache.org>.
KKcorps closed pull request #8375:
URL: https://github.com/apache/pinot/pull/8375
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #8375: Remove secrets from job spec
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on a change in pull request #8375:
URL: https://github.com/apache/pinot/pull/8375#discussion_r831370822
##########
File path: pinot-spi/src/main/java/org/apache/pinot/spi/ingestion/batch/spec/SegmentGenerationJobSpec.java
##########
@@ -288,4 +290,12 @@ public String getAuthToken() {
public void setAuthToken(String authToken) {
_authToken = authToken;
}
+
+ public String asJSONString(boolean removeSensitiveKeys) {
Review comment:
(minor)
```suggestion
public String toJSONString(boolean removeSensitiveKeys) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] KKcorps commented on pull request #8375: Remove secrets from job spec
Posted by GitBox <gi...@apache.org>.
KKcorps commented on pull request #8375:
URL: https://github.com/apache/pinot/pull/8375#issuecomment-1074336118
Accidentally got rebased with null handling branch.
Closing this PR and opening a new one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org