You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/07/30 23:33:37 UTC

[GitHub] brodybits opened a new pull request #56: CB-14145 pin even more added bundled deps in 5.0.x only

brodybits opened a new pull request #56: CB-14145 pin even more added bundled deps in 5.0.x only
URL: https://github.com/apache/cordova-browser/pull/56
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist
   is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   
   browser
   
   ### What does this PR do?
   
   - pin even more added bundled deps in 5.0.x only - needed to clear the red highlights in n`pm outdated --depth=0`
   
   ### What testing has been done on this change?
   
   - [ ] `npm audit` shows 0 vulnerabilities (using npm@6.2.0)
   - [ ] `npm outdated --depth=0` shows no red entries
   - [ ] `coho audit-license-headers -r browser` shows no missing license headers
   - [ ] `coho check-license -r browser` shows no incorrect licenses
   - [ ] `npm test` succeeds on AppVeyor CI & Travis CI
   - [ ] able to add to new Cordova project using `cordova platform add github:brodybits/cordova-browser#cb-14145-pin-even-more-added-bundled-deps-in-5.0.x-only` then run using npm@2.15.11 (bundled with deprecated node v4.9.1 version)
   
   ### Checklist
   
   - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
   - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
   - ~~Added automated test coverage as appropriate for this change.~~

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org