You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/07/20 07:15:01 UTC
[GitHub] codecov-io edited a comment on issue #5358: basic elastic connector
implementation
codecov-io edited a comment on issue #5358: basic elastic connector implementation
URL: https://github.com/apache/incubator-superset/pull/5358#issuecomment-406505055
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5358?src=pr&el=h1) Report
> Merging [#5358](https://codecov.io/gh/apache/incubator-superset/pull/5358?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/41447e8b3b3727f216673557ee8e783bdc4cf0ad?src=pr&el=desc) will **decrease** coverage by `0.17%`.
> The diff coverage is `48.59%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/5358?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5358 +/- ##
==========================================
- Coverage 59.1% 58.93% -0.18%
==========================================
Files 372 375 +3
Lines 23742 24133 +391
Branches 2758 2758
==========================================
+ Hits 14033 14223 +190
- Misses 9694 9895 +201
Partials 15 15
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5358?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/5358/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `92.53% <ø> (ø)` | :arrow_up: |
| [superset/connectors/elastic/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/5358/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9lbGFzdGljL19faW5pdF9fLnB5) | `100% <100%> (ø)` | |
| [superset/connectors/druid/views.py](https://codecov.io/gh/apache/incubator-superset/pull/5358/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `68.45% <100%> (+0.21%)` | :arrow_up: |
| [superset/connectors/elastic/models.py](https://codecov.io/gh/apache/incubator-superset/pull/5358/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9lbGFzdGljL21vZGVscy5weQ==) | `38.9% <38.9%> (ø)` | |
| [superset/connectors/elastic/views.py](https://codecov.io/gh/apache/incubator-superset/pull/5358/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9lbGFzdGljL3ZpZXdzLnB5) | `70.79% <70.79%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5358?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5358?src=pr&el=footer). Last update [41447e8...81b6a3f](https://codecov.io/gh/apache/incubator-superset/pull/5358?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org