You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/17 09:47:00 UTC

[GitHub] [flink] dianfu opened a new pull request #12198: [FLINK-17772][python] Fix to_pandas to make it work in JDK 11

dianfu opened a new pull request #12198:
URL: https://github.com/apache/flink/pull/12198


   
   ## What is the purpose of the change
   
   *This pull request fixes to_pandas to make it work in JDK 11 *
   
   ## Brief change log
   
     - *Call ArrowUtils.checkArrowUsable in ArrowUtils.collectAsPandasDataFrame to initialize the JVM of the PythonGatewayServer to make it work in JDK 11*
   
   ## Verifying this change
   
   This change is a trivial rework without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12198: [FLINK-17772][python] Fix to_pandas to make it work in JDK 11

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12198:
URL: https://github.com/apache/flink/pull/12198#issuecomment-629771337

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit b57c26b5c013c9083b0536e433d64263d48b7c94 (Fri Oct 16 10:34:09 UTC 2020)

**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!

<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress

* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.

Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:

- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12198: [FLINK-17772][python] Fix to_pandas to make it work in JDK 11

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #12198:
URL: https://github.com/apache/flink/pull/12198#issuecomment-629771337

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit b57c26b5c013c9083b0536e433d64263d48b7c94 (Sun May 17 09:50:09 UTC 2020)

**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!

<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] dianfu closed pull request #12198: [FLINK-17772][python] Fix to_pandas to make it work in JDK 11

Posted by GitBox <gi...@apache.org>.

dianfu closed pull request #12198:
URL: https://github.com/apache/flink/pull/12198


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12198: [FLINK-17772][python] Fix to_pandas to make it work in JDK 11

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #12198:
URL: https://github.com/apache/flink/pull/12198#issuecomment-629772858


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b57c26b5c013c9083b0536e433d64263d48b7c94",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "b57c26b5c013c9083b0536e433d64263d48b7c94",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b57c26b5c013c9083b0536e433d64263d48b7c94 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12198: [FLINK-17772][python] Fix to_pandas to make it work in JDK 11

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12198:
URL: https://github.com/apache/flink/pull/12198#issuecomment-629772858


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b57c26b5c013c9083b0536e433d64263d48b7c94",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1602",
       "triggerID" : "b57c26b5c013c9083b0536e433d64263d48b7c94",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b57c26b5c013c9083b0536e433d64263d48b7c94 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1602) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] dianfu commented on pull request #12198: [FLINK-17772][python] Fix to_pandas to make it work in JDK 11

Posted by GitBox <gi...@apache.org>.

dianfu commented on pull request #12198:
URL: https://github.com/apache/flink/pull/12198#issuecomment-629778251


   Have verified the PR manually(Reproduce this problem in JDK 11 and verified that this issue could be addressed by this PR).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] dianfu edited a comment on pull request #12198: [FLINK-17772][python] Fix to_pandas to make it work in JDK 11

Posted by GitBox <gi...@apache.org>.

dianfu edited a comment on pull request #12198:
URL: https://github.com/apache/flink/pull/12198#issuecomment-629778251


   Have verified the PR manually(Reproduced the problem in JDK 11 and verified that this issue could be addressed by this PR).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] dianfu commented on pull request #12198: [FLINK-17772][python] Fix to_pandas to make it work in JDK 11

Posted by GitBox <gi...@apache.org>.

dianfu commented on pull request #12198:
URL: https://github.com/apache/flink/pull/12198#issuecomment-629779061


   @HuangXingBo Thanks for the review. Will merge once the tests passed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] HuangXingBo commented on pull request #12198: [FLINK-17772][python] Fix to_pandas to make it work in JDK 11

Posted by GitBox <gi...@apache.org>.

HuangXingBo commented on pull request #12198:
URL: https://github.com/apache/flink/pull/12198#issuecomment-629778964


   Thanks a lot for the quick fix @dianfu . It looks good from my side. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org