You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (Created) (JIRA)" <ji...@apache.org> on 2012/03/23 10:17:27 UTC
[jira] [Created] (SOLR-3268) remove write acess to source tree
(chmod 555) when running tests in jenkins
remove write acess to source tree (chmod 555) when running tests in jenkins
---------------------------------------------------------------------------
Key: SOLR-3268
URL: https://issues.apache.org/jira/browse/SOLR-3268
Project: Solr
Issue Type: Bug
Reporter: Robert Muir
Fix For: 3.6, 4.0
Some tests are currently creating files under the source tree.
This causes a lot of problems, it makes my checkout look dirty after running 'ant test' and i have to cleanup.
I opened and issue for this a month in a half for solrj/src/test-files/solrj/solr/shared/test-solr.xml (SOLR-3112),
but now we have a second file (core/src/test-files/solr/conf/elevate-data-distrib.xml).
So I think hudson needs to chmod these src directories to 555, so that solr tests that do this will fail.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3268) remove write acess to source tree
(chmod 555) when running tests in jenkins
Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236490#comment-13236490 ]
Robert Muir commented on SOLR-3268:
-----------------------------------
Dawid: we already do that.
> remove write acess to source tree (chmod 555) when running tests in jenkins
> ---------------------------------------------------------------------------
>
> Key: SOLR-3268
> URL: https://issues.apache.org/jira/browse/SOLR-3268
> Project: Solr
> Issue Type: Bug
> Reporter: Robert Muir
> Fix For: 3.6, 4.0
>
>
> Some tests are currently creating files under the source tree.
> This causes a lot of problems, it makes my checkout look dirty after running 'ant test' and i have to cleanup.
> I opened and issue for this a month in a half for solrj/src/test-files/solrj/solr/shared/test-solr.xml (SOLR-3112),
> but now we have a second file (core/src/test-files/solr/conf/elevate-data-distrib.xml).
> So I think hudson needs to chmod these src directories to 555, so that solr tests that do this will fail.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3268) remove write acess to source tree
(chmod 555) when running tests in jenkins
Posted by "Uwe Schindler (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236474#comment-13236474 ]
Uwe Schindler commented on SOLR-3268:
-------------------------------------
LOL
> remove write acess to source tree (chmod 555) when running tests in jenkins
> ---------------------------------------------------------------------------
>
> Key: SOLR-3268
> URL: https://issues.apache.org/jira/browse/SOLR-3268
> Project: Solr
> Issue Type: Bug
> Reporter: Robert Muir
> Fix For: 3.6, 4.0
>
>
> Some tests are currently creating files under the source tree.
> This causes a lot of problems, it makes my checkout look dirty after running 'ant test' and i have to cleanup.
> I opened and issue for this a month in a half for solrj/src/test-files/solrj/solr/shared/test-solr.xml (SOLR-3112),
> but now we have a second file (core/src/test-files/solr/conf/elevate-data-distrib.xml).
> So I think hudson needs to chmod these src directories to 555, so that solr tests that do this will fail.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3268) remove write acess to source tree
(chmod 555) when running tests in jenkins
Posted by "Hoss Man (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238685#comment-13238685 ]
Hoss Man commented on SOLR-3268:
--------------------------------
if locking down src/ so tests can't make changes is tricky to do safely, perhaps a we could do something simpler to get us part way towards the ultimate goal? ... add a final step to the jenkins build script that fails if "svn status | wc -l" returns non-zero?
it wont't ensure no changes are made to src/, but it should ensure no changes are made to src/ unless explicitly allowed by an svn:ignore ... then we just have to (remove any existing svn:ignore under /src and) make sure we publicly shame anyone who adds svn:ignores to src/ because they wrote a sloppy test.
> remove write acess to source tree (chmod 555) when running tests in jenkins
> ---------------------------------------------------------------------------
>
> Key: SOLR-3268
> URL: https://issues.apache.org/jira/browse/SOLR-3268
> Project: Solr
> Issue Type: Bug
> Reporter: Robert Muir
> Assignee: Robert Muir
> Fix For: 4.0
>
> Attachments: SOLR-3268_sync.patch
>
>
> Some tests are currently creating files under the source tree.
> This causes a lot of problems, it makes my checkout look dirty after running 'ant test' and i have to cleanup.
> I opened and issue for this a month in a half for solrj/src/test-files/solrj/solr/shared/test-solr.xml (SOLR-3112),
> but now we have a second file (core/src/test-files/solr/conf/elevate-data-distrib.xml).
> So I think hudson needs to chmod these src directories to 555, so that solr tests that do this will fail.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3268) remove write acess to source tree
(chmod 555) when running tests in jenkins
Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238752#comment-13238752 ]
Robert Muir commented on SOLR-3268:
-----------------------------------
its also possible the patch on this issue might solve that problem for individual runs
(its still not as good as a test creating its own tempdir, guaranteeing it wont interfere with
other tests in the same run though).
> remove write acess to source tree (chmod 555) when running tests in jenkins
> ---------------------------------------------------------------------------
>
> Key: SOLR-3268
> URL: https://issues.apache.org/jira/browse/SOLR-3268
> Project: Solr
> Issue Type: Bug
> Reporter: Robert Muir
> Assignee: Robert Muir
> Fix For: 4.0
>
> Attachments: SOLR-3268_sync.patch
>
>
> Some tests are currently creating files under the source tree.
> This causes a lot of problems, it makes my checkout look dirty after running 'ant test' and i have to cleanup.
> I opened and issue for this a month in a half for solrj/src/test-files/solrj/solr/shared/test-solr.xml (SOLR-3112),
> but now we have a second file (core/src/test-files/solr/conf/elevate-data-distrib.xml).
> So I think hudson needs to chmod these src directories to 555, so that solr tests that do this will fail.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3268) remove write acess to source tree
(chmod 555) when running tests in jenkins
Posted by "Steven Rowe (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238738#comment-13238738 ]
Steven Rowe commented on SOLR-3268:
-----------------------------------
bq. i think you're talking about SOLR-3112
I don't think so - I think I was remembering something under DIH {{test-files/}}.
Here are the non-standard {{svn:ignore}}'s I found under {{branch_3x/solr/}} - are any of these problematic?:
||directory||svn:ignore||
|contrib/dataimporthandler/src/test-files|dataimport.properties|
|contrib/dataimporthandler/src/test-files/dih/solr/conf|dataimport.properties|
|contrib/dataimporthandler-extras/src/test-files/dihextras/solr/conf|dataimport.properties|
|core/src/test-files/solr|data|
|core/src/test-files/solr|data|
|example/example-DIH/solr/db|data|
|example/example-DIH/solr/mail|data|
|example/example-DIH/solr/db|data|
|example/example-DIH/solr/mail|data|
|example/example-DIH/solr/mail/lib|*.jar|
|example/example-DIH/solr/rss|data|
|example/example-DIH/solr/rss/conf|dataimport.properties|
|example/example-DIH/solr/tika|data|
|example/exampledocs|post.jar|
|example/multicore/core0|data|
|example/multicore/core1|data|
|example/solr|data, lib, logs|
> remove write acess to source tree (chmod 555) when running tests in jenkins
> ---------------------------------------------------------------------------
>
> Key: SOLR-3268
> URL: https://issues.apache.org/jira/browse/SOLR-3268
> Project: Solr
> Issue Type: Bug
> Reporter: Robert Muir
> Assignee: Robert Muir
> Fix For: 4.0
>
> Attachments: SOLR-3268_sync.patch
>
>
> Some tests are currently creating files under the source tree.
> This causes a lot of problems, it makes my checkout look dirty after running 'ant test' and i have to cleanup.
> I opened and issue for this a month in a half for solrj/src/test-files/solrj/solr/shared/test-solr.xml (SOLR-3112),
> but now we have a second file (core/src/test-files/solr/conf/elevate-data-distrib.xml).
> So I think hudson needs to chmod these src directories to 555, so that solr tests that do this will fail.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3268) remove write acess to source tree
(chmod 555) when running tests in jenkins
Posted by "Hoss Man (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238710#comment-13238710 ]
Hoss Man commented on SOLR-3268:
--------------------------------
i think you're talking about SOLR-3112 which was dealt with .. but even if there are others, we can start by adding this check now, and then file issues to fix & remove whatever is left.
this isn't a silver bullet, it's certainly not as good as actually looking down src to fail on writes, but it will at least force people to be aware if/when they add a test that pollutes src/
> remove write acess to source tree (chmod 555) when running tests in jenkins
> ---------------------------------------------------------------------------
>
> Key: SOLR-3268
> URL: https://issues.apache.org/jira/browse/SOLR-3268
> Project: Solr
> Issue Type: Bug
> Reporter: Robert Muir
> Assignee: Robert Muir
> Fix For: 4.0
>
> Attachments: SOLR-3268_sync.patch
>
>
> Some tests are currently creating files under the source tree.
> This causes a lot of problems, it makes my checkout look dirty after running 'ant test' and i have to cleanup.
> I opened and issue for this a month in a half for solrj/src/test-files/solrj/solr/shared/test-solr.xml (SOLR-3112),
> but now we have a second file (core/src/test-files/solr/conf/elevate-data-distrib.xml).
> So I think hudson needs to chmod these src directories to 555, so that solr tests that do this will fail.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3268) remove write acess to source tree
(chmod 555) when running tests in jenkins
Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238686#comment-13238686 ]
Robert Muir commented on SOLR-3268:
-----------------------------------
{quote}
add a final step to the jenkins build script that fails if "svn status | wc -l" returns non-zero?
{quote}
duh... what a simple solution. +1
> remove write acess to source tree (chmod 555) when running tests in jenkins
> ---------------------------------------------------------------------------
>
> Key: SOLR-3268
> URL: https://issues.apache.org/jira/browse/SOLR-3268
> Project: Solr
> Issue Type: Bug
> Reporter: Robert Muir
> Assignee: Robert Muir
> Fix For: 4.0
>
> Attachments: SOLR-3268_sync.patch
>
>
> Some tests are currently creating files under the source tree.
> This causes a lot of problems, it makes my checkout look dirty after running 'ant test' and i have to cleanup.
> I opened and issue for this a month in a half for solrj/src/test-files/solrj/solr/shared/test-solr.xml (SOLR-3112),
> but now we have a second file (core/src/test-files/solr/conf/elevate-data-distrib.xml).
> So I think hudson needs to chmod these src directories to 555, so that solr tests that do this will fail.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3268) remove write acess to source tree
(chmod 555) when running tests in jenkins
Posted by "Dawid Weiss (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236489#comment-13236489 ]
Dawid Weiss commented on SOLR-3268:
-----------------------------------
I agree that tests modifying sources or writing to source areas are a pain. I know these files can be svn:ignored but it just... feels dirty somehow. On a constructive note -- maybe we can use this:
http://ant.apache.org/manual/Tasks/sync.html
and mirror whatever src folder structure is required for these tests in the build area?
> remove write acess to source tree (chmod 555) when running tests in jenkins
> ---------------------------------------------------------------------------
>
> Key: SOLR-3268
> URL: https://issues.apache.org/jira/browse/SOLR-3268
> Project: Solr
> Issue Type: Bug
> Reporter: Robert Muir
> Fix For: 3.6, 4.0
>
>
> Some tests are currently creating files under the source tree.
> This causes a lot of problems, it makes my checkout look dirty after running 'ant test' and i have to cleanup.
> I opened and issue for this a month in a half for solrj/src/test-files/solrj/solr/shared/test-solr.xml (SOLR-3112),
> but now we have a second file (core/src/test-files/solr/conf/elevate-data-distrib.xml).
> So I think hudson needs to chmod these src directories to 555, so that solr tests that do this will fail.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3268) remove write acess to source tree
(chmod 555) when running tests in jenkins
Posted by "Steven Rowe (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238767#comment-13238767 ]
Steven Rowe commented on SOLR-3268:
-----------------------------------
Here's the list for {{trunk/solr/}}:
||directory||svn:ignore||
|contrib/dataimporthandler/src/test-files|dataimport.properties|
|contrib/dataimporthandler/src/test-files/dih/solr/conf|dataimport.properties|
|contrib/dataimporthandler-extras/src/test-files/dihextras/solr/conf|dataimport.properties|
|core/src/test-files/solr|data|
|example/example-DIH/solr/db|data|
|example/example-DIH/solr/db/conf|dataimport.properties|
|example/example-DIH/solr/mail|data|
|example/example-DIH/solr/mail/lib|*.jar|
|example/example-DIH/solr/rss|data|
|example/example-DIH/solr/rss/conf|dataimport.properties|
|example/example-DIH/solr/tika|data|
|example/exampledocs|post.jar|
|example/multicore/core0|data|
|example/multicore/core1|data|
|example/solr|data, lib, logs, zoo_data|
> remove write acess to source tree (chmod 555) when running tests in jenkins
> ---------------------------------------------------------------------------
>
> Key: SOLR-3268
> URL: https://issues.apache.org/jira/browse/SOLR-3268
> Project: Solr
> Issue Type: Bug
> Reporter: Robert Muir
> Assignee: Robert Muir
> Fix For: 4.0
>
> Attachments: SOLR-3268_sync.patch
>
>
> Some tests are currently creating files under the source tree.
> This causes a lot of problems, it makes my checkout look dirty after running 'ant test' and i have to cleanup.
> I opened and issue for this a month in a half for solrj/src/test-files/solrj/solr/shared/test-solr.xml (SOLR-3112),
> but now we have a second file (core/src/test-files/solr/conf/elevate-data-distrib.xml).
> So I think hudson needs to chmod these src directories to 555, so that solr tests that do this will fail.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3268) remove write acess to source tree
(chmod 555) when running tests in jenkins
Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238790#comment-13238790 ]
Robert Muir commented on SOLR-3268:
-----------------------------------
Hmm definitely this still gets created (I un-svn-ignored it).
Then i chmod 555'd core/src/test-file/solr just to hopefully make the offendor fail,
but with this in place, instead the test hangs infinitely (looks like NoCacheHeaderTest)
> remove write acess to source tree (chmod 555) when running tests in jenkins
> ---------------------------------------------------------------------------
>
> Key: SOLR-3268
> URL: https://issues.apache.org/jira/browse/SOLR-3268
> Project: Solr
> Issue Type: Bug
> Reporter: Robert Muir
> Assignee: Robert Muir
> Fix For: 4.0
>
> Attachments: SOLR-3268_sync.patch
>
>
> Some tests are currently creating files under the source tree.
> This causes a lot of problems, it makes my checkout look dirty after running 'ant test' and i have to cleanup.
> I opened and issue for this a month in a half for solrj/src/test-files/solrj/solr/shared/test-solr.xml (SOLR-3112),
> but now we have a second file (core/src/test-files/solr/conf/elevate-data-distrib.xml).
> So I think hudson needs to chmod these src directories to 555, so that solr tests that do this will fail.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-3268) remove write acess to source tree
(chmod 555) when running tests in jenkins
Posted by "Robert Muir (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated SOLR-3268:
------------------------------
Fix Version/s: (was: 3.6)
I don't think figuring out how to do this needs to block 3.6: fortunately Luca fixed all
the tests in question!
But we should look into a safe way to do this in the future: the main thing being is that
we want to restore the correct chmod in jenkins even if the build fails, otherwise
the next time it goes to svn update, I think there will be problems?
> remove write acess to source tree (chmod 555) when running tests in jenkins
> ---------------------------------------------------------------------------
>
> Key: SOLR-3268
> URL: https://issues.apache.org/jira/browse/SOLR-3268
> Project: Solr
> Issue Type: Bug
> Reporter: Robert Muir
> Assignee: Robert Muir
> Fix For: 4.0
>
> Attachments: SOLR-3268_sync.patch
>
>
> Some tests are currently creating files under the source tree.
> This causes a lot of problems, it makes my checkout look dirty after running 'ant test' and i have to cleanup.
> I opened and issue for this a month in a half for solrj/src/test-files/solrj/solr/shared/test-solr.xml (SOLR-3112),
> but now we have a second file (core/src/test-files/solr/conf/elevate-data-distrib.xml).
> So I think hudson needs to chmod these src directories to 555, so that solr tests that do this will fail.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3268) remove write acess to source tree
(chmod 555) when running tests in jenkins
Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238835#comment-13238835 ]
Robert Muir commented on SOLR-3268:
-----------------------------------
OK the previous commit may or may not have also fixed the dataimporthandler problems.
I need a beer run before touching DIH but ill investigate these next.
> remove write acess to source tree (chmod 555) when running tests in jenkins
> ---------------------------------------------------------------------------
>
> Key: SOLR-3268
> URL: https://issues.apache.org/jira/browse/SOLR-3268
> Project: Solr
> Issue Type: Bug
> Reporter: Robert Muir
> Assignee: Robert Muir
> Fix For: 4.0
>
> Attachments: SOLR-3268_sync.patch
>
>
> Some tests are currently creating files under the source tree.
> This causes a lot of problems, it makes my checkout look dirty after running 'ant test' and i have to cleanup.
> I opened and issue for this a month in a half for solrj/src/test-files/solrj/solr/shared/test-solr.xml (SOLR-3112),
> but now we have a second file (core/src/test-files/solr/conf/elevate-data-distrib.xml).
> So I think hudson needs to chmod these src directories to 555, so that solr tests that do this will fail.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-3268) remove write acess to source tree
(chmod 555) when running tests in jenkins
Posted by "Robert Muir (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated SOLR-3268:
------------------------------
Attachment: SOLR-3268_sync.patch
So I was wrong about the resource-sync idea: here's a patch implementing it.
unfortunately this is not a great solution:
* it only solves one of the problems (for some reason SOLR-3112 is not solved by this).
* its just syncing the test-files to build/test-files and putting that in classpath instead: but this still doesnt "fix" anything, any tests that modify things in here could interfere with other tests because its not a per-jvm sandbox like TEMP_DIR, and its definitely not per-test.
Bottom line: I think really the best solution is that tests that want to write files to their configuration area should create a temporary directory (via our normal tempdir mechanism) and write to that...
> remove write acess to source tree (chmod 555) when running tests in jenkins
> ---------------------------------------------------------------------------
>
> Key: SOLR-3268
> URL: https://issues.apache.org/jira/browse/SOLR-3268
> Project: Solr
> Issue Type: Bug
> Reporter: Robert Muir
> Fix For: 3.6, 4.0
>
> Attachments: SOLR-3268_sync.patch
>
>
> Some tests are currently creating files under the source tree.
> This causes a lot of problems, it makes my checkout look dirty after running 'ant test' and i have to cleanup.
> I opened and issue for this a month in a half for solrj/src/test-files/solrj/solr/shared/test-solr.xml (SOLR-3112),
> but now we have a second file (core/src/test-files/solr/conf/elevate-data-distrib.xml).
> So I think hudson needs to chmod these src directories to 555, so that solr tests that do this will fail.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3268) remove write acess to source tree
(chmod 555) when running tests in jenkins
Posted by "Dawid Weiss (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238775#comment-13238775 ]
Dawid Weiss commented on SOLR-3268:
-----------------------------------
All of these are in .gitignore, Steven (and can be regenerated via dev-tools/scripts/gitignore-gen.sh.
> remove write acess to source tree (chmod 555) when running tests in jenkins
> ---------------------------------------------------------------------------
>
> Key: SOLR-3268
> URL: https://issues.apache.org/jira/browse/SOLR-3268
> Project: Solr
> Issue Type: Bug
> Reporter: Robert Muir
> Assignee: Robert Muir
> Fix For: 4.0
>
> Attachments: SOLR-3268_sync.patch
>
>
> Some tests are currently creating files under the source tree.
> This causes a lot of problems, it makes my checkout look dirty after running 'ant test' and i have to cleanup.
> I opened and issue for this a month in a half for solrj/src/test-files/solrj/solr/shared/test-solr.xml (SOLR-3112),
> but now we have a second file (core/src/test-files/solr/conf/elevate-data-distrib.xml).
> So I think hudson needs to chmod these src directories to 555, so that solr tests that do this will fail.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3268) remove write acess to source tree
(chmod 555) when running tests in jenkins
Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238888#comment-13238888 ]
Robert Muir commented on SOLR-3268:
-----------------------------------
OK all those non-example/ svn:ignore's are gone.
I think we can now add the 'svn status' check to jenkins nightly.
> remove write acess to source tree (chmod 555) when running tests in jenkins
> ---------------------------------------------------------------------------
>
> Key: SOLR-3268
> URL: https://issues.apache.org/jira/browse/SOLR-3268
> Project: Solr
> Issue Type: Bug
> Reporter: Robert Muir
> Assignee: Robert Muir
> Fix For: 4.0
>
> Attachments: SOLR-3268_sync.patch
>
>
> Some tests are currently creating files under the source tree.
> This causes a lot of problems, it makes my checkout look dirty after running 'ant test' and i have to cleanup.
> I opened and issue for this a month in a half for solrj/src/test-files/solrj/solr/shared/test-solr.xml (SOLR-3112),
> but now we have a second file (core/src/test-files/solr/conf/elevate-data-distrib.xml).
> So I think hudson needs to chmod these src directories to 555, so that solr tests that do this will fail.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3268) remove write acess to source tree
(chmod 555) when running tests in jenkins
Posted by "Steven Rowe (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238702#comment-13238702 ]
Steven Rowe commented on SOLR-3268:
-----------------------------------
{quote}
add a final step to the jenkins build script that fails if "svn status | wc -l" returns non-zero?
it wont't ensure no changes are made to src/, but it should ensure no changes are made to src/ unless explicitly allowed by an svn:ignore
{quote}
I don't remember which one(s), but I recall that at least one file is (was?) produced by a Solr test and svn:ignore'd. In order for Hoss's suggestion to be fully effective, we should stop svn:ignore'ing test outputs (outside of {{build/}} or other already ignored directories). I'll see what's being svn:ignore'd now.
> remove write acess to source tree (chmod 555) when running tests in jenkins
> ---------------------------------------------------------------------------
>
> Key: SOLR-3268
> URL: https://issues.apache.org/jira/browse/SOLR-3268
> Project: Solr
> Issue Type: Bug
> Reporter: Robert Muir
> Assignee: Robert Muir
> Fix For: 4.0
>
> Attachments: SOLR-3268_sync.patch
>
>
> Some tests are currently creating files under the source tree.
> This causes a lot of problems, it makes my checkout look dirty after running 'ant test' and i have to cleanup.
> I opened and issue for this a month in a half for solrj/src/test-files/solrj/solr/shared/test-solr.xml (SOLR-3112),
> but now we have a second file (core/src/test-files/solr/conf/elevate-data-distrib.xml).
> So I think hudson needs to chmod these src directories to 555, so that solr tests that do this will fail.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3268) remove write acess to source tree
(chmod 555) when running tests in jenkins
Posted by "Michael McCandless (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236500#comment-13236500 ]
Michael McCandless commented on SOLR-3268:
------------------------------------------
+1
> remove write acess to source tree (chmod 555) when running tests in jenkins
> ---------------------------------------------------------------------------
>
> Key: SOLR-3268
> URL: https://issues.apache.org/jira/browse/SOLR-3268
> Project: Solr
> Issue Type: Bug
> Reporter: Robert Muir
> Fix For: 3.6, 4.0
>
>
> Some tests are currently creating files under the source tree.
> This causes a lot of problems, it makes my checkout look dirty after running 'ant test' and i have to cleanup.
> I opened and issue for this a month in a half for solrj/src/test-files/solrj/solr/shared/test-solr.xml (SOLR-3112),
> but now we have a second file (core/src/test-files/solr/conf/elevate-data-distrib.xml).
> So I think hudson needs to chmod these src directories to 555, so that solr tests that do this will fail.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3268) remove write acess to source tree
(chmod 555) when running tests in jenkins
Posted by "Dawid Weiss (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236494#comment-13236494 ]
Dawid Weiss commented on SOLR-3268:
-----------------------------------
Oh... in that case the tests just need to be fixed :)
> remove write acess to source tree (chmod 555) when running tests in jenkins
> ---------------------------------------------------------------------------
>
> Key: SOLR-3268
> URL: https://issues.apache.org/jira/browse/SOLR-3268
> Project: Solr
> Issue Type: Bug
> Reporter: Robert Muir
> Fix For: 3.6, 4.0
>
>
> Some tests are currently creating files under the source tree.
> This causes a lot of problems, it makes my checkout look dirty after running 'ant test' and i have to cleanup.
> I opened and issue for this a month in a half for solrj/src/test-files/solrj/solr/shared/test-solr.xml (SOLR-3112),
> but now we have a second file (core/src/test-files/solr/conf/elevate-data-distrib.xml).
> So I think hudson needs to chmod these src directories to 555, so that solr tests that do this will fail.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3268) remove write acess to source tree
(chmod 555) when running tests in jenkins
Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238743#comment-13238743 ]
Robert Muir commented on SOLR-3268:
-----------------------------------
The ones under src/test-files is definitely problematic.
What happens is that tests put indexes in there. And later tests go
and 'update' those indexes. So if you make any change to the index format,
two things can happen (both of which have happened to me):
# you see strange exceptions and think you broke something, digging into
tests only to find out its this src/test-files stuff.
# after committing, other developers on the mailing list get confused
and think something is broken for the same reason.
As a temporary hack we have this in 'ant clean':
clean:
[echo] TODO: fix tests to not write files to 'core/src/test-files/solr/data'!
But thats not a real solution.
The svn:ignore just shoves the problem under the rug.
> remove write acess to source tree (chmod 555) when running tests in jenkins
> ---------------------------------------------------------------------------
>
> Key: SOLR-3268
> URL: https://issues.apache.org/jira/browse/SOLR-3268
> Project: Solr
> Issue Type: Bug
> Reporter: Robert Muir
> Assignee: Robert Muir
> Fix For: 4.0
>
> Attachments: SOLR-3268_sync.patch
>
>
> Some tests are currently creating files under the source tree.
> This causes a lot of problems, it makes my checkout look dirty after running 'ant test' and i have to cleanup.
> I opened and issue for this a month in a half for solrj/src/test-files/solrj/solr/shared/test-solr.xml (SOLR-3112),
> but now we have a second file (core/src/test-files/solr/conf/elevate-data-distrib.xml).
> So I think hudson needs to chmod these src directories to 555, so that solr tests that do this will fail.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Assigned] (SOLR-3268) remove write acess to source tree
(chmod 555) when running tests in jenkins
Posted by "Hoss Man (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hoss Man reassigned SOLR-3268:
------------------------------
Assignee: Robert Muir
Issue is marked 3.6 and actively being discussed but has no assignee - assigning to most active committer contributing patches/discussion so far to triage wether this can/should be pushed to 4.0 or not.
> remove write acess to source tree (chmod 555) when running tests in jenkins
> ---------------------------------------------------------------------------
>
> Key: SOLR-3268
> URL: https://issues.apache.org/jira/browse/SOLR-3268
> Project: Solr
> Issue Type: Bug
> Reporter: Robert Muir
> Assignee: Robert Muir
> Fix For: 3.6, 4.0
>
> Attachments: SOLR-3268_sync.patch
>
>
> Some tests are currently creating files under the source tree.
> This causes a lot of problems, it makes my checkout look dirty after running 'ant test' and i have to cleanup.
> I opened and issue for this a month in a half for solrj/src/test-files/solrj/solr/shared/test-solr.xml (SOLR-3112),
> but now we have a second file (core/src/test-files/solr/conf/elevate-data-distrib.xml).
> So I think hudson needs to chmod these src directories to 555, so that solr tests that do this will fail.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3268) remove write acess to source tree
(chmod 555) when running tests in jenkins
Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238796#comment-13238796 ]
Robert Muir commented on SOLR-3268:
-----------------------------------
If you apply the patch, the test won't create indexes under this directory any more.
This is an improvement even though its not perfect. I'm gonna commit it.
> remove write acess to source tree (chmod 555) when running tests in jenkins
> ---------------------------------------------------------------------------
>
> Key: SOLR-3268
> URL: https://issues.apache.org/jira/browse/SOLR-3268
> Project: Solr
> Issue Type: Bug
> Reporter: Robert Muir
> Assignee: Robert Muir
> Fix For: 4.0
>
> Attachments: SOLR-3268_sync.patch
>
>
> Some tests are currently creating files under the source tree.
> This causes a lot of problems, it makes my checkout look dirty after running 'ant test' and i have to cleanup.
> I opened and issue for this a month in a half for solrj/src/test-files/solrj/solr/shared/test-solr.xml (SOLR-3112),
> but now we have a second file (core/src/test-files/solr/conf/elevate-data-distrib.xml).
> So I think hudson needs to chmod these src directories to 555, so that solr tests that do this will fail.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3268) remove write acess to source tree
(chmod 555) when running tests in jenkins
Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238783#comment-13238783 ]
Robert Muir commented on SOLR-3268:
-----------------------------------
I'm first testing if core/src/test-files/solr is still needed. Luca fixed a couple tests in SOLR-3112.
Maybe its obselete and can be removed from svn:ignore, along with the ant clean hack.
> remove write acess to source tree (chmod 555) when running tests in jenkins
> ---------------------------------------------------------------------------
>
> Key: SOLR-3268
> URL: https://issues.apache.org/jira/browse/SOLR-3268
> Project: Solr
> Issue Type: Bug
> Reporter: Robert Muir
> Assignee: Robert Muir
> Fix For: 4.0
>
> Attachments: SOLR-3268_sync.patch
>
>
> Some tests are currently creating files under the source tree.
> This causes a lot of problems, it makes my checkout look dirty after running 'ant test' and i have to cleanup.
> I opened and issue for this a month in a half for solrj/src/test-files/solrj/solr/shared/test-solr.xml (SOLR-3112),
> but now we have a second file (core/src/test-files/solr/conf/elevate-data-distrib.xml).
> So I think hudson needs to chmod these src directories to 555, so that solr tests that do this will fail.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (SOLR-3268) remove write acess to source tree
(chmod 555) when running tests in jenkins
Posted by "Robert Muir (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir resolved SOLR-3268.
-------------------------------
Resolution: Fixed
Fix Version/s: 3.6
I committed the svn status checker to nightly.
> remove write acess to source tree (chmod 555) when running tests in jenkins
> ---------------------------------------------------------------------------
>
> Key: SOLR-3268
> URL: https://issues.apache.org/jira/browse/SOLR-3268
> Project: Solr
> Issue Type: Bug
> Reporter: Robert Muir
> Assignee: Robert Muir
> Fix For: 3.6, 4.0
>
> Attachments: SOLR-3268_sync.patch
>
>
> Some tests are currently creating files under the source tree.
> This causes a lot of problems, it makes my checkout look dirty after running 'ant test' and i have to cleanup.
> I opened and issue for this a month in a half for solrj/src/test-files/solrj/solr/shared/test-solr.xml (SOLR-3112),
> but now we have a second file (core/src/test-files/solr/conf/elevate-data-distrib.xml).
> So I think hudson needs to chmod these src directories to 555, so that solr tests that do this will fail.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3268) remove write acess to source tree
(chmod 555) when running tests in jenkins
Posted by "Steven Rowe (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238793#comment-13238793 ]
Steven Rowe commented on SOLR-3268:
-----------------------------------
bq. All of these are in .gitignore, Steven (and can be regenerated via dev-tools/scripts/gitignore-gen.sh.
Right, I'd forgotten about that (I'm not a git user).
I rolled my own dirty one-liner script (newlines/indents added here for clarity):
{noformat}
(for a in $(find . -type d | grep -v '\.svn\|/build') ; do
b=`svn propget svn:ignore $a`
if [[ -n $b ]]; then
c=${b//$'\n'/, }
echo "|$a|$c|"
fi
done) 2>/dev/null
{noformat}
> remove write acess to source tree (chmod 555) when running tests in jenkins
> ---------------------------------------------------------------------------
>
> Key: SOLR-3268
> URL: https://issues.apache.org/jira/browse/SOLR-3268
> Project: Solr
> Issue Type: Bug
> Reporter: Robert Muir
> Assignee: Robert Muir
> Fix For: 4.0
>
> Attachments: SOLR-3268_sync.patch
>
>
> Some tests are currently creating files under the source tree.
> This causes a lot of problems, it makes my checkout look dirty after running 'ant test' and i have to cleanup.
> I opened and issue for this a month in a half for solrj/src/test-files/solrj/solr/shared/test-solr.xml (SOLR-3112),
> but now we have a second file (core/src/test-files/solr/conf/elevate-data-distrib.xml).
> So I think hudson needs to chmod these src directories to 555, so that solr tests that do this will fail.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3268) remove write acess to source tree
(chmod 555) when running tests in jenkins
Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238821#comment-13238821 ]
Robert Muir commented on SOLR-3268:
-----------------------------------
OK: i think the core/src/test-files/solr/data svn:ignore is nuked in trunk and branch_3x.
As i said before its still not perfect, and I put comments in NoCacheHeaderTest indicating its broken,
because if two different tests try to write to this sync'ed build/test-files directory at the same time,
then it will cause strange fails.
But its an improvement in the sense that we don't need the special ant clean, we don't dirty up the
source tree, and sync task (called by compile-test) should nuke any leftover indexes created from
the previous run.
> remove write acess to source tree (chmod 555) when running tests in jenkins
> ---------------------------------------------------------------------------
>
> Key: SOLR-3268
> URL: https://issues.apache.org/jira/browse/SOLR-3268
> Project: Solr
> Issue Type: Bug
> Reporter: Robert Muir
> Assignee: Robert Muir
> Fix For: 4.0
>
> Attachments: SOLR-3268_sync.patch
>
>
> Some tests are currently creating files under the source tree.
> This causes a lot of problems, it makes my checkout look dirty after running 'ant test' and i have to cleanup.
> I opened and issue for this a month in a half for solrj/src/test-files/solrj/solr/shared/test-solr.xml (SOLR-3112),
> but now we have a second file (core/src/test-files/solr/conf/elevate-data-distrib.xml).
> So I think hudson needs to chmod these src directories to 555, so that solr tests that do this will fail.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org