You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/11/16 10:39:57 UTC

[GitHub] [incubator-nuttx] eenurkka opened a new pull request #4839: mpfs: emmcsd: boost waitresponse perf

eenurkka opened a new pull request #4839:
URL: https://github.com/apache/incubator-nuttx/pull/4839


   When waiting for a response to a sent command, the command
   complete bit (MPFS_EMMCSD_SRS12_CC) should always guarantee
   the completion of that particular command. There's no need
   to have some combinations skipping the check of the command
   complete bit. Thus, remove the 'waitbits' parameter as it's
   unnecessary.
   
   Signed-off-by: Eero Nurkkala <ee...@offcode.fi>
   
   ## Summary
   
   Fix to cppcheck finding at f8832f7d86ddd0c77f40cc7523d096fcafbc4e60 caused regression. Some commands now timeout because waitbits is different.
   
   ## Impact
   
   Fix the regression properly.
   
   ## Testing
   
   Tested on PolarFire Icicle board with both eMMC and SD-cards. FAT filesystems were mounted and used.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #4839: mpfs: emmcsd: boost waitresponse perf

Posted by GitBox <gi...@apache.org>.

xiaoxiang781216 merged pull request #4839:
URL: https://github.com/apache/incubator-nuttx/pull/4839


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org