[GitHub] [incubator-pinot] reallocf commented on a change in pull request #5326: Update FunctionRegistry to avoid static initialization (#5313)

[GitBox <gi...@apache.org>]

reallocf commented on a change in pull request #5326:
URL: https://github.com/apache/incubator-pinot/pull/5326#discussion_r419031711



##########
File path: pinot-core/src/main/java/org/apache/pinot/core/data/function/FunctionRegistry.java
##########
@@ -18,36 +18,26 @@
  */
 package org.apache.pinot.core.data.function;
 
-import com.google.common.base.Preconditions;
 import java.lang.reflect.Method;
-import java.lang.reflect.Modifier;
 import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 
 
 /**
  * Registry for inbuilt Pinot functions
  */
 public class FunctionRegistry {

Review comment:
       Thoughts on changing the name of this to `DefaultFunctionRegistry` now that it only applies to the DefaultFunctionEvaluator?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org