You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Matthias Pohl (Jira)" <ji...@apache.org> on 2023/10/13 13:08:00 UTC
[jira] [Comment Edited] (FLINK-33252) LicenseChecker fails in GHA but succeeds in Azure
[ https://issues.apache.org/jira/browse/FLINK-33252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774899#comment-17774899 ]
Matthias Pohl edited comment on FLINK-33252 at 10/13/23 1:07 PM:
-----------------------------------------------------------------
Updating the hadoop version (as suggested by [~chesnay]) didn't help (but should have been the fix). The step still fails. I couldn't reproduce it locally until I noticed that I have Maven 3.6.3 installed but GHA uses the Maven wrapper (i.e. 3.8.6). Switching to the Maven wrapper helped me reproduce it locally.
With Maven 3.8.6 {{fs.hadoopshaded.version}} isn't used for overwriting the hadoop dependency version which then clashes with the version that's listed in the NOTICE file.
Strangely though, we don't run into the same issue with AzureCI where we use the Maven wrapper as well but the step doesn't fail.
was (Author: mapohl):
Updating the hadoop version (as suggested by [~chesnay]) didn't help. The step still fails. I couldn't reproduce it locally until I noticed that I have Maven 3.6.3 installed but GHA uses the Maven wrapper (i.e. 3.8.6). Switching to the Maven wrapper helped me reproduce it locally.
With Maven 3.8.6 {{fs.hadoopshaded.version}} isn't used for overwriting the hadoop dependency version which then clashes with the version that's listed in the NOTICE file.
Strangely though, we don't run into the same issue with AzureCI where we use the Maven wrapper as well but the step doesn't fail.
> LicenseChecker fails in GHA but succeeds in Azure
> -------------------------------------------------
>
> Key: FLINK-33252
> URL: https://issues.apache.org/jira/browse/FLINK-33252
> Project: Flink
> Issue Type: Sub-task
> Components: Build System / CI
> Reporter: Matthias Pohl
> Assignee: Matthias Pohl
> Priority: Major
>
> Both builds are based on [master@011b6b44|https://github.com/apache/flink/commit/011b6b44]:
> * [GitHub Actions|https://github.com/XComp/flink/actions/runs/6487689661/job/17620650207#step:8:41307]
> * [Azure CI|https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=53624&view=logs&j=52b61abe-a3cc-5bde-cc35-1bbe89bb7df5&t=54421a62-0c80-5aad-3319-094ff69180bb&l=43193]
> The GitHub Actions run reports 12 severe issues where it's unclear where they are coming from:
> {code:java}
> 23:30:45,534 WARN org.apache.flink.tools.ci.licensecheck.LicenseChecker [] - Found a total of 12 severe license issues {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)