[GitHub] [accumulo] harjitdotsingh commented on a change in pull request #2228: Fixes for #2203

[GitBox <gi...@apache.org>]

harjitdotsingh commented on a change in pull request #2228:
URL: https://github.com/apache/accumulo/pull/2228#discussion_r686263662



##########
File path: server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java
##########
@@ -748,24 +735,27 @@ private String getRootUserName(SiteConfiguration siteConfig, Opts opts) throws I
     if (opts.cliPassword != null) {
       return opts.cliPassword.getBytes(UTF_8);
     }
-    String rootpass;
-    String confirmpass;
+    char[] rootpass;
+    char[] confirmpass;
+    String strrootpass;
+    String strconfirmpass;
     do {
-      rootpass = getLineReader().readLine(
-          "Enter initial password for " + rootUser + getInitialPasswordWarning(siteConfig), '*');
+      rootpass = System.console().readPassword(
+          "Enter initial password for " + rootUser + getInitialPasswordWarning(siteConfig));
       if (rootpass == null) {
         System.exit(0);
       }
-      confirmpass =
-          getLineReader().readLine("Confirm initial password for " + rootUser + ": ", '*');
+      confirmpass = System.console().readPassword("Confirm initial password for " + rootUser + ":");
       if (confirmpass == null) {
         System.exit(0);
       }
-      if (!rootpass.equals(confirmpass)) {
+      strrootpass = new String(rootpass);
+      strconfirmpass = new String(confirmpass);
+      if (!strrootpass.equals(strconfirmpass)) {
         log.error("Passwords do not match");
       }
     } while (!rootpass.equals(confirmpass));

Review comment:
       I have already fixed that




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org