You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by GitBox <gi...@apache.org> on 2020/09/21 05:49:56 UTC
[GitHub] [carbondata] ajantha-bhat opened a new pull request #3940: [CARBONDATA-3997] Fix decimal value reading issue for negative decimal numbers from presto
ajantha-bhat opened a new pull request #3940:
URL: https://github.com/apache/carbondata/pull/3940
### Why is this PR needed?
Reading negative decimal numbers gives the wrong value from presto.
### What changes were proposed in this PR?
When complex decimal column is stored with DIRECT_COMPRESS codec, DataTypeUtil#bigDecimalToByte is used to create a byte array. So, while decoding it, need to use DataTypeUtil#byteToBigDecimal to get back the proper value.
Originally added a TODO to find what is happening at write step for decimal, handled as part of this issue.
### Does this PR introduce any user interface change?
- No
### Is any new testcase added?
- Yes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] kunal642 commented on pull request #3940: [CARBONDATA-3997] Fix decimal value reading issue for negative decimal numbers from presto
Posted by GitBox <gi...@apache.org>.
kunal642 commented on pull request #3940:
URL: https://github.com/apache/carbondata/pull/3940#issuecomment-696644556
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] kumarvishal09 commented on pull request #3940: [CARBONDATA-3997] Fix decimal value reading issue for negative decimal numbers from presto
Posted by GitBox <gi...@apache.org>.
kumarvishal09 commented on pull request #3940:
URL: https://github.com/apache/carbondata/pull/3940#issuecomment-696232802
Lgtm
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] asfgit closed pull request #3940: [CARBONDATA-3997] Fix decimal value reading issue for negative decimal numbers from presto
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3940:
URL: https://github.com/apache/carbondata/pull/3940
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3940: [CARBONDATA-3997] Fix decimal value reading issue for negative decimal numbers from presto
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on pull request #3940:
URL: https://github.com/apache/carbondata/pull/3940#issuecomment-695959999
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2395/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] ajantha-bhat commented on pull request #3940: [CARBONDATA-3997] Fix decimal value reading issue for negative decimal numbers from presto
Posted by GitBox <gi...@apache.org>.
ajantha-bhat commented on pull request #3940:
URL: https://github.com/apache/carbondata/pull/3940#issuecomment-695914349
@kunal642 , @akashrn5 , @kumarvishal09 : please check and merge this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3940: [CARBONDATA-3997] Fix decimal value reading issue for negative decimal numbers from presto
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on pull request #3940:
URL: https://github.com/apache/carbondata/pull/3940#issuecomment-695962178
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4136/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3940: [CARBONDATA-3997] Fix decimal value reading issue for negative decimal numbers from presto
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on pull request #3940:
URL: https://github.com/apache/carbondata/pull/3940#issuecomment-695959999
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] kumarvishal09 commented on pull request #3940: [CARBONDATA-3997] Fix decimal value reading issue for negative decimal numbers from presto
Posted by GitBox <gi...@apache.org>.
kumarvishal09 commented on pull request #3940:
URL: https://github.com/apache/carbondata/pull/3940#issuecomment-696232802
Lgtm
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] asfgit closed pull request #3940: [CARBONDATA-3997] Fix decimal value reading issue for negative decimal numbers from presto
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3940:
URL: https://github.com/apache/carbondata/pull/3940
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] VenuReddy2103 commented on pull request #3940: [CARBONDATA-3997] Fix decimal value reading issue for negative decimal numbers from presto
Posted by GitBox <gi...@apache.org>.
VenuReddy2103 commented on pull request #3940:
URL: https://github.com/apache/carbondata/pull/3940#issuecomment-696202799
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] VenuReddy2103 commented on pull request #3940: [CARBONDATA-3997] Fix decimal value reading issue for negative decimal numbers from presto
Posted by GitBox <gi...@apache.org>.
VenuReddy2103 commented on pull request #3940:
URL: https://github.com/apache/carbondata/pull/3940#issuecomment-696202799
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] ajantha-bhat commented on pull request #3940: [CARBONDATA-3997] Fix decimal value reading issue for negative decimal numbers from presto
Posted by GitBox <gi...@apache.org>.
ajantha-bhat commented on pull request #3940:
URL: https://github.com/apache/carbondata/pull/3940#issuecomment-695914349
@kunal642 , @akashrn5 , @kumarvishal09 : please check and merge this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] kunal642 commented on pull request #3940: [CARBONDATA-3997] Fix decimal value reading issue for negative decimal numbers from presto
Posted by GitBox <gi...@apache.org>.
kunal642 commented on pull request #3940:
URL: https://github.com/apache/carbondata/pull/3940#issuecomment-696644556
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org