You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by keith2008 <gi...@git.apache.org> on 2016/08/18 08:10:17 UTC
[GitHub] trafficserver pull request #873: fix 5 bugs about parent strategy
GitHub user keith2008 opened a pull request:
https://github.com/apache/trafficserver/pull/873
fix 5 bugs about parent strategy
Fix the following bugs:
(TS-4743) parent use consistent_hash Strategy may cause crash while first parent is not set
(TS-4744) ParentConsistentHash::selectParent may select the unavailable parent
(TS-4745) pRecord.failCount not init inParentRecord::ProcessParents
(TS-4746) ParentRecord *secondary_parents malloc, but no place free,which will cause memery leak
(TS-4747) if the connection of parent is notalive, not make the parent host down,which will select the the unavailablehost again
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/keith2008/trafficserver master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/873.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #873
----
commit 977dff9849462ee6dfcbe51de89d38f47837fff8
Author: keith2008 <56...@qq.com>
Date: 2016-08-18T06:37:06Z
Update ParentSelection.cc
commit 7ac6299ecb9b8365a5de5d6620a302c3df07909a
Author: keith2008 <56...@qq.com>
Date: 2016-08-18T06:42:05Z
Update HttpTransact.cc
(TS-4747) if the connection of parent is notalive, not make the parent host down,which will select the the unavailablehost again
commit 473ed61b89c764be909a91c79dc0c84333bc75aa
Author: keith2008 <56...@qq.com>
Date: 2016-08-18T06:46:02Z
Update ParentConsistentHash.cc
(TS-4744) ParentConsistentHash::selectParent mayselect the unavailable parent
commit cb1c56debd53287a54f52410193cd35bcf0f7c53
Author: keith2008 <56...@qq.com>
Date: 2016-08-18T06:56:21Z
Update ParentSelection.cc
(TS-4746) ParentRecord *secondary_parentsmalloc,but no place free,which will cause memery leak
commit 8fcfc0a060e42995318e9c0c7abac7981446eb46
Author: keith2008 <56...@qq.com>
Date: 2016-08-18T07:31:44Z
Update ParentConsistentHash.cc
commit ef555fe77fc13bd613e83809b43b7cb5a5caa8fe
Author: keith2008 <56...@qq.com>
Date: 2016-08-18T07:35:59Z
Update ParentSelection.cc
commit d8eee07022d50588d92f3faf252493b478810bb8
Author: keith2008 <56...@qq.com>
Date: 2016-08-18T07:49:45Z
Update ParentConsistentHash.cc
(TS-4743) parent use consistent_hash Strategy may cause crash while first parent is not set
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #873: fix 5 bugs about parent strategy
Posted by jrushford <gi...@git.apache.org>.
Github user jrushford commented on the issue:
https://github.com/apache/trafficserver/pull/873
@keith2008 Can you break these commits up into individual PR's for each issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #873: fix 5 bugs about parent strategy
Posted by keith2008 <gi...@git.apache.org>.
Github user keith2008 commented on the issue:
https://github.com/apache/trafficserver/pull/873
@jrushford @zwoop OK,i have closed this pull. if you have time, please review my code on: https://github.com/keith2008/trafficserver
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #873: fix 5 bugs about parent strategy
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/873
Is it possible to break this up into individual PRs for each Jira? Or are they interleaved? Also, please make the commit messages include each Jira in the Summary, and also, we prefer one commit per Jira when possible (but, you can break them up into 2 or more when appropriate).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #873: fix 5 bugs about parent strategy
Posted by keith2008 <gi...@git.apache.org>.
Github user keith2008 closed the pull request at:
https://github.com/apache/trafficserver/pull/873
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #873: fix 5 bugs about parent strategy
Posted by jrushford <gi...@git.apache.org>.
Github user jrushford commented on the issue:
https://github.com/apache/trafficserver/pull/873
I'm +1 on the changes but it might be better to create individual PR's and squash the two committs for TS-4746 due to misspelling of secondary_parents.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #873: fix 5 bugs about parent strategy
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/873
Yeh, I think we should break this up before reviewing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---