You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/27 06:50:53 UTC
[GitHub] [superset] iercan opened a new pull request #12787: fix: uuid generatiion for mysql fixed
iercan opened a new pull request #12787:
URL: https://github.com/apache/superset/pull/12787
### SUMMARY
UUID generation fixed according to suggestion of @betodealmeida
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [X] Has associated issue: #12728 #12202
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12787: fix: uuid generation for mysql fixed
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12787:
URL: https://github.com/apache/superset/pull/12787#issuecomment-768099344
# [Codecov](https://codecov.io/gh/apache/superset/pull/12787?src=pr&el=h1) Report
> Merging [#12787](https://codecov.io/gh/apache/superset/pull/12787?src=pr&el=desc) (58ac410) into [master](https://codecov.io/gh/apache/superset/commit/e8857bac04e8d7b7840c4e603820a6bc34c052bd?el=desc) (e8857ba) will **decrease** coverage by `3.09%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12787?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12787 +/- ##
==========================================
- Coverage 66.88% 63.79% -3.10%
==========================================
Files 1021 488 -533
Lines 50015 30117 -19898
Branches 4907 0 -4907
==========================================
- Hits 33455 19214 -14241
+ Misses 16435 10903 -5532
+ Partials 125 0 -125
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.79% <ø> (-0.30%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12787?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ns/b56500de1855\_add\_uuid\_column\_to\_import\_mixin.py](https://codecov.io/gh/apache/superset/pull/12787/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9iNTY1MDBkZTE4NTVfYWRkX3V1aWRfY29sdW1uX3RvX2ltcG9ydF9taXhpbi5weQ==) | `0.00% <ø> (ø)` | |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12787/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12787/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12787/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12787/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12787/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `84.78% <0.00%> (-4.35%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12787/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12787/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.86% <0.00%> (-2.99%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12787/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `72.93% <0.00%> (-2.46%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12787/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `89.79% <0.00%> (-2.05%)` | :arrow_down: |
| ... and [541 more](https://codecov.io/gh/apache/superset/pull/12787/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12787?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12787?src=pr&el=footer). Last update [e8857ba...58ac410](https://codecov.io/gh/apache/superset/pull/12787?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io commented on pull request #12787: fix: uuid generation for mysql fixed
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12787:
URL: https://github.com/apache/superset/pull/12787#issuecomment-768099344
# [Codecov](https://codecov.io/gh/apache/superset/pull/12787?src=pr&el=h1) Report
> Merging [#12787](https://codecov.io/gh/apache/superset/pull/12787?src=pr&el=desc) (58ac410) into [master](https://codecov.io/gh/apache/superset/commit/e8857bac04e8d7b7840c4e603820a6bc34c052bd?el=desc) (e8857ba) will **decrease** coverage by `3.48%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12787?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12787 +/- ##
==========================================
- Coverage 66.88% 63.40% -3.49%
==========================================
Files 1021 488 -533
Lines 50015 30102 -19913
Branches 4907 0 -4907
==========================================
- Hits 33455 19085 -14370
+ Misses 16435 11017 -5418
+ Partials 125 0 -125
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.40% <ø> (-0.70%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12787?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ns/b56500de1855\_add\_uuid\_column\_to\_import\_mixin.py](https://codecov.io/gh/apache/superset/pull/12787/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9iNTY1MDBkZTE4NTVfYWRkX3V1aWRfY29sdW1uX3RvX2ltcG9ydF9taXhpbi5weQ==) | `0.00% <ø> (ø)` | |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12787/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/12787/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.69% <0.00%> (-24.88%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12787/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12787/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/superset/pull/12787/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/12787/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `79.59% <0.00%> (-6.38%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12787/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.25% <0.00%> (-6.28%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12787/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/superset/pull/12787/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `83.33% <0.00%> (-5.56%)` | :arrow_down: |
| ... and [552 more](https://codecov.io/gh/apache/superset/pull/12787/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12787?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12787?src=pr&el=footer). Last update [e8857ba...58ac410](https://codecov.io/gh/apache/superset/pull/12787?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #12787: fix: uuid generation for mysql fixed
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #12787:
URL: https://github.com/apache/superset/pull/12787#issuecomment-768091177
@iercan ok perfect, thanks for confirming!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] iercan commented on pull request #12787: fix: uuid generation for mysql fixed
Posted by GitBox <gi...@apache.org>.
iercan commented on pull request #12787:
URL: https://github.com/apache/superset/pull/12787#issuecomment-768090255
@villebro Our superset metastore already use utf8mb4. So to be sure I run below query with another database that have latin1 charset and It didn't give any error.
`SELECT UNHEX(REPLACE(CONVERT(UUID() using utf8mb4), '-', '')) from <anytable> limit 10;`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] iercan commented on pull request #12787: fix: uuid generation for mysql fixed
Posted by GitBox <gi...@apache.org>.
iercan commented on pull request #12787:
URL: https://github.com/apache/superset/pull/12787#issuecomment-768092902
> @villebro I will also test with UPDATE query and inform result.
It worked as well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] iercan removed a comment on pull request #12787: fix: uuid generation for mysql fixed
Posted by GitBox <gi...@apache.org>.
iercan removed a comment on pull request #12787:
URL: https://github.com/apache/superset/pull/12787#issuecomment-768082972
@betodealmeida
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro merged pull request #12787: fix: uuid generation for mysql fixed
Posted by GitBox <gi...@apache.org>.
villebro merged pull request #12787:
URL: https://github.com/apache/superset/pull/12787
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #12787: fix: uuid generation for mysql fixed
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #12787:
URL: https://github.com/apache/superset/pull/12787#issuecomment-768091506
FYI tagging this for Superset v1.0.1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] iercan commented on pull request #12787: fix: uuid generation for mysql fixed
Posted by GitBox <gi...@apache.org>.
iercan commented on pull request #12787:
URL: https://github.com/apache/superset/pull/12787#issuecomment-768091761
@villebro I will also test with UPDATE query and inform result.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] iercan commented on pull request #12787: fix: uuid generation for mysql fixed
Posted by GitBox <gi...@apache.org>.
iercan commented on pull request #12787:
URL: https://github.com/apache/superset/pull/12787#issuecomment-768082972
@betodealmeida
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org