You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/12/22 18:43:15 UTC

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6375: make MAX_NUM_THREADS_PER_QUERY configurable for pinto server

mayankshriv commented on a change in pull request #6375:
URL: https://github.com/apache/incubator-pinot/pull/6375#discussion_r547443037



##########
File path: pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java
##########
@@ -236,7 +236,7 @@ public void testRefreshTableConfigAndQueryTimeout()
       throws Exception {
     // Set timeout as 5ms so that query will timeout
     TableConfig tableConfig = getOfflineTableConfig();
-    tableConfig.setQueryConfig(new QueryConfig(5L));
+    tableConfig.setQueryConfig(new QueryConfig(5L, 2));

Review comment:
       This seems like a change from current behavior. Any reason why we want to constrain the number of cores to be used to 2 for integration tests? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org