Re: [PR] chore: update verify_rc script to verify tag against tarball [iceberg-rust]

["blackmwk (via GitHub)" <gi...@apache.org>]

blackmwk commented on code in PR #2760:
URL: https://github.com/apache/iceberg-rust/pull/2760#discussion_r3518120076


##########
dev/release/verify_rc.sh:
##########
@@ -364,6 +386,38 @@ extract_source_archive() {
   tar -xzf "${ARCHIVE_FILE_NAME}"
 }
 
+verify_git_tag_matches_archive() {
+  require_command git
+  require_command tar
+  require_command diff
+
+  local tag_checkout_dir="git-tag-checkout"
+  local tag_archive_dir="git-tag-archive"
+  local tag_archive_file="git-tag-source.tar.gz"
+
+  rm -rf "${tag_checkout_dir}" "${tag_archive_dir}" "${tag_archive_file}"

Review Comment:
   I prefer not to execute such remove operation. Since all  checks happens in the tmp_dir, I think it would be safe to assert that these dirs are not exist.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org