You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2022/03/07 21:58:23 UTC

[GitHub] [jackrabbit-oak] mattvryan commented on a change in pull request #510: OAK-9713 sas uri support in oak-upgrade

mattvryan commented on a change in pull request #510:
URL: https://github.com/apache/jackrabbit-oak/pull/510#discussion_r821138015



##########
File path: oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureUtilities.java
##########
@@ -116,6 +116,12 @@ public static CloudBlobDirectory cloudBlobDirectoryFrom(String connection, Strin
 
         return container.getDirectoryReference(dir);
     }
+    public static CloudBlobDirectory cloudBlobDirectoryFromSasUri(String connection, String containerName,

Review comment:
       I'm concerned about this.  How accessible is this method?  In particular, is it exported so that it can be called outside the bundle?  I worry about security implications - it's giving access to cloud storage based on any valid connection string passed in to the method.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org