You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/08/22 03:41:56 UTC

[GitHub] feng-tao commented on a change in pull request #3740: [AIRFLOW-2888] Remove shell=True and bash from task launch

feng-tao commented on a change in pull request #3740: [AIRFLOW-2888] Remove shell=True and bash from task launch
URL: https://github.com/apache/incubator-airflow/pull/3740#discussion_r211821195
 
 

 ##########
 File path: airflow/executors/celery_executor.py
 ##########
 @@ -84,7 +84,7 @@ def execute_async(self, key, command,
         self.log.info("[celery] queuing {key} through celery, "
                       "queue={queue}".format(**locals()))
         self.tasks[key] = execute_command.apply_async(
-            args=[command], queue=queue)
+            args=command, queue=queue)
 
 Review comment:
   @YingboWang , good find. Do you want to create a pr for this issue?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services