You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@httpd.apache.org by bu...@apache.org on 2018/05/03 02:50:41 UTC
[Bug 62347] New: wrong error assignmemt
https://bz.apache.org/bugzilla/show_bug.cgi?id=62347
Bug ID: 62347
Summary: wrong error assignmemt
Product: Apache httpd-2
Version: 2.4.29
Hardware: PC
OS: Mac OS X 10.1
Status: NEW
Severity: normal
Priority: P2
Component: mod_dav_fs
Assignee: bugs@httpd.apache.org
Reporter: scu.bjwu@gmail.com
Target Milestone: ---
In function dav_fs_get_parent_resource(), all the return values are NULL.
However, it seems like this if-condition below indicates an error path:
if ((tv != APR_SUCESS && rv != APR_ERELATIVE) || !testpath || !*testpah) {
*result_parent = NULL;
return NULL;
}
Should we return some value (dav_error) to indicate this situation?
Thanks.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 62347] wrong error assignmemt
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62347
Christophe JAILLET <ch...@wanadoo.fr> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |INVALID
--- Comment #2 from Christophe JAILLET <ch...@wanadoo.fr> ---
Closed because of lack of activity on this report.
There is no evidence of a bug here.
Feel free to re-open if needed.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 62347] wrong error assignmemt
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62347
--- Comment #1 from Christophe JAILLET <ch...@wanadoo.fr> ---
The comment before this test is:
> /* If given resource is root, then there is no parent.
> * Unless we can retrieve the filepath root, this is
> * intendend to fail. If we split the root and
> * no path info remains, then we also fail.
> */
I don't know this part of the code well enough, but the comment looks in line
with the code.
Why do you think an error should be returned? Can you elaborate?
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org