You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "codecov[bot] (via GitHub)" <gi...@apache.org> on 2023/07/13 03:45:21 UTC
[GitHub] [superset] codecov[bot] commented on pull request #24677: refactor(sqllab): Replace autocomplete logic by a hook
codecov[bot] commented on PR #24677:
URL: https://github.com/apache/superset/pull/24677#issuecomment-1633502148
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24677?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24677](https://app.codecov.io/gh/apache/superset/pull/24677?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (dcda886) into [master](https://app.codecov.io/gh/apache/superset/commit/1473d9705569d45a3fd6b962e5530d45d43cecc5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (1473d97) will **decrease** coverage by `0.05%`.
> The diff coverage is `87.23%`.
> :exclamation: Current head dcda886 differs from pull request most recent head 8c41dde. Consider uploading reports for the commit 8c41dde to get more accurate results
```diff
@@ Coverage Diff @@
## master #24677 +/- ##
==========================================
- Coverage 69.03% 68.98% -0.05%
==========================================
Files 1908 1903 -5
Lines 74197 74013 -184
Branches 8186 8184 -2
==========================================
- Hits 51219 51058 -161
+ Misses 20857 20837 -20
+ Partials 2121 2118 -3
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `55.73% <76.66%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24677?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://app.codecov.io/gh/apache/superset/pull/24677?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <ø> (ø)` | |
| [superset-frontend/src/hooks/apiResources/tables.ts](https://app.codecov.io/gh/apache/superset/pull/24677?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2hvb2tzL2FwaVJlc291cmNlcy90YWJsZXMudHM=) | `73.80% <ø> (ø)` | |
| [superset/reports/commands/exceptions.py](https://app.codecov.io/gh/apache/superset/pull/24677?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `98.33% <ø> (-0.03%)` | :arrow_down: |
| [superset/views/database/forms.py](https://app.codecov.io/gh/apache/superset/pull/24677?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `93.67% <ø> (ø)` | |
| [superset/annotation\_layers/api.py](https://app.codecov.io/gh/apache/superset/pull/24677?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `86.20% <50.00%> (-0.12%)` | :arrow_down: |
| [superset/css\_templates/commands/delete.py](https://app.codecov.io/gh/apache/superset/pull/24677?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvY3NzX3RlbXBsYXRlcy9jb21tYW5kcy9kZWxldGUucHk=) | `87.50% <50.00%> (ø)` | |
| [superset/queries/saved\_queries/commands/delete.py](https://app.codecov.io/gh/apache/superset/pull/24677?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `87.50% <50.00%> (ø)` | |
| [superset/row\_level\_security/commands/delete.py](https://app.codecov.io/gh/apache/superset/pull/24677?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvcm93X2xldmVsX3NlY3VyaXR5L2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `86.36% <50.00%> (ø)` | |
| [...t-frontend/src/components/AsyncAceEditor/index.tsx](https://app.codecov.io/gh/apache/superset/pull/24677?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNBY2VFZGl0b3IvaW5kZXgudHN4) | `91.66% <63.63%> (+0.55%)` | :arrow_up: |
| [superset/annotation\_layers/annotations/api.py](https://app.codecov.io/gh/apache/superset/pull/24677?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvYXBpLnB5) | `89.23% <66.66%> (-0.09%)` | :arrow_down: |
| ... and [25 more](https://app.codecov.io/gh/apache/superset/pull/24677?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [3 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24677/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org