[GitHub] mayya-sharipova commented on issue #793: Allow libs in other design doc sections besides views

[gi...@git.apache.org]

mayya-sharipova commented on issue #793: Allow libs in other design doc sections besides views
URL: https://github.com/apache/couchdb/pull/793#issuecomment-327515148
 
 
   +1 
   Well written code, and comprehensive tests.
   
   I have tested on this ddoc for filters in `_changes` feed.  Everything worked well as expected:
   
   ```json
   {
       "_id":"_design/f1",
       "whatever" : {
           "commonjs" : {
                   "fun1" : "exports.res1 = true",
                   "fun2" : "exports.res2 = false"
           }
       },
       "filters": {
           "ff1": "function (doc, req) {
                 if (doc.year > 2014){
                     return require('whatever/commonjs/fun1').res1;
                 } 
                 return require('whatever/commonjs/fun2').res2;
            }"
       }
   }
   ```
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services