You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by be...@apache.org on 2025/01/09 20:35:48 UTC
(lucene) 04/04: Use CDL to block threads to avoid flaky tests. (#14116)
This is an automated email from the ASF dual-hosted git repository.
benwtrent pushed a commit to branch branch_10x
in repository https://gitbox.apache.org/repos/asf/lucene.git
commit 1667165759c22516b54db62c3fe7f28f214161c6
Author: Ao Li <55...@users.noreply.github.com>
AuthorDate: Thu Jan 9 15:28:01 2025 -0500
Use CDL to block threads to avoid flaky tests. (#14116)
* Use CDL to block threads to avoid flaky tests.
* Update CHANGES.txt
---
lucene/CHANGES.txt | 3 +++
.../apache/lucene/index/TestConcurrentMergeScheduler.java | 12 ++++++++----
2 files changed, 11 insertions(+), 4 deletions(-)
diff --git a/lucene/CHANGES.txt b/lucene/CHANGES.txt
index d568a00e8e9..d8d3e51ed1e 100644
--- a/lucene/CHANGES.txt
+++ b/lucene/CHANGES.txt
@@ -36,8 +36,11 @@ Bug Fixes
Other
---------------------
+
* GITHUB#14081: Fix urls describing why NIOFS is not recommended for Windows (Marcel Yeonghyeon Ko)
+* GITHUB#14116 Use CDL to block threads to avoid flaky tests. (Ao Li)
+
======================= Lucene 10.1.0 =======================
API Changes
diff --git a/lucene/core/src/test/org/apache/lucene/index/TestConcurrentMergeScheduler.java b/lucene/core/src/test/org/apache/lucene/index/TestConcurrentMergeScheduler.java
index e0b2c49d854..fcf42177570 100644
--- a/lucene/core/src/test/org/apache/lucene/index/TestConcurrentMergeScheduler.java
+++ b/lucene/core/src/test/org/apache/lucene/index/TestConcurrentMergeScheduler.java
@@ -418,7 +418,6 @@ public class TestConcurrentMergeScheduler extends LuceneTestCase {
dir.close();
}
- @SuppressForbidden(reason = "Thread sleep")
public void testIntraMergeThreadPoolIsLimitedByMaxThreads() throws IOException {
ConcurrentMergeScheduler mergeScheduler = new ConcurrentMergeScheduler();
MergeScheduler.MergeSource mergeSource =
@@ -475,11 +474,12 @@ public class TestConcurrentMergeScheduler extends LuceneTestCase {
Executor executor = mergeScheduler.intraMergeExecutor;
AtomicInteger threadsExecutedOnPool = new AtomicInteger();
AtomicInteger threadsExecutedOnSelf = new AtomicInteger();
- for (int i = 0; i < 4; i++) {
+ CountDownLatch latch = new CountDownLatch(1);
+ final int totalThreads = 4;
+ for (int i = 0; i < totalThreads; i++) {
mergeScheduler.mergeThreads.add(
mergeScheduler.new MergeThread(mergeSource, merge) {
@Override
- @SuppressForbidden(reason = "Thread sleep")
public void run() {
executor.execute(
() -> {
@@ -489,7 +489,7 @@ public class TestConcurrentMergeScheduler extends LuceneTestCase {
threadsExecutedOnPool.incrementAndGet();
}
try {
- Thread.sleep(100);
+ latch.await();
} catch (InterruptedException e) {
throw new RuntimeException(e);
}
@@ -500,6 +500,10 @@ public class TestConcurrentMergeScheduler extends LuceneTestCase {
for (ConcurrentMergeScheduler.MergeThread thread : mergeScheduler.mergeThreads) {
thread.start();
}
+ while (threadsExecutedOnSelf.get() + threadsExecutedOnPool.get() < totalThreads) {
+ Thread.yield();
+ }
+ latch.countDown();
mergeScheduler.sync();
assertEquals(3, threadsExecutedOnSelf.get());
assertEquals(1, threadsExecutedOnPool.get());