You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/06/24 08:46:23 UTC
[GitHub] [iotdb] lausannel opened a new pull request #3448: add client csharp
lausannel opened a new pull request #3448:
URL: https://github.com/apache/iotdb/pull/3448
## Support IoTDB client for CSharp
<!--
In each section, please describe design decisions made, including:
- Choice of algorithms
- Behavioral aspects. What configuration values are acceptable? How are corner cases and error
conditions handled, such as when there are insufficient resources?
- Class organization and design (how the logic is split between classes, inheritance, composition,
design patterns)
- Method organization and design (how the logic is split between methods, parameters and return types)
- Naming (class, method, API, configuration, HTTP endpoint, names of emitted metrics)
-->
<!-- It's good to describe an alternative design (or mention an alternative name) for every design
(or naming) decision point and compare the alternatives with the designs that you've implemented
(or the names you've chosen) to highlight the advantages of the chosen designs and names. -->
<!-- If there was a discussion of the design of the feature implemented in this PR elsewhere
(e. g. a "Proposal" issue, any other issue, or a thread in the development mailing list),
link to that discussion from this PR description and explain what have changed in your final design
compared to your original proposal or the consensus version in the end of the discussion.
If something hasn't changed since the original discussion, you can omit a detailed discussion of
those aspects of the design here, perhaps apart from brief mentioning for the sake of readability
of this PR description. -->
<!-- Some of the aspects mentioned above may be omitted for simple and small changes. -->
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items
apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items
from the checklist above are strictly necessary, but it would be very helpful if you at least
self-review the PR. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #3448: [IOTDB-1261] add client csharp
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3448:
URL: https://github.com/apache/iotdb/pull/3448#issuecomment-867499340
[](https://coveralls.io/builds/40845020)
Coverage increased (+0.2%) to 68.081% when pulling **eaa75555504c10686676f985af5441fdb58179b7 on lausannel:master** into **5c6d11bd7e3f4b5e842bd3a71b262be5692e2ad6 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #3448: [IOTDB-1261] add client csharp
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3448:
URL: https://github.com/apache/iotdb/pull/3448#issuecomment-867499340
[](https://coveralls.io/builds/40845261)
Coverage increased (+0.1%) to 68.037% when pulling **eaa75555504c10686676f985af5441fdb58179b7 on lausannel:master** into **5c6d11bd7e3f4b5e842bd3a71b262be5692e2ad6 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] eedalong removed a comment on pull request #3448: [IOTDB-1261] add client csharp
Posted by GitBox <gi...@apache.org>.
eedalong removed a comment on pull request #3448:
URL: https://github.com/apache/iotdb/pull/3448#issuecomment-867654446
> Coverage increased (+0.1%) to 68.037% when pulling **[eaa7555](https://github.com/apache/iotdb/commit/eaa75555504c10686676f985af5441fdb58179b7) on lausannel:master** into **[5c6d11b](https://github.com/apache/iotdb/commit/5c6d11bd7e3f4b5e842bd3a71b262be5692e2ad6) on apache:master**.
so, what does this actually mean
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls commented on pull request #3448: [IOTDB-1261] add client csharp
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #3448:
URL: https://github.com/apache/iotdb/pull/3448#issuecomment-867499340
[](https://coveralls.io/builds/40844445)
Coverage increased (+0.2%) to 68.063% when pulling **eaa75555504c10686676f985af5441fdb58179b7 on lausannel:master** into **5c6d11bd7e3f4b5e842bd3a71b262be5692e2ad6 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu commented on pull request #3448: [IOTDB-1261] add client csharp
Posted by GitBox <gi...@apache.org>.
SteveYurongSu commented on pull request #3448:
URL: https://github.com/apache/iotdb/pull/3448#issuecomment-877905869
Add an auto lint tool and some build scripts for the PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #3448: [IOTDB-1261] add client csharp
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3448:
URL: https://github.com/apache/iotdb/pull/3448#issuecomment-867499340
[](https://coveralls.io/builds/40881487)
Coverage increased (+0.2%) to 68.078% when pulling **b4eb1de2d469656abdbd6e090ce10aeb9283da82 on lausannel:master** into **5c6d11bd7e3f4b5e842bd3a71b262be5692e2ad6 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] eedalong commented on pull request #3448: [IOTDB-1261] add client csharp
Posted by GitBox <gi...@apache.org>.
eedalong commented on pull request #3448:
URL: https://github.com/apache/iotdb/pull/3448#issuecomment-867654446
> Coverage increased (+0.1%) to 68.037% when pulling **[eaa7555](https://github.com/apache/iotdb/commit/eaa75555504c10686676f985af5441fdb58179b7) on lausannel:master** into **[5c6d11b](https://github.com/apache/iotdb/commit/5c6d11bd7e3f4b5e842bd3a71b262be5692e2ad6) on apache:master**.
so, what does this actually mean
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #3448: [IOTDB-1261] add client csharp
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3448:
URL: https://github.com/apache/iotdb/pull/3448#issuecomment-867499340
[](https://coveralls.io/builds/40895636)
Coverage increased (+0.1%) to 68.018% when pulling **b9b25daa677787db7f9c2427143be914d1000139 on lausannel:master** into **5c6d11bd7e3f4b5e842bd3a71b262be5692e2ad6 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org