You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/03/17 21:49:41 UTC

[jira] [Commented] (SAMZA-1094) Removal of MessageEnvelope class from the top-level API

    [ https://issues.apache.org/jira/browse/SAMZA-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15930789#comment-15930789 ] 

ASF GitHub Bot commented on SAMZA-1094:
---------------------------------------

GitHub user prateekm opened a pull request:

    https://github.com/apache/samza/pull/92

    SAMZA-1094, SAMZA-1101: Remove MessageEnvelope from public operator APIs. Delay the creation of SinkFunction for output streams.

    Additionally,
    1. Removed references to StreamGraph in OperatorSpecs. It was being used to getNextOpId(). MessageStreamsImpl now gets the ID and gives it to OperatorSpecs itself.
    2. Updated and cleaned up the StreamGraphBuilder examples.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/prateekm/samza message-envelope-removal

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/92.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #92
    
----
commit 67978a18c8e40700b7a1fb9bfba141417b8b3c7e
Author: Prateek Maheshwari <pm...@linkedin.com>
Date:   2017-03-17T21:32:52Z

    SAMZA-1094, SAMZA-1101: Remove MessageEnvelope from public operator APIs. Delay the creation of SinkFunction for output streams.

----


> Removal of MessageEnvelope class from the top-level API
> -------------------------------------------------------
>
>                 Key: SAMZA-1094
>                 URL: https://issues.apache.org/jira/browse/SAMZA-1094
>             Project: Samza
>          Issue Type: Bug
>            Reporter: Yi Pan (Data Infrastructure)
>
> After SAMZA-1073 has removed the MessageEnvelope as the bounded type parameter to MessageStream, the only usage of MessageEnvelope class is mainly at ingress and egress streams of a graph.
> However, w/ further functions to do the following:
> a) extract a key from an unbound type M
> b) extract a message body from an unbound type M
> c) re-construct an unbound type M from an IncomingMessageEnvelope
> It would be possible to remove the interface class MessageEnvelope all together from the API.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)