You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/10/06 19:13:21 UTC
[GitHub] [accumulo] ctubbsii commented on a diff in pull request #3000: add log4j-core for test logging
ctubbsii commented on code in PR #3000:
URL: https://github.com/apache/accumulo/pull/3000#discussion_r989398733
##########
test/pom.xml:
##########
@@ -220,6 +220,11 @@
<artifactId>accumulo-iterator-test-harness</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-core</artifactId>
+ <scope>test</scope>
+ </dependency>
Review Comment:
This should already be on the class path. It's brought in transitively through accumulo-monitor, and we shouldn't have any direct dependencies on it, only transitive runtime dependencies on it. The test module has a direct dependency on the accumulo-monitor.
Ultimately, this should be fixed by 2.19.1, which should re-add the transitive dependency for log4j-slf4j2-impl (https://issues.apache.org/jira/browse/LOG4J2-3601), but it hasn't been done yet, and some of the devs seemed confused about why they needed to fix that. So, I don't know when it will happen.
If this helps fix something during testing in an IDE, I'm fine with adding it. It's not going to hurt.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org