You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/04 23:10:37 UTC
[GitHub] [incubator-nuttx] patacongo opened a new pull request #432:
sched/group/group_setuptaskfiles.c: Fix bad file inclusion.
patacongo opened a new pull request #432: sched/group/group_setuptaskfiles.c: Fix bad file inclusion.
URL: https://github.com/apache/incubator-nuttx/pull/432
commit d07afc934e272cbbd63e355d9e12db333b2e2978, "fcntl: add O_CLOEXEC/FD_CLOEXEC support" introduce a compilation error .. a bad file inclusion. That commit added an unnecessary inclusion of "socket/socket.h" which is NOT available in the sched sub-directory. It is only available under the net/ sub-directory.
There is no include path for such and inclusion and there must NEVER be such a include path. Module design forbids including header files between diffent "silos" in the design. Nothing under net/ can ever be available to logic under sched/.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] Ouss4 merged pull request #432:
sched/group/group_setuptaskfiles.c: Fix bad file inclusion.
Posted by GitBox <gi...@apache.org>.
Ouss4 merged pull request #432: sched/group/group_setuptaskfiles.c: Fix bad file inclusion.
URL: https://github.com/apache/incubator-nuttx/pull/432
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services