[GitHub] [ozone] aswinshakil commented on a change in pull request #2522: HDDS-5554. Option to disable checksum verification.

[GitBox <gi...@apache.org>]

aswinshakil commented on a change in pull request #2522:
URL: https://github.com/apache/ozone/pull/2522#discussion_r686963320



##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/helpers/KeyValueContainerUtil.java
##########
@@ -169,7 +169,7 @@ public static void parseKVContainerData(KeyValueContainerData kvContainerData,
     File metadataPath = new File(kvContainerData.getMetadataPath());
 
     // Verify Checksum
-    ContainerUtils.verifyChecksum(kvContainerData);
+    ContainerUtils.verifyChecksum(kvContainerData, config);

Review comment:
       I thought the checksum verification enable/ disable can be inside the verifychecksum function, so that every time we invoke the function we don't have to enable/disable outside the function call. What are your thoughts on that?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org