[jira] [Commented] (HBASE-15955) Disable action in CatalogJanitor#setEnabled should wait for active cleanup scan to finish

["Ted Yu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-15955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15314681#comment-15314681 ] 

Ted Yu commented on HBASE-15955:
--------------------------------

enableCatalogJanitor() used to be asynchronous.

Should we default to being asynchronous and add another flag to designate the call to be synchronous ?

> Disable action in CatalogJanitor#setEnabled should wait for active cleanup scan to finish
> -----------------------------------------------------------------------------------------
>
>                 Key: HBASE-15955
>                 URL: https://issues.apache.org/jira/browse/HBASE-15955
>             Project: HBase
>          Issue Type: Bug
>          Components: master
>    Affects Versions: 1.0.0, 2.0.0
>            Reporter: Stephen Yuan Jiang
>            Assignee: Stephen Yuan Jiang
>         Attachments: HBASE-15955.master-v1.patch
>
>
> When user calls Admin.enableCatalogJanitor(false) to disable the catalog janitor, it expects that the janitor would stop working once the API returns.  It is not true, the janitor could have an active scan going on and clean up unused region.  The 'false' state would be enforced during the next background runs.  
> To avoid confusing, if 'CatalogJanitor.enabled' is true and we want to set to false in CatalogJanitor#setEnabled, the function should wait for the on-going active scan to complete.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)