[jira] [Created] (FELIX-6571) Possible leverage of johnzon config to simplify cm.json

["Aleksy Wróblewski (Jira)" <ji...@apache.org>]

Aleksy Wróblewski created FELIX-6571:
----------------------------------------

             Summary: Possible leverage of johnzon config to simplify cm.json
                 Key: FELIX-6571
                 URL: https://issues.apache.org/jira/browse/FELIX-6571
             Project: Felix
          Issue Type: Improvement
          Components: Configurator
            Reporter: Aleksy Wróblewski
         Attachments: patch

When looking into KARAF-7436 I noticed that there's some text processing code in cm.json that manually removes comments from JSON cfg files, i.e. the methods Configurations#jsonCommentAwareReader, JsonSupport#createCommentRemovingReader, JsonSupport#removeComments.

 
This could be removed by leveraging Johnzon configuration, see here: [https://rmannibucau.wordpress.com/2015/01/05/json-for-configuration-apache-johnzon-made-another-step-with-comments/] and the [^patch]. 

This would simplify the module a bit, I guess a drawback is that some implementation details are leaked (johnzon is not mentioned anywhere else in the code). 

Thoughts?
 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)