You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by Bryan Duxbury <br...@rapleaf.com> on 2010/06/24 16:08:48 UTC

Thrift 0.3.0 RC 5

Hey all,

After finding some problems with RC4, here we go again!

I propose we accept
http://people.apache.org/~bryanduxbury/thrift-0.3.0-rc5.tar.gz as the
official Thrift 0.3.0 release. It was created by checking out the 0.3.0
branch and running "make dist".

The GPG signature can be found at
http://people.apache.org/~bryanduxbury/thrift-0.3.0-rc5.tar.gz.asc, and the
tarball has an MD5 sum of 0c57277cbe0479b81dfed7e72a382036.

Please download, verify the sum and signature, untar, and build the compiler
and libraries of your choice.

Looking forward to your +1 votes!

-Bryan

Re: Thrift 0.3.0 RC 5

Posted by Jools <jo...@gmail.com>.
+1 non binding vote.

In use in production, currently without issues.

--Jools

Re: Thrift 0.3.0 RC 5

Posted by Joe Schaefer <jo...@yahoo.com>.
+1- sig is here:

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQBMQ3h+sxshPSCPUGQRAijFAJ9jpkyHfbvxON07/QG5G/LInusxvwCdE2Gq
/OeA1rnX/n8EX1ve7frKlO8=
=VVXK
-----END PGP SIGNATURE-----



----- Original Message ----

> From: Mark Slee <ms...@facebook.com>
> To: "thrift-dev@incubator.apache.org" <th...@incubator.apache.org>
> Sent: Thu, June 24, 2010 2:26:45 PM
> Subject: RE: Thrift 0.3.0 RC 5
> 
> +1. Built without issue for me.
> 
> -----Original Message-----
> From:  Upayavira [mailto:uv@odoko.co.uk] 
> Sent: Thursday, June 24,  2010 10:45 AM
> To: thrift-dev@incubator.apache.org
> Subject:  Re: Thrift 0.3.0 RC 5
> 
> On Thu, 2010-06-24 at 07:08 -0700, Bryan Duxbury  wrote: 
> > Hey all,
> > 
> > After finding some problems with RC4,  here we go again!
> > 
> > I propose we accept
> >  http://people.apache.org/~bryanduxbury/thrift-0.3.0-rc5.tar.gz as the
> >  official Thrift 0.3.0 release. It was created by checking out the 0.3.0
> >  branch and running "make dist".
> > 
> > The GPG signature can be found  at
> > http://people.apache.org/~bryanduxbury/thrift-0.3.0-rc5.tar.gz.asc,  and the
> > tarball has an MD5 sum of  0c57277cbe0479b81dfed7e72a382036.
> > 
> > Please download, verify the  sum and signature, untar, and build the 
compiler
> > and libraries of your  choice.
> > 
> > Looking forward to your +1 votes!
> 
> I notice that  NEWS and CONTRIBUTORS are both out of date. This does not
> block this release  for me, but it would be good to sort that for future.
> I'd certainly be  inclined to remove CONTRIBUTORS, and update NEWS from
> Jira, as was done on  the 0.2.0 release.
> 
> So, from me, +1.
> 
> Well  done!
> 
> Upayavira
> 
> 
> 


      

Re: Thrift 0.3.0 RC 5

Posted by Jake Luciani <ja...@gmail.com>.
+1 !!

 

On Jun 28, 2010, at 9:55 AM, Bryan Duxbury <br...@rapleaf.com> wrote:

> This vote has been open for over 4 days now, and I'm pretty sure we need
> some more +1 votes to pass it. Any other committers want to take a look?
> 
> How about mentors? We need 2 more to make this release official.
> 
> -Bryan
> 
> On Thu, Jun 24, 2010 at 11:26 AM, Mark Slee <ms...@facebook.com> wrote:
> 
>> +1. Built without issue for me.
>> 
>> -----Original Message-----
>> From: Upayavira [mailto:uv@odoko.co.uk]
>> Sent: Thursday, June 24, 2010 10:45 AM
>> To: thrift-dev@incubator.apache.org
>> Subject: Re: Thrift 0.3.0 RC 5
>> 
>> On Thu, 2010-06-24 at 07:08 -0700, Bryan Duxbury wrote:
>>> Hey all,
>>> 
>>> After finding some problems with RC4, here we go again!
>>> 
>>> I propose we accept
>>> http://people.apache.org/~bryanduxbury/thrift-0.3.0-rc5.tar.gz<http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc5.tar.gz>as the
>>> official Thrift 0.3.0 release. It was created by checking out the 0.3.0
>>> branch and running "make dist".
>>> 
>>> The GPG signature can be found at
>>> http://people.apache.org/~bryanduxbury/thrift-0.3.0-rc5.tar.gz.asc<http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc5.tar.gz.asc>,
>> and the
>>> tarball has an MD5 sum of 0c57277cbe0479b81dfed7e72a382036.
>>> 
>>> Please download, verify the sum and signature, untar, and build the
>> compiler
>>> and libraries of your choice.
>>> 
>>> Looking forward to your +1 votes!
>> 
>> I notice that NEWS and CONTRIBUTORS are both out of date. This does not
>> block this release for me, but it would be good to sort that for future.
>> I'd certainly be inclined to remove CONTRIBUTORS, and update NEWS from
>> Jira, as was done on the 0.2.0 release.
>> 
>> So, from me, +1.
>> 
>> Well done!
>> 
>> Upayavira
>> 
>> 
>> 

Re: [VOTE] Thrift 0.3.0 RC 5

Posted by sebb <se...@gmail.com>.
On 14 July 2010 21:58, Upayavira <uv...@odoko.co.uk> wrote:
> Following up on Bryan's mail, we'd like to complete a release of Thrift
> 0.3.0 RC5, and would like additional incubator PMC votes.
>
> We have so far had one IPMC vote (mine) and four PPMC votes.
>
> So, please take a look at:
>
> http://people.apache.org/~bryanduxbury/thrift-0.3.0-rc5.tar.gz
>

To check the sigs, we need a pointer to the KEYS file, and to check
the source, a pointer to the SVN tag.

Also, there should be either MD5 or SHA1 hashes (or both) for download checking.

NOTICE is wrong:
"Copyright 2006-2009 The Apache Software Foundation, et al."

The et al. is not permitted, AFAIK, and both dates look wrong.

It looks like some of the file licenses may need to be mentioned in
the NOTICE file (I've not checked in detail)

Some source files don't have AL headers (nor any license):

For example:

lib/as3/src/org/apache/thrift/Set.as

There are some others; a RAT report will detect these.

I think all the above are blockers, especially in combination.

==

The README does not mention what the OS and dependency pre-requisites are.

> And vote!
>
> Thanks in advance,
>
> Upayavira
>
> On Tue, 2010-07-13 at 09:19 -0700, Bryan Duxbury wrote:
>> Hi there,
>>
>> Thrift's 0.3.0 release vote has been stalled waiting for votes from IPMC
>> members to pass it. Is there anyone who would be willing to weigh in?
>>
>> -Bryan
>>
>> ---------- Forwarded message ----------
>> From: Roger Meier <ro...@bufferoverflow.ch>
>> Date: Tue, Jun 29, 2010 at 12:27 PM
>> Subject: Re: Thrift 0.3.0 RC 5
>> To: thrift-dev@incubator.apache.org
>>
>>
>> C++ parts are ready to use in productive environment!
>>
>> I had a minor issue with JavaScript under some special circumstances,
>> that's absolutly not a  blocker for that 0.3.0 release.
>>
>> please release and fix minor issues with a 0.3.1
>>
>> a +1 ! It's a fantastic piece of software, thank you guys!
>>
>>
>> Roger
>>
>>
>> Just go ahead do the release and
>> Am 28.06.2010 15:55, schrieb Bryan Duxbury:
>>
>> > This vote has been open for over 4 days now, and I'm pretty sure we need
>> > some more +1 votes to pass it. Any other committers want to take a look?
>> >
>> > How about mentors? We need 2 more to make this release official.
>> >
>> > -Bryan
>> >
>> > On Thu, Jun 24, 2010 at 11:26 AM, Mark Slee<ms...@facebook.com>  wrote:
>> >
>> >  +1. Built without issue for me.
>> >>
>> >> -----Original Message-----
>> >> From: Upayavira [mailto:uv@odoko.co.uk]
>> >> Sent: Thursday, June 24, 2010 10:45 AM
>> >> To: thrift-dev@incubator.apache.org
>> >> Subject: Re: Thrift 0.3.0 RC 5
>> >>
>> >> On Thu, 2010-06-24 at 07:08 -0700, Bryan Duxbury wrote:
>> >>
>> >>> Hey all,
>> >>>
>> >>> After finding some problems with RC4, here we go again!
>> >>>
>> >>> I propose we accept
>> >>> http://people.apache.org/~bryanduxbury/thrift-0.3.0-rc5.tar.gz<http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc5.tar.gz>
>> >>> <http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc5.tar.gz>as the
>> >>>
>> >>> official Thrift 0.3.0 release. It was created by checking out the 0.3.0
>> >>> branch and running "make dist".
>> >>>
>> >>> The GPG signature can be found at
>> >>> http://people.apache.org/~bryanduxbury/thrift-0.3.0-rc5.tar.gz.asc<http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc5.tar.gz.asc>
>> >>> <http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc5.tar.gz.asc>,
>> >>>
>> >> and the
>> >>
>> >>> tarball has an MD5 sum of 0c57277cbe0479b81dfed7e72a382036.
>> >>>
>> >>> Please download, verify the sum and signature, untar, and build the
>> >>>
>> >> compiler
>> >>
>> >>> and libraries of your choice.
>> >>>
>> >>> Looking forward to your +1 votes!
>> >>>
>> >>
>> >> I notice that NEWS and CONTRIBUTORS are both out of date. This does not
>> >> block this release for me, but it would be good to sort that for future.
>> >> I'd certainly be inclined to remove CONTRIBUTORS, and update NEWS from
>> >> Jira, as was done on the 0.2.0 release.
>> >>
>> >> So, from me, +1.
>> >>
>> >> Well done!
>> >>
>> >> Upayavira
>> >>
>> >>
>> >>
>> >>
>> >
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


[VOTE] Thrift 0.3.0 RC 5

Posted by Upayavira <uv...@odoko.co.uk>.
Following up on Bryan's mail, we'd like to complete a release of Thrift
0.3.0 RC5, and would like additional incubator PMC votes. 

We have so far had one IPMC vote (mine) and four PPMC votes. 

So, please take a look at:

http://people.apache.org/~bryanduxbury/thrift-0.3.0-rc5.tar.gz

And vote!

Thanks in advance,

Upayavira

On Tue, 2010-07-13 at 09:19 -0700, Bryan Duxbury wrote: 
> Hi there,
> 
> Thrift's 0.3.0 release vote has been stalled waiting for votes from IPMC
> members to pass it. Is there anyone who would be willing to weigh in?
> 
> -Bryan
> 
> ---------- Forwarded message ----------
> From: Roger Meier <ro...@bufferoverflow.ch>
> Date: Tue, Jun 29, 2010 at 12:27 PM
> Subject: Re: Thrift 0.3.0 RC 5
> To: thrift-dev@incubator.apache.org
> 
> 
> C++ parts are ready to use in productive environment!
> 
> I had a minor issue with JavaScript under some special circumstances,
> that's absolutly not a  blocker for that 0.3.0 release.
> 
> please release and fix minor issues with a 0.3.1
> 
> a +1 ! It's a fantastic piece of software, thank you guys!
> 
> 
> Roger
> 
> 
> Just go ahead do the release and
> Am 28.06.2010 15:55, schrieb Bryan Duxbury:
> 
> > This vote has been open for over 4 days now, and I'm pretty sure we need
> > some more +1 votes to pass it. Any other committers want to take a look?
> >
> > How about mentors? We need 2 more to make this release official.
> >
> > -Bryan
> >
> > On Thu, Jun 24, 2010 at 11:26 AM, Mark Slee<ms...@facebook.com>  wrote:
> >
> >  +1. Built without issue for me.
> >>
> >> -----Original Message-----
> >> From: Upayavira [mailto:uv@odoko.co.uk]
> >> Sent: Thursday, June 24, 2010 10:45 AM
> >> To: thrift-dev@incubator.apache.org
> >> Subject: Re: Thrift 0.3.0 RC 5
> >>
> >> On Thu, 2010-06-24 at 07:08 -0700, Bryan Duxbury wrote:
> >>
> >>> Hey all,
> >>>
> >>> After finding some problems with RC4, here we go again!
> >>>
> >>> I propose we accept
> >>> http://people.apache.org/~bryanduxbury/thrift-0.3.0-rc5.tar.gz<http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc5.tar.gz>
> >>> <http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc5.tar.gz>as the
> >>>
> >>> official Thrift 0.3.0 release. It was created by checking out the 0.3.0
> >>> branch and running "make dist".
> >>>
> >>> The GPG signature can be found at
> >>> http://people.apache.org/~bryanduxbury/thrift-0.3.0-rc5.tar.gz.asc<http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc5.tar.gz.asc>
> >>> <http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc5.tar.gz.asc>,
> >>>
> >> and the
> >>
> >>> tarball has an MD5 sum of 0c57277cbe0479b81dfed7e72a382036.
> >>>
> >>> Please download, verify the sum and signature, untar, and build the
> >>>
> >> compiler
> >>
> >>> and libraries of your choice.
> >>>
> >>> Looking forward to your +1 votes!
> >>>
> >>
> >> I notice that NEWS and CONTRIBUTORS are both out of date. This does not
> >> block this release for me, but it would be good to sort that for future.
> >> I'd certainly be inclined to remove CONTRIBUTORS, and update NEWS from
> >> Jira, as was done on the 0.2.0 release.
> >>
> >> So, from me, +1.
> >>
> >> Well done!
> >>
> >> Upayavira
> >>
> >>
> >>
> >>
> >



---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Fwd: Thrift 0.3.0 RC 5

Posted by Bryan Duxbury <br...@rapleaf.com>.
Hi there,

Thrift's 0.3.0 release vote has been stalled waiting for votes from IPMC
members to pass it. Is there anyone who would be willing to weigh in?

-Bryan

---------- Forwarded message ----------
From: Roger Meier <ro...@bufferoverflow.ch>
Date: Tue, Jun 29, 2010 at 12:27 PM
Subject: Re: Thrift 0.3.0 RC 5
To: thrift-dev@incubator.apache.org


C++ parts are ready to use in productive environment!

I had a minor issue with JavaScript under some special circumstances,
that's absolutly not a  blocker for that 0.3.0 release.

please release and fix minor issues with a 0.3.1

a +1 ! It's a fantastic piece of software, thank you guys!


Roger


Just go ahead do the release and
Am 28.06.2010 15:55, schrieb Bryan Duxbury:

> This vote has been open for over 4 days now, and I'm pretty sure we need
> some more +1 votes to pass it. Any other committers want to take a look?
>
> How about mentors? We need 2 more to make this release official.
>
> -Bryan
>
> On Thu, Jun 24, 2010 at 11:26 AM, Mark Slee<ms...@facebook.com>  wrote:
>
>  +1. Built without issue for me.
>>
>> -----Original Message-----
>> From: Upayavira [mailto:uv@odoko.co.uk]
>> Sent: Thursday, June 24, 2010 10:45 AM
>> To: thrift-dev@incubator.apache.org
>> Subject: Re: Thrift 0.3.0 RC 5
>>
>> On Thu, 2010-06-24 at 07:08 -0700, Bryan Duxbury wrote:
>>
>>> Hey all,
>>>
>>> After finding some problems with RC4, here we go again!
>>>
>>> I propose we accept
>>> http://people.apache.org/~bryanduxbury/thrift-0.3.0-rc5.tar.gz<http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc5.tar.gz>
>>> <http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc5.tar.gz>as the
>>>
>>> official Thrift 0.3.0 release. It was created by checking out the 0.3.0
>>> branch and running "make dist".
>>>
>>> The GPG signature can be found at
>>> http://people.apache.org/~bryanduxbury/thrift-0.3.0-rc5.tar.gz.asc<http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc5.tar.gz.asc>
>>> <http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc5.tar.gz.asc>,
>>>
>> and the
>>
>>> tarball has an MD5 sum of 0c57277cbe0479b81dfed7e72a382036.
>>>
>>> Please download, verify the sum and signature, untar, and build the
>>>
>> compiler
>>
>>> and libraries of your choice.
>>>
>>> Looking forward to your +1 votes!
>>>
>>
>> I notice that NEWS and CONTRIBUTORS are both out of date. This does not
>> block this release for me, but it would be good to sort that for future.
>> I'd certainly be inclined to remove CONTRIBUTORS, and update NEWS from
>> Jira, as was done on the 0.2.0 release.
>>
>> So, from me, +1.
>>
>> Well done!
>>
>> Upayavira
>>
>>
>>
>>
>

Re: Thrift 0.3.0 RC 5

Posted by Roger Meier <ro...@bufferoverflow.ch>.
C++ parts are ready to use in productive environment!

I had a minor issue with JavaScript under some special circumstances,
that's absolutly not a  blocker for that 0.3.0 release.

please release and fix minor issues with a 0.3.1

a +1 ! It's a fantastic piece of software, thank you guys!


Roger


Just go ahead do the release and
Am 28.06.2010 15:55, schrieb Bryan Duxbury:
> This vote has been open for over 4 days now, and I'm pretty sure we need
> some more +1 votes to pass it. Any other committers want to take a look?
>
> How about mentors? We need 2 more to make this release official.
>
> -Bryan
>
> On Thu, Jun 24, 2010 at 11:26 AM, Mark Slee<ms...@facebook.com>  wrote:
>
>> +1. Built without issue for me.
>>
>> -----Original Message-----
>> From: Upayavira [mailto:uv@odoko.co.uk]
>> Sent: Thursday, June 24, 2010 10:45 AM
>> To: thrift-dev@incubator.apache.org
>> Subject: Re: Thrift 0.3.0 RC 5
>>
>> On Thu, 2010-06-24 at 07:08 -0700, Bryan Duxbury wrote:
>>> Hey all,
>>>
>>> After finding some problems with RC4, here we go again!
>>>
>>> I propose we accept
>>> http://people.apache.org/~bryanduxbury/thrift-0.3.0-rc5.tar.gz<http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc5.tar.gz>as the
>>> official Thrift 0.3.0 release. It was created by checking out the 0.3.0
>>> branch and running "make dist".
>>>
>>> The GPG signature can be found at
>>> http://people.apache.org/~bryanduxbury/thrift-0.3.0-rc5.tar.gz.asc<http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc5.tar.gz.asc>,
>> and the
>>> tarball has an MD5 sum of 0c57277cbe0479b81dfed7e72a382036.
>>>
>>> Please download, verify the sum and signature, untar, and build the
>> compiler
>>> and libraries of your choice.
>>>
>>> Looking forward to your +1 votes!
>>
>> I notice that NEWS and CONTRIBUTORS are both out of date. This does not
>> block this release for me, but it would be good to sort that for future.
>> I'd certainly be inclined to remove CONTRIBUTORS, and update NEWS from
>> Jira, as was done on the 0.2.0 release.
>>
>> So, from me, +1.
>>
>> Well done!
>>
>> Upayavira
>>
>>
>>
>


Re: Thrift 0.3.0 RC 5

Posted by Tupshin Harper <tu...@tupshin.com>.
  Non-binding +1 from me. I have been running 0.6.3-pre (in a 
non-critical production environment) for 4 days or so. I have seen no 
regressions from 0.6.2, and some of the 0.6.3 fixes are quite important.

-Tupshin

On 6/28/2010 7:03 AM, Upayavira wrote:
> On Mon, 2010-06-28 at 06:55 -0700, Bryan Duxbury wrote:
>> This vote has been open for over 4 days now, and I'm pretty sure we
>> need some more +1 votes to pass it. Any other committers want to take
>> a look?
>>
>> How about mentors? We need 2 more to make this release official.
> Strictly speaking, all we need is three incubator PMC member votes - but
> we're unlikely to get those without a definite show from the community
> that they're behind it.
>
> So, folks, please validate this release and let us know what you make of
> it.
>
> Upayavira
>


Re: Thrift 0.3.0 RC 5

Posted by Upayavira <uv...@odoko.co.uk>.
On Mon, 2010-06-28 at 06:55 -0700, Bryan Duxbury wrote:
> This vote has been open for over 4 days now, and I'm pretty sure we
> need some more +1 votes to pass it. Any other committers want to take
> a look?
> 
> How about mentors? We need 2 more to make this release official.

Strictly speaking, all we need is three incubator PMC member votes - but
we're unlikely to get those without a definite show from the community
that they're behind it.

So, folks, please validate this release and let us know what you make of
it.

Upayavira


Re: Thrift 0.3.0 RC 5

Posted by Bryan Duxbury <br...@rapleaf.com>.
This vote has been open for over 4 days now, and I'm pretty sure we need
some more +1 votes to pass it. Any other committers want to take a look?

How about mentors? We need 2 more to make this release official.

-Bryan

On Thu, Jun 24, 2010 at 11:26 AM, Mark Slee <ms...@facebook.com> wrote:

> +1. Built without issue for me.
>
> -----Original Message-----
> From: Upayavira [mailto:uv@odoko.co.uk]
> Sent: Thursday, June 24, 2010 10:45 AM
> To: thrift-dev@incubator.apache.org
> Subject: Re: Thrift 0.3.0 RC 5
>
> On Thu, 2010-06-24 at 07:08 -0700, Bryan Duxbury wrote:
> > Hey all,
> >
> > After finding some problems with RC4, here we go again!
> >
> > I propose we accept
> > http://people.apache.org/~bryanduxbury/thrift-0.3.0-rc5.tar.gz<http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc5.tar.gz>as the
> > official Thrift 0.3.0 release. It was created by checking out the 0.3.0
> > branch and running "make dist".
> >
> > The GPG signature can be found at
> > http://people.apache.org/~bryanduxbury/thrift-0.3.0-rc5.tar.gz.asc<http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc5.tar.gz.asc>,
> and the
> > tarball has an MD5 sum of 0c57277cbe0479b81dfed7e72a382036.
> >
> > Please download, verify the sum and signature, untar, and build the
> compiler
> > and libraries of your choice.
> >
> > Looking forward to your +1 votes!
>
> I notice that NEWS and CONTRIBUTORS are both out of date. This does not
> block this release for me, but it would be good to sort that for future.
> I'd certainly be inclined to remove CONTRIBUTORS, and update NEWS from
> Jira, as was done on the 0.2.0 release.
>
> So, from me, +1.
>
> Well done!
>
> Upayavira
>
>
>

RE: Thrift 0.3.0 RC 5

Posted by Mark Slee <ms...@facebook.com>.
+1. Built without issue for me.

-----Original Message-----
From: Upayavira [mailto:uv@odoko.co.uk] 
Sent: Thursday, June 24, 2010 10:45 AM
To: thrift-dev@incubator.apache.org
Subject: Re: Thrift 0.3.0 RC 5

On Thu, 2010-06-24 at 07:08 -0700, Bryan Duxbury wrote: 
> Hey all,
> 
> After finding some problems with RC4, here we go again!
> 
> I propose we accept
> http://people.apache.org/~bryanduxbury/thrift-0.3.0-rc5.tar.gz as the
> official Thrift 0.3.0 release. It was created by checking out the 0.3.0
> branch and running "make dist".
> 
> The GPG signature can be found at
> http://people.apache.org/~bryanduxbury/thrift-0.3.0-rc5.tar.gz.asc, and the
> tarball has an MD5 sum of 0c57277cbe0479b81dfed7e72a382036.
> 
> Please download, verify the sum and signature, untar, and build the compiler
> and libraries of your choice.
> 
> Looking forward to your +1 votes!

I notice that NEWS and CONTRIBUTORS are both out of date. This does not
block this release for me, but it would be good to sort that for future.
I'd certainly be inclined to remove CONTRIBUTORS, and update NEWS from
Jira, as was done on the 0.2.0 release.

So, from me, +1.

Well done!

Upayavira



Re: Thrift 0.3.0 RC 5

Posted by Upayavira <uv...@odoko.co.uk>.
On Thu, 2010-06-24 at 07:08 -0700, Bryan Duxbury wrote: 
> Hey all,
> 
> After finding some problems with RC4, here we go again!
> 
> I propose we accept
> http://people.apache.org/~bryanduxbury/thrift-0.3.0-rc5.tar.gz as the
> official Thrift 0.3.0 release. It was created by checking out the 0.3.0
> branch and running "make dist".
> 
> The GPG signature can be found at
> http://people.apache.org/~bryanduxbury/thrift-0.3.0-rc5.tar.gz.asc, and the
> tarball has an MD5 sum of 0c57277cbe0479b81dfed7e72a382036.
> 
> Please download, verify the sum and signature, untar, and build the compiler
> and libraries of your choice.
> 
> Looking forward to your +1 votes!

I notice that NEWS and CONTRIBUTORS are both out of date. This does not
block this release for me, but it would be good to sort that for future.
I'd certainly be inclined to remove CONTRIBUTORS, and update NEWS from
Jira, as was done on the 0.2.0 release.

So, from me, +1.

Well done!

Upayavira



Re: Thrift 0.3.0 RC 5

Posted by Doug Cutting <cu...@apache.org>.
On 07/23/2010 10:21 AM, Bryan Duxbury wrote:
> Where is this RAT tool? I'd never heard of it before sebb@ mentioned he used
> it.

http://incubator.apache.org/rat/

> The MD5 hash was included in the original vote email I sent out, and I think
> it just managed to go uncopied when it was sent to general@. Is there a file
> I'm supposed to put somewhere?

Yes.  The RC should contain the files you intend to distribute, e.g.:

http://www.apache.org/dist/incubator/thrift/0.2.0-incubating/

Every file in www.apache.org/dist should have both a .asc and a .md5 and 
(optionally) a .sha.

http://www.apache.org/dev/release-signing.html#policy

Doug

> I will try to get a new tarball up with these fixes today or over the
> weekend.
>
> -Bryan
>
> On Fri, Jul 23, 2010 at 10:12 AM, Doug Cutting<cu...@apache.org>  wrote:
>
>> The sig checks out, and tests pass, but RAT finds a few license issues, as
>> noted also by sebb on general@.
>>
>> It would make this check simpler if Thrift included a rat excludes file, as
>> many of the files that RAT identifies are not a problem, e.g., m4 files,
>> which are hard to stick licenses into, or Bison generated files, whose
>> license has an exception.  But there are at least a few files that can and
>> should contain the Apache license but which do not, e.g.:
>>
>>   lib/java/src/org/apache/thrift/TFieldIdEnum.java
>>   lib/java/test/org/apache/thrift/protocol/TestTBinaryProtocol.java
>>
>> Sebb also noted that the NOTICE file contains the wrong date, and that no
>> MD5 or SHA1 hash files were generated for the tarball.
>>
>> Bryan, are you able to fix these and roll another candidate?
>>
>> Doug
>>
>>
>> On 06/24/2010 07:08 AM, Bryan Duxbury wrote:
>>
>>> Hey all,
>>>
>>> After finding some problems with RC4, here we go again!
>>>
>>> I propose we accept
>>> http://people.apache.org/~bryanduxbury/thrift-0.3.0-rc5.tar.gz<http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc5.tar.gz>as the
>>> official Thrift 0.3.0 release. It was created by checking out the 0.3.0
>>> branch and running "make dist".
>>>
>>> The GPG signature can be found at
>>> http://people.apache.org/~bryanduxbury/thrift-0.3.0-rc5.tar.gz.asc<http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc5.tar.gz.asc>,
>>> and the
>>> tarball has an MD5 sum of 0c57277cbe0479b81dfed7e72a382036.
>>>
>>> Please download, verify the sum and signature, untar, and build the
>>> compiler
>>> and libraries of your choice.
>>>
>>> Looking forward to your +1 votes!
>>>
>>> -Bryan
>>>
>>>
>

Re: Thrift 0.3.0 RC 5

Posted by Bryan Duxbury <br...@rapleaf.com>.
Where is this RAT tool? I'd never heard of it before sebb@ mentioned he used
it.

I'll have a look at the NOTICE as well.

The MD5 hash was included in the original vote email I sent out, and I think
it just managed to go uncopied when it was sent to general@. Is there a file
I'm supposed to put somewhere?

I will try to get a new tarball up with these fixes today or over the
weekend.

-Bryan

On Fri, Jul 23, 2010 at 10:12 AM, Doug Cutting <cu...@apache.org> wrote:

> The sig checks out, and tests pass, but RAT finds a few license issues, as
> noted also by sebb on general@.
>
> It would make this check simpler if Thrift included a rat excludes file, as
> many of the files that RAT identifies are not a problem, e.g., m4 files,
> which are hard to stick licenses into, or Bison generated files, whose
> license has an exception.  But there are at least a few files that can and
> should contain the Apache license but which do not, e.g.:
>
>  lib/java/src/org/apache/thrift/TFieldIdEnum.java
>  lib/java/test/org/apache/thrift/protocol/TestTBinaryProtocol.java
>
> Sebb also noted that the NOTICE file contains the wrong date, and that no
> MD5 or SHA1 hash files were generated for the tarball.
>
> Bryan, are you able to fix these and roll another candidate?
>
> Doug
>
>
> On 06/24/2010 07:08 AM, Bryan Duxbury wrote:
>
>> Hey all,
>>
>> After finding some problems with RC4, here we go again!
>>
>> I propose we accept
>> http://people.apache.org/~bryanduxbury/thrift-0.3.0-rc5.tar.gz<http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc5.tar.gz>as the
>> official Thrift 0.3.0 release. It was created by checking out the 0.3.0
>> branch and running "make dist".
>>
>> The GPG signature can be found at
>> http://people.apache.org/~bryanduxbury/thrift-0.3.0-rc5.tar.gz.asc<http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc5.tar.gz.asc>,
>> and the
>> tarball has an MD5 sum of 0c57277cbe0479b81dfed7e72a382036.
>>
>> Please download, verify the sum and signature, untar, and build the
>> compiler
>> and libraries of your choice.
>>
>> Looking forward to your +1 votes!
>>
>> -Bryan
>>
>>

Re: Thrift 0.3.0 RC 5

Posted by Doug Cutting <cu...@apache.org>.
The sig checks out, and tests pass, but RAT finds a few license issues, 
as noted also by sebb on general@.

It would make this check simpler if Thrift included a rat excludes file, 
as many of the files that RAT identifies are not a problem, e.g., m4 
files, which are hard to stick licenses into, or Bison generated files, 
whose license has an exception.  But there are at least a few files that 
can and should contain the Apache license but which do not, e.g.:

  lib/java/src/org/apache/thrift/TFieldIdEnum.java
  lib/java/test/org/apache/thrift/protocol/TestTBinaryProtocol.java

Sebb also noted that the NOTICE file contains the wrong date, and that 
no MD5 or SHA1 hash files were generated for the tarball.

Bryan, are you able to fix these and roll another candidate?

Doug

On 06/24/2010 07:08 AM, Bryan Duxbury wrote:
> Hey all,
>
> After finding some problems with RC4, here we go again!
>
> I propose we accept
> http://people.apache.org/~bryanduxbury/thrift-0.3.0-rc5.tar.gz as the
> official Thrift 0.3.0 release. It was created by checking out the 0.3.0
> branch and running "make dist".
>
> The GPG signature can be found at
> http://people.apache.org/~bryanduxbury/thrift-0.3.0-rc5.tar.gz.asc, and the
> tarball has an MD5 sum of 0c57277cbe0479b81dfed7e72a382036.
>
> Please download, verify the sum and signature, untar, and build the compiler
> and libraries of your choice.
>
> Looking forward to your +1 votes!
>
> -Bryan
>

Re: Thrift 0.3.0 RC 5

Posted by David Reiss <dr...@facebook.com>.
+1

Bryan Duxbury wrote:
> Hey all,
> 
> After finding some problems with RC4, here we go again!
> 
> I propose we accept
> http://people.apache.org/~bryanduxbury/thrift-0.3.0-rc5.tar.gz as the
> official Thrift 0.3.0 release. It was created by checking out the 0.3.0
> branch and running "make dist".
> 
> The GPG signature can be found at
> http://people.apache.org/~bryanduxbury/thrift-0.3.0-rc5.tar.gz.asc, and the
> tarball has an MD5 sum of 0c57277cbe0479b81dfed7e72a382036.
> 
> Please download, verify the sum and signature, untar, and build the compiler
> and libraries of your choice.
> 
> Looking forward to your +1 votes!
> 
> -Bryan
>