You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/01/11 23:56:57 UTC

[GitHub] potiuk commented on issue #4493: [AIRFLOW-3680] Consistency update in tests for All GCP-related operators

potiuk commented on issue #4493: [AIRFLOW-3680] Consistency update in tests for All GCP-related operators
URL: https://github.com/apache/airflow/pull/4493#issuecomment-453694944
 
 
   @jmcarp  -> you might be interested in this one. I agreed with @kaxil that we should merge all the optional project id change for all 30+ GCP operators in single PR. This PR is now ready to be opened (https://github.com/PolideaInternal/airflow/pull/35) but we need to merge this "consistency" update first. 
   
   This "consistency" PR is really all about changing test variables and consistent approach for system testing for all GCP operators and aligning naming (integration vs. system tests). When this is merged we can very easily tests (I've done that already) that the project_id change can pass all the system tests with real GCP project. 
   
   This change touches some variable names in operators you were involved with so I think it's good if you are aware of that @jmcarp 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services