You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/07/15 18:53:43 UTC

[GitHub] [beam] damondouglas commented on a diff in pull request #22098: Fix retaining unsaved pipeline options (#22075)

damondouglas commented on code in PR #22098:
URL: https://github.com/apache/beam/pull/22098#discussion_r922440571


##########
playground/frontend/lib/modules/editor/components/pipeline_options_dropdown/pipeline_option_controller.dart:
##########
@@ -16,14 +16,19 @@
  * limitations under the License.
  */
 
-import 'package:flutter/cupertino.dart';
+import 'package:flutter/widgets.dart';
 
 class PipelineOptionController {
-  final TextEditingController name = TextEditingController();
-  final TextEditingController value = TextEditingController();
+  final TextEditingController nameController = TextEditingController();

Review Comment:
   @alexeyinkin Maybe change to: `final nameController = TextEditingController();`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org