You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by mtunique <gi...@git.apache.org> on 2017/02/28 15:08:24 UTC
[GitHub] flink pull request #3428: [FLINK-1743] Add multinomial logistic regression t...
GitHub user mtunique opened a pull request:
https://github.com/apache/flink/pull/3428
[FLINK-1743] Add multinomial logistic regression to machine learning library
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful description of your changes.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
- [x] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
1. Refactor `MultipleLinearRegression` to extend `GeneralizedLinearModel`
2. Implement `LogisticRegression`
3. Change `LogisticLoss` with label in {0, 1}
4. Add `LogisticLinerRegression` test case
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mtunique/flink glm
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3428.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3428
----
commit f2fd9bb4d3b93968ff770180fc6767d0316d8958
Author: mtunique <oa...@gmail.com>
Date: 2017-02-21T10:30:37Z
add logistic regression
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3428: [FLINK-1743] Add multinomial logistic regression to machi...
Posted by thvasilo <gi...@git.apache.org>.
Github user thvasilo commented on the issue:
https://github.com/apache/flink/pull/3428
Thank you for the info!
In that case it's a bit ambiguous now which issue this PR is solving. If you are introducing an interface for GLMs we should be having this discussion under that context, because it changes the scope of the PR quite significantly re. design decisions vs. a simple implementation of logistic regression.
If you want, we can split this into different PRs and take it from there.
P.S. Any code that comes from the Spark project mus be clearly labeled as such, please make sure to give proper attribution.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3428: [FLINK-1743] Add multinomial logistic regression to machi...
Posted by thvasilo <gi...@git.apache.org>.
Github user thvasilo commented on the issue:
https://github.com/apache/flink/pull/3428
Hello @mtunique and thank you for you contribution!
Could you briefly describe your changes/additions and how you have tested the implementation for correctness?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3428: [FLINK-1743] Add multinomial logistic regression to machi...
Posted by mtunique <gi...@git.apache.org>.
Github user mtunique commented on the issue:
https://github.com/apache/flink/pull/3428
@thvasilo After #3756 is merged, I will change this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3428: [FLINK-1743] Add multinomial logistic regression to machi...
Posted by thvasilo <gi...@git.apache.org>.
Github user thvasilo commented on the issue:
https://github.com/apache/flink/pull/3428
Hello @bowenli86, AFAIK nobody's working on the PR's right now. I'm currently 100% focused on finishing my PhD so I won't have time to review.
---
[GitHub] flink issue #3428: [FLINK-1743] Add multinomial logistic regression to machi...
Posted by mtunique <gi...@git.apache.org>.
Github user mtunique commented on the issue:
https://github.com/apache/flink/pull/3428
Thanks all for the comments.
The code from Spark has be labeled like some other codes from Spark.
I will spilt this PR into two PRs. The other one is for FLINK-2013.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3428: [FLINK-1743] Add multinomial logistic regression to machi...
Posted by mtunique <gi...@git.apache.org>.
Github user mtunique commented on the issue:
https://github.com/apache/flink/pull/3428
@thvasilo
- Add `MultipleLinearRegression ` to provide interfaces for the set of common properties and functions generalized linear models share.
- Change `LogisticLoss` to let it be with label in {0, 1}
- `LogisticLinerRegression` test: This test is originally from the Apache Spark project. Training Data: Weights are created randomly. Label is calculated by given scale and offset.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3428: [FLINK-1743] Add multinomial logistic regression to machi...
Posted by bowenli86 <gi...@git.apache.org>.
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/3428
Hi @mtunique any update on this PR?
---