You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by di...@apache.org on 2023/07/03 15:26:53 UTC
[kafka-site] branch revert-529-patch-1 created (now df38746e)
This is an automated email from the ASF dual-hosted git repository.
divijv pushed a change to branch revert-529-patch-1
in repository https://gitbox.apache.org/repos/asf/kafka-site.git
at df38746e Revert "MINOR: Fix typo in coding-guide.html (#529)"
This branch includes the following new commits:
new df38746e Revert "MINOR: Fix typo in coding-guide.html (#529)"
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
[kafka-site] 01/01: Revert "MINOR: Fix typo in coding-guide.html (#529)"
Posted by di...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
divijv pushed a commit to branch revert-529-patch-1
in repository https://gitbox.apache.org/repos/asf/kafka-site.git
commit df38746eab6f8b96b7df890f24edbe90a72723c3
Author: Divij Vaidya <di...@amazon.com>
AuthorDate: Mon Jul 3 17:26:49 2023 +0200
Revert "MINOR: Fix typo in coding-guide.html (#529)"
This reverts commit 4de394f2ff19eef742b9e08098e329da2c7d0146.
---
coding-guide.html | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/coding-guide.html b/coding-guide.html
index 41e5fbd0..22ade9fa 100644
--- a/coding-guide.html
+++ b/coding-guide.html
@@ -11,7 +11,7 @@
<h2>Basic Stuff</h2>
<ul>
- <li>Avoid cryptic abbreviations. Single letter variable names are fine in very short methods with few variables, otherwise make themnn informative.</li>
+ <li>Avoid cryptic abbreviations. Single letter variable names are fine in very short methods with few variables, otherwise make them informative.</li>
<li>Clear code is preferable to comments. When possible make your naming so good you don't need comments. When that isn't possible comments should be thought of as mandatory, write them to be <i>read</i>.</li>
<li>Logging, configuration, and public APIs are our "UI". Pay special attention to them and make them pretty, consistent, and usable.</li>
<li>There is not a maximum line length (certainly not 80 characters, we don't work on punch cards any more), but be reasonable.</li>