You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "JosiahWI (via GitHub)" <gi...@apache.org> on 2023/06/21 12:34:00 UTC
[GitHub] [trafficserver] JosiahWI opened a new pull request, #9892: Add support for quic to CMake build
JosiahWI opened a new pull request, #9892:
URL: https://github.com/apache/trafficserver/pull/9892
This adds an option that defaults to OFF: ENABLE_QUICHE. When quiche is enabled, the quic static library and the http3 static library will be built and linked appropriately.
It also does some cleanup of targets in the CMake build. Some targets are now namespaced in ts:: to make it explicit which targets are part of trafficserver, and to make usage style consistent with that of third-party libraries. Some dependencies have also been corrected, and comments added where dependencies are misrepresented by necessity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit commented on a diff in pull request #9892: Add support for quic to CMake build
Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit commented on code in PR #9892:
URL: https://github.com/apache/trafficserver/pull/9892#discussion_r1237246127
##########
CMakeLists.txt:
##########
@@ -313,6 +327,9 @@ add_subdirectory(mgmt/config)
add_subdirectory(mgmt/rpc)
add_subdirectory(src/traffic_server)
add_subdirectory(src/traffic_ctl)
+if(TS_USE_QUIC)
+ add_subdirectory(src/traffic_quic)
Review Comment:
Thanks for taking care of this, but actually we no longer maintain it. https://github.com/apache/trafficserver/pull/9726
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] JosiahWI commented on pull request #9892: Add support for quic to CMake build
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on PR #9892:
URL: https://github.com/apache/trafficserver/pull/9892#issuecomment-1601288176
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #9892: Add support for quic to CMake build
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #9892:
URL: https://github.com/apache/trafficserver/pull/9892#issuecomment-1601362933
[approve ci rocky]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] JosiahWI commented on pull request #9892: Add support for quic to CMake build
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on PR #9892:
URL: https://github.com/apache/trafficserver/pull/9892#issuecomment-1601287999
Test "TSVConnFD" failed with code -9.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] JosiahWI commented on a diff in pull request #9892: Add support for quic to CMake build
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on code in PR #9892:
URL: https://github.com/apache/trafficserver/pull/9892#discussion_r1237297789
##########
CMakeLists.txt:
##########
@@ -313,6 +327,9 @@ add_subdirectory(mgmt/config)
add_subdirectory(mgmt/rpc)
add_subdirectory(src/traffic_server)
add_subdirectory(src/traffic_ctl)
+if(TS_USE_QUIC)
+ add_subdirectory(src/traffic_quic)
Review Comment:
Thanks, I'll follow suite and obliterate it from the CMake build as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt merged pull request #9892: Add support for quic to CMake build
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt merged PR #9892:
URL: https://github.com/apache/trafficserver/pull/9892
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] JosiahWI commented on pull request #9892: Add support for quic to CMake build
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on PR #9892:
URL: https://github.com/apache/trafficserver/pull/9892#issuecomment-1601011761
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org